Commit Graph

918 Commits (3fa96ebf13da203b01b13be7866a0a24f7ca2ed6)

Author SHA1 Message Date
Herman Slatman ef16febf40
Refactor ACME EAB queries
The ACME EAB keys are now also indexed by the provisioner. This
solves part of the issue in which too many EAB keys may be in
memory at a given time.
3 years ago
Mariano Cano 449a9fdfd6 Address review comments. 3 years ago
Mariano Cano b424aa3dc1 Add nebula header and use der version of certificate. 3 years ago
Herman Slatman 30859d3c83
Remove server-side paging logic for ExternalAccountKeys 3 years ago
Mariano Cano f49a4b326f Add missing comments. 3 years ago
Mariano Cano 6600f1253e Fix error messages after review. 3 years ago
Mariano Cano 6a1d0cb9f8 Add linkedca conversions. 3 years ago
Mariano Cano de51c2edfb More unit tests for nebula. 3 years ago
Mariano Cano 99845d38bb Add some extra unit tests for nebula. 3 years ago
Mariano Cano 76794ce613 Use default SANs without sans in the token.
Fix step claim condition in SSH
3 years ago
Herman Slatman 6bc0513468
Add more tests 3 years ago
Mariano Cano 9ec0276887 Update certificate set with new api. 3 years ago
Herman Slatman 9539729bd9
Add initial implementation of x509 and SSH allow/deny policy engine 3 years ago
Mariano Cano cb72796a2d Fix decoding of certificate. 3 years ago
Mariano Cano 32390a2964 Add initial implementation of a nebula provisioner.
A nebula provisioner will generate a X509 or SSH certificate with
the identities in the nebula certificate embedded in the token.
The token is signed with the private key of the nebula certificate.
3 years ago
Herman Slatman 5fe9909174
Refactor AdminAuthority interface 3 years ago
Herman Slatman f9ae875f9d
Use short if-style statements 3 years ago
Herman Slatman 5f224b729e
Add tests for Provisioner Admin API 3 years ago
Herman Slatman 43a78f495f
Add tests for Admin API 3 years ago
Herman Slatman bd169f505f
Add Admin API Middleware tests 3 years ago
Herman Slatman d799359917
Merge branch 'master' into hs/acme-eab 3 years ago
Herman Slatman 63371a8fb6
Add additional tests for ACME EAB Admin 3 years ago
Herman Slatman 3bc3957b06
Merge branch 'master' into hs/acme-revocation 3 years ago
Herman Slatman 2215a05c28
Add tests for ACME EAB Admin
Refactored some of the existing bits for testing the Authority
API by creation of a new LinkedAuthority interface and changing
visibility of the MockAuthority to be usable by other packages.

At this time, not all of the functions of MockAuthority it usable
yet. Will refactor when needed or requested.
3 years ago
Herman Slatman d0c23973cc
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano e0fee84694 Add comment about public key validator. 3 years ago
Herman Slatman 47a8a3c463
Add test case for ACME Revoke to Authority 3 years ago
Herman Slatman a7fbbc4748
Add tests for GetCertificateBySerial 3 years ago
Herman Slatman 2d357da99b
Add tests for ACME revocation 3 years ago
Herman Slatman c9cd876a7d
Merge branch 'master' into hs/acme-revocation 3 years ago
Mariano Cano d35848f7a9 Fix unit tests. 3 years ago
Mariano Cano c3f98fd04d Change some bad requests to forbidded.
Change in the sign options bad requests to forbidded if is the
provisioner the one adding a restriction, e.g. list of dns names,
validity, ...
3 years ago
Mariano Cano ff04873a2a Change the default error type to forbidden in Sign.
The errors will also be propagated from sign options.
3 years ago
Mariano Cano b9beab071d Fix unit tests. 3 years ago
Mariano Cano 507a272b4d Return always http errors in sign options. 3 years ago
Mariano Cano a33709ce8d Fix sign ssh options tests. 3 years ago
Mariano Cano 1da7ea6646 Return always http errors in sign ssh options. 3 years ago
Mariano Cano 031d4d7000 Return BadRequest when validating sign options. 3 years ago
Mariano Cano bb26799583 Modify errs.Wrap with forbidden errors. 3 years ago
Herman Slatman 2d50c96d99
Merge branch 'master' into hs/acme-revocation 3 years ago
Mariano Cano b6ebd118fc Update temporal solution for sending message to users 3 years ago
Mariano Cano 668d3ea6c7 Modify errs.Wrap() with bad request to send messages to users. 3 years ago
Mariano Cano 8c8db0d4b7 Modify errs.BadRequestErr() to always return an error to the client. 3 years ago
Mariano Cano 8ce807a6cb Modify errs.BadRequest() calls to always send an error to the client. 3 years ago
Max de2ce5cf9f
Merge pull request #692 from smallstep/max/context
Context management
3 years ago
Mariano Cano 440616cffa
Merge pull request #750 from smallstep/duration-errors
Report duration errors directly to the cli.
3 years ago
Mariano Cano acd0bac025 Remove extra and in comment. 3 years ago
Mariano Cano 1aadd63cef Use always badRequest on duration errors. 3 years ago
Mariano Cano 41fec1577d Report duration errors directly to the cli. 3 years ago
max furman 7fac8c96c3 Merge branch 'master' into max/context 3 years ago
max furman 922d239171 Simplify conditional 3 years ago
max furman a7d144996f SSH backwards compat updates
- use existence of new value in data map as boolean
- add tests for backwards and forwards compatibility
- fix old tests that used static dir locations
3 years ago
max furman 507be61e8c Use a more distint map key to indicate template version
- make the key a variable that can be reused on the CLI side.
3 years ago
max furman f426c152a9 backwards compatibility for version of cli older than v0.18.0 3 years ago
max furman ed4b56732e updates after rebase to keep up with master 3 years ago
Herman Slatman e7a988b2cd
Pin golangci-lint to v1.43.0 and fix issues 3 years ago
Herman Slatman 3151255a25
Merge branch 'master' into hs/acme-revocation 3 years ago
Herman Slatman 4d726d6b4c
Add pagination to ACME EAB credentials endpoint 3 years ago
Herman Slatman bc5f0e429b
Fix gocritic remark 3 years ago
Herman Slatman d354d55e7f
Improve handling duplicate ACME EAB references 3 years ago
Herman Slatman dd4b4b0435
Fix remaining gocritic remarks 3 years ago
Herman Slatman e0b495e4c8
Merge branch 'master' into hs/acme-eab 3 years ago
Herman Slatman c26041f835
Add ACME EAB nosql tests 3 years ago
max furman 933b40a02a Introduce gocritic linter and address warnings 3 years ago
Herman Slatman f34d68897a
Refactor retrieval of provisioner into middleware 3 years ago
Herman Slatman 9d4cafc4bd
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano 9fb6df3abb Fix ssh template variables when CA is injected using options. 3 years ago
Mariano Cano aedd7fcc05 Be able to start a SSH host or SSH user only CA
In previous versions if the host or user CA is not configured, the
start of step-ca was crashing. This allows to configure a user or
host only ssh ca.
3 years ago
Mariano Cano a50654b468 Check for admins in both emails and groups. 3 years ago
max furman 2d5bfd3485 fix comment 3 years ago
Herman Slatman c2bc1351c6
Add provisioner to remove endpoint and clear reference index on delete 3 years ago
Herman Slatman 746c5c9fd9
Disallow creation of EAB keys with non-unique references 3 years ago
Herman Slatman 9c0020352b
Add lookup by reference and make reference optional 3 years ago
Herman Slatman 02cd3b6b3b
Fix PR comments 3 years ago
Mariano Cano 6729c79253 Add support for setting individual password for ssh and tls keys
This change add the following flags:
 * --ssh-host-password-file
 * --ssh-user-password-file

Fixes #693
3 years ago
Herman Slatman 66464ae302
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano 141c519171 Simplify check of principals in a case insensitive way
Fixes #679
3 years ago
Fearghal O Floinn 7a94b0c157 Converts group and subgroup to lowercase for comparison.
Fixes #679
3 years ago
Mariano Cano f919535475 Add an extra way to distinguish Azure and Azure OIDC tokens.
We used to distinguish these tokens using the azp claim, but this
claim does not appear on new azure oidc tokens, at least on some
configurations.

This change will try to load by audience (client id) if the token
contains an email, required for OIDC.
3 years ago
Mariano Cano 097a918da7 Fix tests when we create re-use a token with a new authority. 3 years ago
Herman Slatman f11c0cdc0c
Add endpoint for listing ACME EAB keys 3 years ago
Herman Slatman 9d09f5e575
Add support for deleting ACME EAB keys 3 years ago
Herman Slatman a98fe03e80
Merge branch 'master' into hs/acme-eab 3 years ago
Herman Slatman 1dba8698e3
Use LinkedCA.EABKey type in ACME EAB API 3 years ago
Mariano Cano 40e77f6e9a Initialize required variables on GetIdentityToken
Fixes smallstep/cli#465
3 years ago
Mariano Cano 42fde8ba28
Merge branch 'master' into linkedca 3 years ago
Mariano Cano 61b8bfda1a Fix comment typos. 3 years ago
Mariano Cano da2802504b Use Default min version if not specified. 3 years ago
Mariano Cano d4ae267add Fix ErrAllowTokenReuse comment. 3 years ago
Mariano Cano 9e5762fe06 Allow the reuse of azure token if DisableTrustOnFirstUse is true
Azure caches tokens for 24h and we cannot issue a new certificate
for the same instance in that period of time.

The meaning of this parameter is to allow the signing of multiple
certificate in one instance. This is possible in GCP, because we
get a new token, and is possible in AWS because we can generate
a new one. On Azure there was no other way to do it unless you
wait for 24h.

Fixes #656
3 years ago
Mariano Cano 492ff4b632 Ask for the first provisioner password if none is provided. 3 years ago
Mariano Cano 28e882c9b3 Add deployment type to export. 3 years ago
Mariano Cano 072ba4227c Add deployment type to config.
This field is ignored except for the start of the ca. If the type
is linked and the token is not passed, it will fail with an error.
3 years ago
Herman Slatman f31ca4f6a4
Add tests for validateExternalAccountBinding 3 years ago
Herman Slatman 492256f2d7
Add first test cases for EAB and make provisioner unique per EAB
Before this commit, EAB keys could be used CA-wide, meaning that
an EAB credential could be used at any ACME provisioner. This
commit changes that behavior, so that EAB credentials are now
intended to be used with a specific ACME provisioner. I think
that makes sense, because from the perspective of an ACME client
the provisioner is like a distinct CA.

Besides that this commit also includes the first tests for EAB.
The logic for creating the EAB JWS as a client has been taken
from github.com/mholt/acmez. This logic may be moved or otherwise
sourced (i.e. from a vendor) as soon as the step client also
(needs to) support(s) EAB with ACME.
3 years ago
Herman Slatman 71b3f65df1
Add processing of RequireEAB through Linked CA 3 years ago
Mariano Cano 536536c92d Wrap json errors. 3 years ago
Mariano Cano 9d51c2cceb Fix linter errors in the name of export methods. 3 years ago
Mariano Cano 16d3afb92a Remove unused method. 3 years ago
Mariano Cano d72fa953ac Remove debug statements. 3 years ago
Mariano Cano 3f07eb597a Implement revocation using linkedca. 3 years ago
Mariano Cano 798b90c359 Move linkedca configuration to the main package. 3 years ago
Mariano Cano 384be6e205 Do not show provisioners if they are not required.
For deployment types like linked ca, the list of provisioners in
the ca.json are not required, so we should tag the json as omitempty.
3 years ago
Mariano Cano b0e0f2b89d Use linkedca GetAdmin and GetProvisioner. 3 years ago
Mariano Cano 91a369f618 Automatically enable admin properly on linked cas. 3 years ago
Mariano Cano 26122a2cbf Enable admin automatically if a token is provided. 3 years ago
Mariano Cano 2620c38aee Add is converting provisioners to linkedca.
The ids are required to be able to link admins with provisioners.
3 years ago
Mariano Cano e62d7988b8 Do not store password on exports. 3 years ago
Mariano Cano 4f27f4b002 Change default ciphersuites to newer names. 3 years ago
Mariano Cano 07f7316851 Add bastion to export. 3 years ago
Mariano Cano 0730a165fd Add collection of files and authority template. 3 years ago
Mariano Cano c7f8516142 Add to export all the information in the ca.json 3 years ago
Mariano Cano 887423ee6e Update TLS cipher suites. 3 years ago
Mariano Cano dc1ec18b52 Create a way to export ca configurations. 3 years ago
Mariano Cano 3a00b6b396 Properly marshal a certificate when we send it to linkedca. 3 years ago
Mariano Cano 4ad82a2f76 Check linkedca for revocation. 3 years ago
Herman Slatman 7dad7038c3
Fix missing ACME EAB API endpoints 3 years ago
Herman Slatman c6a4c4ecba
Change ACME EAB endpoint 3 years ago
Herman Slatman c6bfc6eac2
Fix PR comments 3 years ago
Herman Slatman b65a588d5b
Make authentication work for /admin/eak 3 years ago
Mariano Cano f7542a5bd9 Move check of ssh revocation from provisioner to the authority. 3 years ago
Mariano Cano 71f8019243 Store x509 and ssh certificates on linkedca if enabled. 3 years ago
Mariano Cano 8fb5340dc9 Use a token at start time to configure linkedca.
Instead of using `step-ca login` we will use a new token provided
as a flag to configure and start linkedca. Certificates will be kept
in memory and refreshed automatically.
3 years ago
Herman Slatman f81d49d963
Add first working version of External Account Binding 3 years ago
Mariano Cano dd9850ce4c Add working implementation of the linkedca.
Replaces the authority adminDB with a new impmentation that users the
linkedca client to retrieve the data.

Note that this implementation still hardcodes the endpoint to localhost.
3 years ago
Mariano Cano 49c1427d15 Use authorityId instead of authorityID.
In json or javascript world authorityId, userId, ... are more common
than authorityID, ...
3 years ago
Herman Slatman 258efca0fa
Improve revocation authorization 3 years ago
Herman Slatman 8f7e700f09
Merge branch 'master' into hs/acme-revocation 3 years ago
max furman 1df21b9b6a Addressing comments in PR review
- added a bit of validation to admin create and update
- using protojson where possible in admin api
- fixing a few instances of admin -> acme in errors
3 years ago
max furman 5679c9933d Fixes from PR review 3 years ago
max furman 77fdfc9fa3 Merge branch 'master' into max/cert-mgr-crud 3 years ago
max furman 9fdef64709 Admin level API for provisioner mgmt v1 3 years ago
Herman Slatman 84e7d468f2
Improve handling of ACME revocation 3 years ago
Herman Slatman 7e82bd6ef3 Add setup for Authority tests 3 years ago
Herman Slatman a64974c179 Fix small typo in divisible 3 years ago
Herman Slatman d46a4eaca4 Change fmt to errors package for formatting errors 3 years ago
Herman Slatman 2beea1aa89 Add configuration option for specifying the minimum public key length
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.

It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
3 years ago
Herman Slatman 4168449935 Fix typo 3 years ago
Herman Slatman fa100a5138 Mask challenge password after it has been read 3 years ago
Herman Slatman 13fe7a0121 Make serving SCEP endpoints optional
Only when a SCEP provisioner is enabled, the SCEP endpoints
will now be available.

The SCEP endpoints will be served on an "insecure" server,
without TLS, only when an additional "insecureAddress" and a
SCEP provisioner are configured for the CA.
3 years ago
Herman Slatman 97b88c4d58 Address (most) PR comments 3 years ago
Herman Slatman be528da709 Make tests green 3 years ago
Herman Slatman 57a62964b1 Make tests not fail hard on ECDSA keys
All tests for the Authority failed because the test data
contains ECDSA keys. ECDSA keys are no crypto.Decrypter,
resulting in a failure when instantiating the Authority.
3 years ago
Herman Slatman 491c2b8d93 Improve initialization of SCEP authority 3 years ago
Herman Slatman 2d85d4c1c1 Add non-TLS server and improve crypto.Decrypter interface
A server without TLS was added to serve the SCEP endpoints. According
to the RFC, SCEP has to be served via HTTP. The `sscep` client, for
example, will stop any URL that does not start with `http://` from
being used, so serving SCEP seems to be the right way to do it.

This commit adds a second server for which no TLS configuration is
configured. A distinct field in the configuration, `insecureAddress`
was added to specify the address for the insecure server.

The SCEP endpoints will also still be served via HTTPS. Some clients
may be able to work with that.

This commit also improves how the crypto.Decrypter interface is
handled for the different types of KMSes supported by step. The
apiv1.Decrypter interface was added. Currently only SoftKMS
implements this interface, providing a crypto.Decrypter required
for SCEP operations.
3 years ago
Herman Slatman e7cb80f880 Fix linter issues 3 years ago
Herman Slatman 4fe7179b95 Add support for configuring capabilities (cacaps) 3 years ago
Herman Slatman 3b86550dbf Add support for challenge password 3 years ago
Herman Slatman da65f46d0f Add AuthorizeSign method to SCEP authority 3 years ago
Herman Slatman 2a249d20de Refactor initialization of SCEP authority 3 years ago
Herman Slatman 339039768c Refactor SCEP authority initialization and clean some code 3 years ago
Herman Slatman 48c86716a0 Add rudimentary (and incomplete) support for SCEP 3 years ago
max furman 94ba057f01 wip 3 years ago
max furman 01a4460812 wip 3 years ago
max furman 1726076ea2 wip 3 years ago
max furman 423942da44 wip 3 years ago
max furman 9bfb1c2e7b wip 3 years ago
max furman d8d5d7332b wip 3 years ago
max furman 5929244fda wip 3 years ago
max furman 9bf9bf142d wip 3 years ago
Herman Slatman 375687cd1b
Add setup for Authority tests 3 years ago
max furman 638766c615 wip 3 years ago
max furman 4f3e5ef64d wip 3 years ago
max furman 5d09d04d14 wip 3 years ago
max furman 4d48072746 wip admin CRUD 3 years ago
max furman 98a6e54530 wip 3 years ago
max furman af3cf7dae9 first steps 3 years ago
max furman 2f60f20b0b lots of codes 3 years ago
max furman 7b5d6968a5 first commit 3 years ago
Herman Slatman a3ec890e71
Fix small typo in divisible 3 years ago
Herman Slatman d0a9cbc797
Change fmt to errors package for formatting errors 3 years ago
Herman Slatman ff1b46c95d
Add configuration option for specifying the minimum public key length
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.

It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
3 years ago
Herman Slatman c04f556dc2
Merge branch 'master' into hs/scep 3 years ago
Cristian Le d7eec869c2 Fix the previous tests 3 years ago
Cristian Le c2d30f7260 gofmt everything 3 years ago
Cristian Le f38a72a62b Leftover from previous commit 3 years ago
Cristian Le 1d2445e1d8 Removed the variadic username
Could be useful later on, but for the current PR changes should be minimized
3 years ago
Cristian Le 9e00b82bdf Revert `oidc_test.go`
Moving the `preferred_username` to a separate PR
3 years ago
Cristian Le decf0fc8ce Revert using preferred_username
It might present a security issue if the users can change this value for themselves. Needs further investigation
3 years ago
Cristian Le 21732f213b Fix shadow issue in CI 3 years ago
Mariano Cano 08e5ec6ad1 Fix IsAdminGroup comment. 3 years ago
Mariano Cano 46c1dc80fb Use map[string]struct{} instead of map[string]bool 3 years ago
Mariano Cano aafac179a5 Add test for oidc with preferred usernames. 3 years ago
Cristian Le f730c0bec4 Sanitize usernames 3 years ago
Cristian Le 48666792c7 Draft: adding usernames to GetIdentityFunc 3 years ago
Cristian Le 79eec83f3e Rename and reformat to PreferredUsername 3 years ago
Cristian Le 09a21fef26 Implement #550
- Read `preferred_username` from token
- Add `preferred_username` to the default Usernames
- Check the `admin` array for admin groups that the user might belong to
3 years ago
max furman 8c709fe3c2 Init config on load | Add wrapper for cli 3 years ago
Mariano Cano 2cbaee9c1d Allow to use an alternative interface to store renewed certs.
This can be useful to know if a certificate has been renewed and
link one certificate with the 'parent'.
3 years ago
Herman Slatman 68d5f6d0d2
Merge branch 'master' into hs/scep 3 years ago
Mariano Cano e6833ecee3 Add extension of db.AuthDB to store the fullchain.
Add a temporary solution to allow an extension of an db.AuthDB
interface that logs the fullchain of certificates instead of just
the leaf.
3 years ago
Herman Slatman 2336936b5c
Fix typo 3 years ago
Herman Slatman 9787728fbd
Mask challenge password after it has been read 3 years ago
Herman Slatman 0487686f69
Merge branch 'master' into hs/scep 3 years ago
Max b724af30ad
Merge pull request #496 from smallstep/max/acme
Convert to ACME DB interface
3 years ago
Mariano Cano aea2a7c9f3 Update sshd_config.tpl to a Match all block.
Fixes #479
3 years ago
Herman Slatman b815478981
Make serving SCEP endpoints optional
Only when a SCEP provisioner is enabled, the SCEP endpoints
will now be available.

The SCEP endpoints will be served on an "insecure" server,
without TLS, only when an additional "insecureAddress" and a
SCEP provisioner are configured for the CA.
3 years ago
Herman Slatman c5e4ea08b3
Merge branch 'master' into hs/scep 3 years ago
max furman 2ae43ef2dc [acme db interface] wip errors 3 years ago
Mariano Cano 0b8528ce6b Allow mTLS revocation without provisioner. 3 years ago