Commit Graph

161 Commits (user-regex)

Author SHA1 Message Date
Max 7731edd816
Store and verify Acme account location (#1386)
* Store and verify account location on acme requests

Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
Co-authored-by: Mariano Cano <mariano@smallstep.com>
1 year ago
max furman 8b256f0351
address linter warning for go 1.19 1 year ago
Herman Slatman 0f1c509e4b
Remove debug utility 1 year ago
Herman Slatman 60a9e41c1c
Remove `Identifier` from top level ACME `Errors` 1 year ago
Herman Slatman edee01c80c
Refactor debug utility 1 year ago
Herman Slatman 1c38113e44
Add ACME `Subproblem` for more detailed ACME client-side errors
When validating an ACME challenge (`device-attest-01` in this case,
but it's also true for others), and validation fails, the CA didn't
return a lot of information about why the challenge had failed. By
introducing the ACME `Subproblem` type, an ACME `Error` can include
some additional information about what went wrong when validating
the challenge.

This is a WIP commit. The `Subproblem` isn't created in many code
paths yet, just for the `step` format at the moment. Will probably
follow up with some more improvements to how the ACME error is
handled. Also need to cleanup some debug things (q.Q)
1 year ago
Herman Slatman 817edcbba5
Remove `charset=utf-8` from ACME certificate requests 2 years ago
Herman Slatman 3eae04928f
Add tests for ACME Meta object 2 years ago
Herman Slatman b9f238ad4d
Add additional ACME `meta` properties to provisioner configuration 2 years ago
Herman Slatman c9793561ff
Make `meta` object optional in ACME directory response
Harware appliances from Kemp seem to validate the contents of the
`meta` object, even if none of the properties in the `meta` object
is set. According to the RFC, the `meta` object, as well as its
properties are optional, so technically this should be fixed by
the manufacturer.

This commit is to see if we validation of the `meta` object is
skipped if it's not available in the response.
2 years ago
Mariano Cano 99299faeeb
Add AuthorizeChallenge unit tests 2 years ago
Mariano Cano 2b3b2c283a
Add attestation certificate validation for Apple devices 2 years ago
Brandon Weeks 5f5315260a
iOS 16 beta 1 support 2 years ago
max furman ab0d2503ae
Standardize linting file and fix or ignore lots of linting errors 2 years ago
Mariano Cano 829530ae90 Fix linter errors 2 years ago
Mariano Cano 0f651799d0 Reject not enabled attestation formats 2 years ago
Mariano Cano fd4e96d1f4 Rename method to IsChallengeEnabled 2 years ago
Mariano Cano c77b4ff9c5 Fix linter errors 2 years ago
Mariano Cano 59c5219a07 Use a type for acme challenges 2 years ago
Mariano Cano a89bea701d Format comment 2 years ago
Mariano Cano 5df9434286 Fix old comment, device-attest-01 uses the acme payload 2 years ago
Mariano Cano 3cd72ac72a Remove debug statements 2 years ago
Mariano Cano df96b126dc Add AuthorizeChallenge unit tests 2 years ago
Mariano Cano bca311b05e Add acme property to enable challenges
Fixes #1027
2 years ago
Mariano Cano ae8d4d8757 Fix unit test 2 years ago
Mariano Cano 693dc39481 Merge branch 'master' into device-attestation 2 years ago
max furman c040e4b459 Add unit tests 2 years ago
max furman b7c2f6c482 Check for DNS name validity 2 years ago
Mariano Cano 66356cff43 Add attestation certificate validation for Apple devices 2 years ago
Brandon Weeks 7e1b0bebd9 iOS 16 beta 1 support 2 years ago
Brandon Weeks 2ac8b69da2 Add ACME permanent-identifier identifier type 2 years ago
Brandon Weeks aacd6f4cc6 Add device-attest-01 challenge type 2 years ago
Shulhan fe04f93d7f
all: reformat all go files with the next gofmt (Go 1.19)
There are some changes that manually edited, for example using '-' as
default list and grouping imports.
2 years ago
Herman Slatman abfbbc8d49
Merge pull request #946 from smallstep/herman/acme-csr-padding
Strip base64-url padding from ACME CSR
2 years ago
Herman Slatman fd546287ac
Strip base64-url padding from ACME CSR
This commit strips the padding from a base64-url encoded CSR
submitted by a client that doesn't use raw base64-url encoding.
2 years ago
Mariano Cano e7f4eaf6c4 Remove explicit deprecation notice
This will avoid linter errors on other projects for now.
2 years ago
Mariano Cano d461918eb0 Merge branch 'master' into context-authority 2 years ago
Mariano Cano 2ea0c70344 Move acme context middleware to deprecated handler 2 years ago
Mariano Cano 9147356d8a Fix linter errors 2 years ago
Mariano Cano ba499eeb2a Fix acme/api tests. 2 years ago
Mariano Cano 6f9d847bc6 Fix panic in acme/api tests. 2 years ago
Mariano Cano d1f75f1720 Refactor ACME api. 2 years ago
Mariano Cano fddd6f7d95 Move linker to the acme package. 2 years ago
Mariano Cano 55b0f72821 Add context methods for the acme linker. 2 years ago
Mariano Cano bb8d85a201 Fix unit tests - work in progress 2 years ago
Mariano Cano 42435ace64 Use scep authority from context
This commit also converts all the methods from the handler to
functions.
2 years ago
Mariano Cano d13537d426 Use context in the acme handlers. 2 years ago
Herman Slatman 6e1f8dd7ab
Refactor policy engines into container 2 years ago
Herman Slatman 2a7620641f
Fix more PR comments 2 years ago
Herman Slatman fb81407d6f
Fix ACME policy comments 2 years ago