From 893a53793af1883e8fa2132fc64a0955ed845d69 Mon Sep 17 00:00:00 2001 From: Oleksandr Kovalchuk Date: Sun, 17 May 2020 20:27:09 +0300 Subject: [PATCH] Modify existing tests to accept forceCNOption modifier Modify existing tests to pass with changes introduced in commit 322200b7dbce1f8779d0bc6bb2221128275e8ca3. This is safe to do as tests assert exact length of modifiers, which has changed. --- acme/order_test.go | 6 +++--- authority/provisioner/acme_test.go | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/acme/order_test.go b/acme/order_test.go index b0453754..fa08e3b7 100644 --- a/acme/order_test.go +++ b/acme/order_test.go @@ -1137,7 +1137,7 @@ func TestOrderFinalize(t *testing.T) { csr: csr, sa: &mockSignAuth{ sign: func(csr *x509.CertificateRequest, pops provisioner.Options, signOps ...provisioner.SignOption) ([]*x509.Certificate, error) { - assert.Equals(t, len(signOps), 4) + assert.Equals(t, len(signOps), 5) return []*x509.Certificate{crt, inter}, nil }, }, @@ -1186,7 +1186,7 @@ func TestOrderFinalize(t *testing.T) { csr: csr, sa: &mockSignAuth{ sign: func(csr *x509.CertificateRequest, pops provisioner.Options, signOps ...provisioner.SignOption) ([]*x509.Certificate, error) { - assert.Equals(t, len(signOps), 4) + assert.Equals(t, len(signOps), 5) return []*x509.Certificate{crt, inter}, nil }, }, @@ -1233,7 +1233,7 @@ func TestOrderFinalize(t *testing.T) { csr: csr, sa: &mockSignAuth{ sign: func(csr *x509.CertificateRequest, pops provisioner.Options, signOps ...provisioner.SignOption) ([]*x509.Certificate, error) { - assert.Equals(t, len(signOps), 4) + assert.Equals(t, len(signOps), 5) return []*x509.Certificate{crt, inter}, nil }, }, diff --git a/authority/provisioner/acme_test.go b/authority/provisioner/acme_test.go index 581f20ed..7b669d8d 100644 --- a/authority/provisioner/acme_test.go +++ b/authority/provisioner/acme_test.go @@ -168,7 +168,7 @@ func TestACME_AuthorizeSign(t *testing.T) { } } else { if assert.Nil(t, tc.err) && assert.NotNil(t, opts) { - assert.Len(t, 4, opts) + assert.Len(t, 5, opts) for _, o := range opts { switch v := o.(type) { case *provisionerExtensionOption: @@ -176,6 +176,8 @@ func TestACME_AuthorizeSign(t *testing.T) { assert.Equals(t, v.Name, tc.p.GetName()) assert.Equals(t, v.CredentialID, "") assert.Len(t, 0, v.KeyValuePairs) + case *forceCNOption: + assert.Equals(t, v.ForceCN, tc.p.ForceCN) case profileDefaultDuration: assert.Equals(t, time.Duration(v), tc.p.claimer.DefaultTLSCertDuration()) case defaultPublicKeyValidator: