From 73ba411e1d1b88460eb214ccdffa285bea14bcef Mon Sep 17 00:00:00 2001 From: max furman Date: Wed, 10 Aug 2022 21:45:10 -0700 Subject: [PATCH] [action] parameterize golangci-lint version --- .github/workflows/release.yml | 20 +------------------- .github/workflows/test.yml | 20 +------------------- 2 files changed, 2 insertions(+), 38 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 97b2905f..b4336472 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -32,26 +32,8 @@ jobs: name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version - version: 'v1.45.2' - - # Optional: working directory, useful for monorepos - # working-directory: somedir - - # Optional: golangci-lint command line arguments. + version: ${{ secrets.GOLANGCI_LINT_VERSION }} args: --timeout=30m - - # Optional: show only new issues if it's a pull request. The default value is `false`. - # only-new-issues: true - - # Optional: if set to true then the action will use pre-installed Go. - # skip-go-installation: true - - # Optional: if set to true then the action don't cache or restore ~/go/pkg. - # skip-pkg-cache: true - - # Optional: if set to true then the action don't cache or restore ~/.cache/go-build. - # skip-build-cache: true - name: Test, Build id: lint_test_build diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2f3a5c5a..8a2f391c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -32,26 +32,8 @@ jobs: name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version - version: 'v1.48' - - # Optional: working directory, useful for monorepos - # working-directory: somedir - - # Optional: golangci-lint command line arguments. + version: ${{ secrets.GOLANGCI_LINT_VERSION }} args: --timeout=30m - - # Optional: show only new issues if it's a pull request. The default value is `false`. - # only-new-issues: true - - # Optional: if set to true then the action will use pre-installed Go. - # skip-go-installation: true - - # Optional: if set to true then the action don't cache or restore ~/go/pkg. - # skip-pkg-cache: true - - # Optional: if set to true then the action don't cache or restore ~/.cache/go-build. - # skip-build-cache: true - name: Test, Build id: lint_test_build