From 5f130895f3937ea040935230dd8b31093393595c Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Mon, 3 Oct 2022 11:35:51 -0700 Subject: [PATCH] Set timestamp when marking an acme challenge invalid --- acme/challenge.go | 1 + acme/challenge_test.go | 1 + 2 files changed, 2 insertions(+) diff --git a/acme/challenge.go b/acme/challenge.go index 84b3f83a..264cf73a 100644 --- a/acme/challenge.go +++ b/acme/challenge.go @@ -729,6 +729,7 @@ func storeError(ctx context.Context, db DB, ch *Challenge, markInvalid bool, err ch.Error = err if markInvalid { ch.Status = StatusInvalid + ch.ValidatedAt = clock.Now().Format(time.RFC3339) } if err := db.UpdateChallenge(ctx, ch); err != nil { return WrapErrorISE(err, "failure saving error to acme challenge") diff --git a/acme/challenge_test.go b/acme/challenge_test.go index e452b175..cc5642c3 100644 --- a/acme/challenge_test.go +++ b/acme/challenge_test.go @@ -170,6 +170,7 @@ func Test_storeError(t *testing.T) { assert.Equals(t, updch.Token, ch.Token) assert.Equals(t, updch.Value, ch.Value) assert.Equals(t, updch.Status, StatusInvalid) + assert.True(t, updch.ValidatedAt != "") assert.HasPrefix(t, updch.Error.Err.Error(), err.Err.Error()) assert.Equals(t, updch.Error.Type, err.Type)