From 5d0bd7d1557985fa76443aff78ce848437d09a78 Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Tue, 12 Oct 2021 15:14:01 -0700 Subject: [PATCH] Fix grammar in comments. --- kms/azurekms/key_vault.go | 8 ++++---- kms/azurekms/signer.go | 2 +- pki/pki.go | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/kms/azurekms/key_vault.go b/kms/azurekms/key_vault.go index 1fb8572c..b9a17b1c 100644 --- a/kms/azurekms/key_vault.go +++ b/kms/azurekms/key_vault.go @@ -19,7 +19,7 @@ func init() { }) } -// Scheme is the scheme used for Azure Key Vault uris. +// Scheme is the scheme used for the Azure Key Vault uris. const Scheme = "azurekms" // keyIDRegexp is the regular expression that Key Vault uses for on the kid. We @@ -96,11 +96,11 @@ var signatureAlgorithmMapping = map[apiv1.SignatureAlgorithm]keyType{ }, } -// vaultResource is that the client will use as audience. +// vaultResource is the value the client will use as audience. const vaultResource = "https://vault.azure.net" -// KeyVaultClient is the interface implemented by keyvault.BaseClient. It it -// will be used for testing purposes. +// KeyVaultClient is the interface implemented by keyvault.BaseClient. It will +// be used for testing purposes. type KeyVaultClient interface { GetKey(ctx context.Context, vaultBaseURL string, keyName string, keyVersion string) (keyvault.KeyBundle, error) CreateKey(ctx context.Context, vaultBaseURL string, keyName string, parameters keyvault.KeyCreateParameters) (keyvault.KeyBundle, error) diff --git a/kms/azurekms/signer.go b/kms/azurekms/signer.go index cf0197fb..405c625a 100644 --- a/kms/azurekms/signer.go +++ b/kms/azurekms/signer.go @@ -99,7 +99,7 @@ func (s *Signer) Sign(rand io.Reader, digest []byte, opts crypto.SignerOpts) ([] return sig, nil } - // Convert to ans1 + // Convert to asn1 if len(sig) != octetSize*2 { return nil, errors.Errorf("keyVault Sign failed: unexpected signature length") } diff --git a/pki/pki.go b/pki/pki.go index b4ac26da..8a61d025 100644 --- a/pki/pki.go +++ b/pki/pki.go @@ -263,7 +263,7 @@ func WithDeploymentType(dt DeploymentType) Option { } } -// WithKMS enabled the kms with the given name. +// WithKMS enables the kms with the given name. func WithKMS(name string) Option { return func(p *PKI) { typ := linkedca.KMS_Type_value[strings.ToUpper(name)]