mirror of
https://github.com/smallstep/certificates.git
synced 2024-11-11 07:11:00 +00:00
758 lines
24 KiB
Go
758 lines
24 KiB
Go
|
package api
|
||
|
|
|
||
|
|
import (
|
||
|
|
"bytes"
|
||
|
|
"context"
|
||
|
|
"crypto/x509"
|
||
|
|
"encoding/base64"
|
||
|
|
"encoding/json"
|
||
|
|
"fmt"
|
||
|
|
"io/ioutil"
|
||
|
|
"net/http/httptest"
|
||
|
|
"testing"
|
||
|
|
"time"
|
||
|
|
|
||
|
|
"github.com/go-chi/chi"
|
||
|
|
"github.com/pkg/errors"
|
||
|
|
"github.com/smallstep/assert"
|
||
|
|
"github.com/smallstep/certificates/acme"
|
||
|
|
"github.com/smallstep/certificates/authority/provisioner"
|
||
|
|
"github.com/smallstep/cli/crypto/pemutil"
|
||
|
|
)
|
||
|
|
|
||
|
|
func TestNewOrderRequestValidate(t *testing.T) {
|
||
|
|
type test struct {
|
||
|
|
nor *NewOrderRequest
|
||
|
|
nbf, naf time.Time
|
||
|
|
err *acme.Error
|
||
|
|
}
|
||
|
|
var tests = map[string]func(t *testing.T) test{
|
||
|
|
"fail/no-identifiers": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
nor: &NewOrderRequest{},
|
||
|
|
err: acme.MalformedErr(errors.Errorf("identifiers list cannot be empty")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/bad-identifier": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
nor: &NewOrderRequest{
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "foo", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
},
|
||
|
|
err: acme.MalformedErr(errors.Errorf("identifier type unsupported: foo")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"ok": func(t *testing.T) test {
|
||
|
|
nbf := time.Now().UTC().Add(time.Minute)
|
||
|
|
naf := time.Now().UTC().Add(5 * time.Minute)
|
||
|
|
return test{
|
||
|
|
nor: &NewOrderRequest{
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "dns", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
NotAfter: naf,
|
||
|
|
NotBefore: nbf,
|
||
|
|
},
|
||
|
|
nbf: nbf,
|
||
|
|
naf: naf,
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|
||
|
|
for name, run := range tests {
|
||
|
|
tc := run(t)
|
||
|
|
t.Run(name, func(t *testing.T) {
|
||
|
|
if err := tc.nor.Validate(); err != nil {
|
||
|
|
if assert.NotNil(t, err) {
|
||
|
|
ae, ok := err.(*acme.Error)
|
||
|
|
assert.True(t, ok)
|
||
|
|
assert.HasPrefix(t, ae.Error(), tc.err.Error())
|
||
|
|
assert.Equals(t, ae.StatusCode(), tc.err.StatusCode())
|
||
|
|
assert.Equals(t, ae.Type, tc.err.Type)
|
||
|
|
}
|
||
|
|
} else {
|
||
|
|
if assert.Nil(t, tc.err) {
|
||
|
|
if tc.nbf.IsZero() {
|
||
|
|
assert.True(t, tc.nor.NotBefore.Before(time.Now().Add(time.Minute)))
|
||
|
|
assert.True(t, tc.nor.NotBefore.After(time.Now().Add(-time.Minute)))
|
||
|
|
} else {
|
||
|
|
assert.Equals(t, tc.nor.NotBefore, tc.nbf)
|
||
|
|
}
|
||
|
|
if tc.naf.IsZero() {
|
||
|
|
assert.True(t, tc.nor.NotAfter.Before(time.Now().Add(24*time.Hour)))
|
||
|
|
assert.True(t, tc.nor.NotAfter.After(time.Now().Add(24*time.Hour-time.Minute)))
|
||
|
|
} else {
|
||
|
|
assert.Equals(t, tc.nor.NotAfter, tc.naf)
|
||
|
|
}
|
||
|
|
}
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
func TestFinalizeRequestValidate(t *testing.T) {
|
||
|
|
_csr, err := pemutil.Read("../../authority/testdata/certs/foo.csr")
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
csr, ok := _csr.(*x509.CertificateRequest)
|
||
|
|
assert.Fatal(t, ok)
|
||
|
|
type test struct {
|
||
|
|
fr *FinalizeRequest
|
||
|
|
err *acme.Error
|
||
|
|
}
|
||
|
|
var tests = map[string]func(t *testing.T) test{
|
||
|
|
"fail/parse-csr-error": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
fr: &FinalizeRequest{},
|
||
|
|
err: acme.MalformedErr(errors.Errorf("unable to parse csr: asn1: syntax error: sequence truncated")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/invalid-csr-signature": func(t *testing.T) test {
|
||
|
|
b, err := pemutil.Read("../../authority/testdata/certs/badsig.csr")
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
c, ok := b.(*x509.CertificateRequest)
|
||
|
|
assert.Fatal(t, ok)
|
||
|
|
return test{
|
||
|
|
fr: &FinalizeRequest{
|
||
|
|
CSR: base64.RawURLEncoding.EncodeToString(c.Raw),
|
||
|
|
},
|
||
|
|
err: acme.MalformedErr(errors.Errorf("csr failed signature check: x509: ECDSA verification failure")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"ok": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
fr: &FinalizeRequest{
|
||
|
|
CSR: base64.RawURLEncoding.EncodeToString(csr.Raw),
|
||
|
|
},
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|
||
|
|
for name, run := range tests {
|
||
|
|
tc := run(t)
|
||
|
|
t.Run(name, func(t *testing.T) {
|
||
|
|
if err := tc.fr.Validate(); err != nil {
|
||
|
|
if assert.NotNil(t, err) {
|
||
|
|
ae, ok := err.(*acme.Error)
|
||
|
|
assert.True(t, ok)
|
||
|
|
assert.HasPrefix(t, ae.Error(), tc.err.Error())
|
||
|
|
assert.Equals(t, ae.StatusCode(), tc.err.StatusCode())
|
||
|
|
assert.Equals(t, ae.Type, tc.err.Type)
|
||
|
|
}
|
||
|
|
} else {
|
||
|
|
if assert.Nil(t, tc.err) {
|
||
|
|
assert.Equals(t, tc.fr.csr.Raw, csr.Raw)
|
||
|
|
}
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
func TestHandlerGetOrder(t *testing.T) {
|
||
|
|
expiry := time.Now().UTC().Add(6 * time.Hour)
|
||
|
|
nbf := time.Now().UTC()
|
||
|
|
naf := time.Now().UTC().Add(24 * time.Hour)
|
||
|
|
o := acme.Order{
|
||
|
|
ID: "orderID",
|
||
|
|
Expires: expiry.Format(time.RFC3339),
|
||
|
|
NotBefore: nbf.Format(time.RFC3339),
|
||
|
|
NotAfter: naf.Format(time.RFC3339),
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{
|
||
|
|
Type: "dns",
|
||
|
|
Value: "example.com",
|
||
|
|
},
|
||
|
|
{
|
||
|
|
Type: "dns",
|
||
|
|
Value: "*.smallstep.com",
|
||
|
|
},
|
||
|
|
},
|
||
|
|
Status: "pending",
|
||
|
|
Authorizations: []string{"foo", "bar"},
|
||
|
|
}
|
||
|
|
|
||
|
|
// Request with chi context
|
||
|
|
chiCtx := chi.NewRouteContext()
|
||
|
|
chiCtx.URLParams.Add("ordID", o.ID)
|
||
|
|
prov := newProv()
|
||
|
|
url := fmt.Sprintf("http://ca.smallstep.com/acme/%s/order/%s",
|
||
|
|
acme.URLSafeProvisionerName(prov), o.ID)
|
||
|
|
|
||
|
|
type test struct {
|
||
|
|
auth acme.Interface
|
||
|
|
ctx context.Context
|
||
|
|
statusCode int
|
||
|
|
problem *acme.Error
|
||
|
|
}
|
||
|
|
var tests = map[string]func(t *testing.T) test{
|
||
|
|
"fail/no-provisioner": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.Background(),
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("provisioner expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-provisioner": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.WithValue(context.Background(), provisionerContextKey, nil),
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("provisioner expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/no-account": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.WithValue(context.Background(), provisionerContextKey, prov),
|
||
|
|
statusCode: 404,
|
||
|
|
problem: acme.AccountDoesNotExistErr(nil),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-account": func(t *testing.T) test {
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, nil)
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 404,
|
||
|
|
problem: acme.AccountDoesNotExistErr(nil),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/getOrder-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, chi.RouteCtxKey, chiCtx)
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
err: acme.ServerInternalErr(errors.New("force")),
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("force")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"ok": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, chi.RouteCtxKey, chiCtx)
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
getOrder: func(p provisioner.Interface, accID, id string) (*acme.Order, error) {
|
||
|
|
assert.Equals(t, p, prov)
|
||
|
|
assert.Equals(t, accID, acc.ID)
|
||
|
|
assert.Equals(t, id, o.ID)
|
||
|
|
return &o, nil
|
||
|
|
},
|
||
|
|
getLink: func(typ acme.Link, provID string, abs bool, in ...string) string {
|
||
|
|
assert.Equals(t, typ, acme.OrderLink)
|
||
|
|
assert.Equals(t, provID, acme.URLSafeProvisionerName(prov))
|
||
|
|
assert.True(t, abs)
|
||
|
|
assert.Equals(t, in, []string{o.ID})
|
||
|
|
return url
|
||
|
|
},
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 200,
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|
||
|
|
for name, run := range tests {
|
||
|
|
tc := run(t)
|
||
|
|
t.Run(name, func(t *testing.T) {
|
||
|
|
h := New(tc.auth).(*Handler)
|
||
|
|
req := httptest.NewRequest("GET", url, nil)
|
||
|
|
req = req.WithContext(tc.ctx)
|
||
|
|
w := httptest.NewRecorder()
|
||
|
|
h.GetOrder(w, req)
|
||
|
|
res := w.Result()
|
||
|
|
|
||
|
|
assert.Equals(t, res.StatusCode, tc.statusCode)
|
||
|
|
|
||
|
|
body, err := ioutil.ReadAll(res.Body)
|
||
|
|
res.Body.Close()
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
|
||
|
|
if res.StatusCode >= 400 && assert.NotNil(t, tc.problem) {
|
||
|
|
var ae acme.AError
|
||
|
|
assert.FatalError(t, json.Unmarshal(bytes.TrimSpace(body), &ae))
|
||
|
|
prob := tc.problem.ToACME()
|
||
|
|
|
||
|
|
assert.Equals(t, ae.Type, prob.Type)
|
||
|
|
assert.Equals(t, ae.Detail, prob.Detail)
|
||
|
|
assert.Equals(t, ae.Identifier, prob.Identifier)
|
||
|
|
assert.Equals(t, ae.Subproblems, prob.Subproblems)
|
||
|
|
assert.Equals(t, res.Header["Content-Type"], []string{"application/problem+json"})
|
||
|
|
} else {
|
||
|
|
expB, err := json.Marshal(o)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
assert.Equals(t, bytes.TrimSpace(body), expB)
|
||
|
|
assert.Equals(t, res.Header["Location"], []string{url})
|
||
|
|
assert.Equals(t, res.Header["Content-Type"], []string{"application/json"})
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
func TestHandlerNewOrder(t *testing.T) {
|
||
|
|
expiry := time.Now().UTC().Add(6 * time.Hour)
|
||
|
|
nbf := time.Now().UTC().Add(5 * time.Hour)
|
||
|
|
naf := nbf.Add(17 * time.Hour)
|
||
|
|
o := acme.Order{
|
||
|
|
ID: "orderID",
|
||
|
|
Expires: expiry.Format(time.RFC3339),
|
||
|
|
NotBefore: nbf.Format(time.RFC3339),
|
||
|
|
NotAfter: naf.Format(time.RFC3339),
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "dns", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
Status: "pending",
|
||
|
|
Authorizations: []string{"foo", "bar"},
|
||
|
|
}
|
||
|
|
|
||
|
|
prov := newProv()
|
||
|
|
url := fmt.Sprintf("https://ca.smallstep.com/acme/%s/new-order",
|
||
|
|
acme.URLSafeProvisionerName(prov))
|
||
|
|
|
||
|
|
type test struct {
|
||
|
|
auth acme.Interface
|
||
|
|
ctx context.Context
|
||
|
|
statusCode int
|
||
|
|
problem *acme.Error
|
||
|
|
}
|
||
|
|
var tests = map[string]func(t *testing.T) test{
|
||
|
|
"fail/no-provisioner": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.Background(),
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("provisioner expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-provisioner": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.WithValue(context.Background(), provisionerContextKey, nil),
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("provisioner expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/no-account": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
ctx: context.WithValue(context.Background(), provisionerContextKey, prov),
|
||
|
|
statusCode: 404,
|
||
|
|
problem: acme.AccountDoesNotExistErr(nil),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-account": func(t *testing.T) test {
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, nil)
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 404,
|
||
|
|
problem: acme.AccountDoesNotExistErr(nil),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/no-payload": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("payload expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-payload": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, nil)
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("payload expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/unmarshal-payload-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{})
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 400,
|
||
|
|
problem: acme.MalformedErr(errors.New("failed to unmarshal new-order request payload: unexpected end of JSON input")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/malformed-payload-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
nor := &NewOrderRequest{}
|
||
|
|
b, err := json.Marshal(nor)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 400,
|
||
|
|
problem: acme.MalformedErr(errors.New("identifiers list cannot be empty")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/NewOrder-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
nor := &NewOrderRequest{
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "dns", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
}
|
||
|
|
b, err := json.Marshal(nor)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
newOrder: func(p provisioner.Interface, ops acme.OrderOptions) (*acme.Order, error) {
|
||
|
|
assert.Equals(t, p, prov)
|
||
|
|
assert.Equals(t, ops.AccountID, acc.ID)
|
||
|
|
assert.Equals(t, ops.Identifiers, nor.Identifiers)
|
||
|
|
return nil, acme.MalformedErr(errors.New("force"))
|
||
|
|
},
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 400,
|
||
|
|
problem: acme.MalformedErr(errors.New("force")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"ok": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
nor := &NewOrderRequest{
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "dns", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
NotBefore: nbf,
|
||
|
|
NotAfter: naf,
|
||
|
|
}
|
||
|
|
b, err := json.Marshal(nor)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
newOrder: func(p provisioner.Interface, ops acme.OrderOptions) (*acme.Order, error) {
|
||
|
|
assert.Equals(t, p, prov)
|
||
|
|
assert.Equals(t, ops.AccountID, acc.ID)
|
||
|
|
assert.Equals(t, ops.Identifiers, nor.Identifiers)
|
||
|
|
assert.Equals(t, ops.NotBefore, nbf)
|
||
|
|
assert.Equals(t, ops.NotAfter, naf)
|
||
|
|
return &o, nil
|
||
|
|
},
|
||
|
|
getLink: func(typ acme.Link, provID string, abs bool, in ...string) string {
|
||
|
|
assert.Equals(t, typ, acme.OrderLink)
|
||
|
|
assert.Equals(t, provID, acme.URLSafeProvisionerName(prov))
|
||
|
|
assert.True(t, abs)
|
||
|
|
assert.Equals(t, in, []string{o.ID})
|
||
|
|
return fmt.Sprintf("https://ca.smallstep.com/acme/order/%s", o.ID)
|
||
|
|
},
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 201,
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"ok/default-naf-nbf": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
nor := &NewOrderRequest{
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "dns", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
}
|
||
|
|
b, err := json.Marshal(nor)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
newOrder: func(p provisioner.Interface, ops acme.OrderOptions) (*acme.Order, error) {
|
||
|
|
assert.Equals(t, p, prov)
|
||
|
|
assert.Equals(t, ops.AccountID, acc.ID)
|
||
|
|
assert.Equals(t, ops.Identifiers, nor.Identifiers)
|
||
|
|
|
||
|
|
assert.True(t, ops.NotBefore.IsZero())
|
||
|
|
assert.True(t, ops.NotAfter.IsZero())
|
||
|
|
return &o, nil
|
||
|
|
},
|
||
|
|
getLink: func(typ acme.Link, provID string, abs bool, in ...string) string {
|
||
|
|
assert.Equals(t, typ, acme.OrderLink)
|
||
|
|
assert.Equals(t, provID, acme.URLSafeProvisionerName(prov))
|
||
|
|
assert.True(t, abs)
|
||
|
|
assert.Equals(t, in, []string{o.ID})
|
||
|
|
return fmt.Sprintf("https://ca.smallstep.com/acme/order/%s", o.ID)
|
||
|
|
},
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 201,
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|
||
|
|
for name, run := range tests {
|
||
|
|
tc := run(t)
|
||
|
|
t.Run(name, func(t *testing.T) {
|
||
|
|
h := New(tc.auth).(*Handler)
|
||
|
|
req := httptest.NewRequest("GET", url, nil)
|
||
|
|
req = req.WithContext(tc.ctx)
|
||
|
|
w := httptest.NewRecorder()
|
||
|
|
h.NewOrder(w, req)
|
||
|
|
res := w.Result()
|
||
|
|
|
||
|
|
assert.Equals(t, res.StatusCode, tc.statusCode)
|
||
|
|
|
||
|
|
body, err := ioutil.ReadAll(res.Body)
|
||
|
|
res.Body.Close()
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
|
||
|
|
if res.StatusCode >= 400 && assert.NotNil(t, tc.problem) {
|
||
|
|
var ae acme.AError
|
||
|
|
assert.FatalError(t, json.Unmarshal(bytes.TrimSpace(body), &ae))
|
||
|
|
prob := tc.problem.ToACME()
|
||
|
|
|
||
|
|
assert.Equals(t, ae.Type, prob.Type)
|
||
|
|
assert.Equals(t, ae.Detail, prob.Detail)
|
||
|
|
assert.Equals(t, ae.Identifier, prob.Identifier)
|
||
|
|
assert.Equals(t, ae.Subproblems, prob.Subproblems)
|
||
|
|
assert.Equals(t, res.Header["Content-Type"], []string{"application/problem+json"})
|
||
|
|
} else {
|
||
|
|
expB, err := json.Marshal(o)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
assert.Equals(t, bytes.TrimSpace(body), expB)
|
||
|
|
assert.Equals(t, res.Header["Location"],
|
||
|
|
[]string{fmt.Sprintf("https://ca.smallstep.com/acme/order/%s", o.ID)})
|
||
|
|
assert.Equals(t, res.Header["Content-Type"], []string{"application/json"})
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
func TestHandlerFinalizeOrder(t *testing.T) {
|
||
|
|
expiry := time.Now().UTC().Add(6 * time.Hour)
|
||
|
|
nbf := time.Now().UTC().Add(5 * time.Hour)
|
||
|
|
naf := nbf.Add(17 * time.Hour)
|
||
|
|
o := acme.Order{
|
||
|
|
ID: "orderID",
|
||
|
|
Expires: expiry.Format(time.RFC3339),
|
||
|
|
NotBefore: nbf.Format(time.RFC3339),
|
||
|
|
NotAfter: naf.Format(time.RFC3339),
|
||
|
|
Identifiers: []acme.Identifier{
|
||
|
|
{Type: "dns", Value: "example.com"},
|
||
|
|
{Type: "dns", Value: "bar.com"},
|
||
|
|
},
|
||
|
|
Status: "valid",
|
||
|
|
Authorizations: []string{"foo", "bar"},
|
||
|
|
Certificate: "https://ca.smallstep.com/acme/certificate/certID",
|
||
|
|
}
|
||
|
|
_csr, err := pemutil.Read("../../authority/testdata/certs/foo.csr")
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
csr, ok := _csr.(*x509.CertificateRequest)
|
||
|
|
assert.Fatal(t, ok)
|
||
|
|
|
||
|
|
// Request with chi context
|
||
|
|
chiCtx := chi.NewRouteContext()
|
||
|
|
chiCtx.URLParams.Add("ordID", o.ID)
|
||
|
|
prov := newProv()
|
||
|
|
url := fmt.Sprintf("http://ca.smallstep.com/acme/%s/order/%s/finalize",
|
||
|
|
acme.URLSafeProvisionerName(prov), o.ID)
|
||
|
|
|
||
|
|
type test struct {
|
||
|
|
auth acme.Interface
|
||
|
|
ctx context.Context
|
||
|
|
statusCode int
|
||
|
|
problem *acme.Error
|
||
|
|
}
|
||
|
|
var tests = map[string]func(t *testing.T) test{
|
||
|
|
"fail/no-provisioner": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.Background(),
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("provisioner expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-provisioner": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.WithValue(context.Background(), provisionerContextKey, nil),
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("provisioner expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/no-account": func(t *testing.T) test {
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: context.WithValue(context.Background(), provisionerContextKey, prov),
|
||
|
|
statusCode: 404,
|
||
|
|
problem: acme.AccountDoesNotExistErr(nil),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-account": func(t *testing.T) test {
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, nil)
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 404,
|
||
|
|
problem: acme.AccountDoesNotExistErr(nil),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/no-payload": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("payload expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/nil-payload": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, nil)
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 500,
|
||
|
|
problem: acme.ServerInternalErr(errors.New("payload expected in request context")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/unmarshal-payload-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{})
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 400,
|
||
|
|
problem: acme.MalformedErr(errors.New("failed to unmarshal finalize-order request payload: unexpected end of JSON input")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/malformed-payload-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
fr := &FinalizeRequest{}
|
||
|
|
b, err := json.Marshal(fr)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
return test{
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 400,
|
||
|
|
problem: acme.MalformedErr(errors.New("unable to parse csr: asn1: syntax error: sequence truncated")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"fail/FinalizeOrder-error": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
nor := &FinalizeRequest{
|
||
|
|
CSR: base64.RawURLEncoding.EncodeToString(csr.Raw),
|
||
|
|
}
|
||
|
|
b, err := json.Marshal(nor)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
ctx = context.WithValue(ctx, chi.RouteCtxKey, chiCtx)
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
finalizeOrder: func(p provisioner.Interface, accID, id string, incsr *x509.CertificateRequest) (*acme.Order, error) {
|
||
|
|
assert.Equals(t, p, prov)
|
||
|
|
assert.Equals(t, accID, acc.ID)
|
||
|
|
assert.Equals(t, id, o.ID)
|
||
|
|
assert.Equals(t, incsr.Raw, csr.Raw)
|
||
|
|
return nil, acme.MalformedErr(errors.New("force"))
|
||
|
|
},
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 400,
|
||
|
|
problem: acme.MalformedErr(errors.New("force")),
|
||
|
|
}
|
||
|
|
},
|
||
|
|
"ok": func(t *testing.T) test {
|
||
|
|
acc := &acme.Account{ID: "accID"}
|
||
|
|
nor := &FinalizeRequest{
|
||
|
|
CSR: base64.RawURLEncoding.EncodeToString(csr.Raw),
|
||
|
|
}
|
||
|
|
b, err := json.Marshal(nor)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
ctx := context.WithValue(context.Background(), provisionerContextKey, prov)
|
||
|
|
ctx = context.WithValue(ctx, accContextKey, acc)
|
||
|
|
ctx = context.WithValue(ctx, payloadContextKey, &payloadInfo{value: b})
|
||
|
|
ctx = context.WithValue(ctx, chi.RouteCtxKey, chiCtx)
|
||
|
|
return test{
|
||
|
|
auth: &mockAcmeAuthority{
|
||
|
|
finalizeOrder: func(p provisioner.Interface, accID, id string, incsr *x509.CertificateRequest) (*acme.Order, error) {
|
||
|
|
assert.Equals(t, p, prov)
|
||
|
|
assert.Equals(t, accID, acc.ID)
|
||
|
|
assert.Equals(t, id, o.ID)
|
||
|
|
assert.Equals(t, incsr.Raw, csr.Raw)
|
||
|
|
return &o, nil
|
||
|
|
},
|
||
|
|
getLink: func(typ acme.Link, provID string, abs bool, in ...string) string {
|
||
|
|
assert.Equals(t, typ, acme.OrderLink)
|
||
|
|
assert.Equals(t, provID, acme.URLSafeProvisionerName(prov))
|
||
|
|
assert.True(t, abs)
|
||
|
|
assert.Equals(t, in, []string{o.ID})
|
||
|
|
return fmt.Sprintf("https://ca.smallstep.com/acme/%s/order/%s",
|
||
|
|
acme.URLSafeProvisionerName(prov), o.ID)
|
||
|
|
},
|
||
|
|
},
|
||
|
|
ctx: ctx,
|
||
|
|
statusCode: 200,
|
||
|
|
}
|
||
|
|
},
|
||
|
|
}
|
||
|
|
for name, run := range tests {
|
||
|
|
tc := run(t)
|
||
|
|
t.Run(name, func(t *testing.T) {
|
||
|
|
h := New(tc.auth).(*Handler)
|
||
|
|
req := httptest.NewRequest("GET", url, nil)
|
||
|
|
req = req.WithContext(tc.ctx)
|
||
|
|
w := httptest.NewRecorder()
|
||
|
|
h.FinalizeOrder(w, req)
|
||
|
|
res := w.Result()
|
||
|
|
|
||
|
|
assert.Equals(t, res.StatusCode, tc.statusCode)
|
||
|
|
|
||
|
|
body, err := ioutil.ReadAll(res.Body)
|
||
|
|
res.Body.Close()
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
|
||
|
|
if res.StatusCode >= 400 && assert.NotNil(t, tc.problem) {
|
||
|
|
var ae acme.AError
|
||
|
|
assert.FatalError(t, json.Unmarshal(bytes.TrimSpace(body), &ae))
|
||
|
|
prob := tc.problem.ToACME()
|
||
|
|
|
||
|
|
assert.Equals(t, ae.Type, prob.Type)
|
||
|
|
assert.Equals(t, ae.Detail, prob.Detail)
|
||
|
|
assert.Equals(t, ae.Identifier, prob.Identifier)
|
||
|
|
assert.Equals(t, ae.Subproblems, prob.Subproblems)
|
||
|
|
assert.Equals(t, res.Header["Content-Type"], []string{"application/problem+json"})
|
||
|
|
} else {
|
||
|
|
expB, err := json.Marshal(o)
|
||
|
|
assert.FatalError(t, err)
|
||
|
|
assert.Equals(t, bytes.TrimSpace(body), expB)
|
||
|
|
assert.Equals(t, res.Header["Location"],
|
||
|
|
[]string{fmt.Sprintf("https://ca.smallstep.com/acme/%s/order/%s",
|
||
|
|
acme.URLSafeProvisionerName(prov), o.ID)})
|
||
|
|
assert.Equals(t, res.Header["Content-Type"], []string{"application/json"})
|
||
|
|
}
|
||
|
|
})
|
||
|
|
}
|
||
|
|
}
|