From 07936060d1aa95933b392847e58a5b72f6406774 Mon Sep 17 00:00:00 2001
From: Martin Fischer <martin@push-f.com>
Date: Fri, 4 Feb 2022 21:04:50 +0100
Subject: [PATCH] preferences: Set autocomplete=off for form

Otherwise you can change the value of a select,
refresh the page and the preferences stay changed,
leaving the wrong impression that they were saved.
---
 searx/templates/oscar/preferences.html  | 2 +-
 searx/templates/simple/preferences.html | 2 +-
 tests/unit/test_webapp.py               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/searx/templates/oscar/preferences.html b/searx/templates/oscar/preferences.html
index f731a8fc1..71ee57a62 100644
--- a/searx/templates/oscar/preferences.html
+++ b/searx/templates/oscar/preferences.html
@@ -94,7 +94,7 @@
 <div>
 
     <h1>{{ _('Preferences') }}</h1>
-    <form method="post" action="{{ url_for('preferences') }}" id="search_form">
+    <form method="post" action="{{ url_for('preferences') }}" id="search_form" autocomplete="off">
 
         <!-- Nav tabs -->
         <ul class="nav nav-tabs nav-justified hide_if_nojs" role="tablist">
diff --git a/searx/templates/simple/preferences.html b/searx/templates/simple/preferences.html
index b674d5d02..b47cbc774 100644
--- a/searx/templates/simple/preferences.html
+++ b/searx/templates/simple/preferences.html
@@ -98,7 +98,7 @@
 {% block content %}
 <h1>{{ _('Preferences') }}</h1>
 
-<form id="search_form" method="post" action="{{ url_for('preferences') }}">
+<form id="search_form" method="post" action="{{ url_for('preferences') }}" autocomplete="off">
 
 {{ tabs_open() }}
 
diff --git a/tests/unit/test_webapp.py b/tests/unit/test_webapp.py
index fd7c72e60..7861a3b43 100644
--- a/tests/unit/test_webapp.py
+++ b/tests/unit/test_webapp.py
@@ -186,7 +186,7 @@ class ViewsTestCase(SearxTestCase):
     def test_preferences(self):
         result = self.app.get('/preferences')
         self.assertEqual(result.status_code, 200)
-        self.assertIn(b'<form method="post" action="/preferences" id="search_form">', result.data)
+        self.assertIn(b'<form method="post" action="/preferences" id="search_form" autocomplete="off">', result.data)
         self.assertIn(b'<label class="col-sm-3 col-md-2" for="categories">Default categories</label>', result.data)
         self.assertIn(b'<label class="col-sm-3 col-md-2" for="locale">Interface language</label>', result.data)