From fd4ec784e02d5f3ce715c3b1e1f967716a069667 Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Sun, 14 Nov 2021 22:53:02 +0100 Subject: [PATCH] Remove useless assignments on error Leave the output parameter untouched on error. --- app/src/sys/win/process.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/src/sys/win/process.c b/app/src/sys/win/process.c index e4460ea7..f76fa12e 100644 --- a/app/src/sys/win/process.c +++ b/app/src/sys/win/process.c @@ -84,7 +84,6 @@ sc_process_execute_p(const char *const argv[], HANDLE *handle, char *cmd = malloc(CMD_MAX_LEN); if (!cmd || !build_cmd(cmd, CMD_MAX_LEN, argv)) { - *handle = NULL; goto error_close_stderr; } @@ -98,7 +97,6 @@ sc_process_execute_p(const char *const argv[], HANDLE *handle, if (!CreateProcessW(NULL, wide, NULL, NULL, TRUE, 0, NULL, NULL, &si, &pi)) { free(wide); - *handle = NULL; if (GetLastError() == ERROR_FILE_NOT_FOUND) { ret = SC_PROCESS_ERROR_MISSING_BINARY;