From 7e93abcf6d8982f194e016b3ea0227c1834893fa Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Thu, 11 Nov 2021 17:49:47 +0100 Subject: [PATCH] Factorize common impl of process_execute() Both implementations are the same. Move them to the common process.c. --- app/src/sys/unix/process.c | 5 ----- app/src/sys/win/process.c | 5 ----- app/src/util/process.c | 5 +++++ 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/app/src/sys/unix/process.c b/app/src/sys/unix/process.c index e534ae9d..ef5d9d79 100644 --- a/app/src/sys/unix/process.c +++ b/app/src/sys/unix/process.c @@ -153,11 +153,6 @@ process_execute_redirect(const char *const argv[], pid_t *pid, int *pipe_stdin, return res; } -enum process_result -process_execute(const char *const argv[], pid_t *pid) { - return process_execute_redirect(argv, pid, NULL, NULL, NULL); -} - bool process_terminate(pid_t pid) { if (pid <= 0) { diff --git a/app/src/sys/win/process.c b/app/src/sys/win/process.c index 289d1fca..257427f3 100644 --- a/app/src/sys/win/process.c +++ b/app/src/sys/win/process.c @@ -142,11 +142,6 @@ error_close_stdin: return ret; } -enum process_result -process_execute(const char *const argv[], HANDLE *handle) { - return process_execute_redirect(argv, handle, NULL, NULL, NULL); -} - bool process_terminate(HANDLE handle) { return TerminateProcess(handle, 1); diff --git a/app/src/util/process.c b/app/src/util/process.c index 637132d9..dcb715e6 100644 --- a/app/src/util/process.c +++ b/app/src/util/process.c @@ -3,6 +3,11 @@ #include #include "log.h" +enum process_result +process_execute(const char *const argv[], process_t *pid) { + return process_execute_redirect(argv, pid, NULL, NULL, NULL); +} + bool process_check_success(process_t proc, const char *name, bool close) { if (proc == PROCESS_NONE) {