Commit Graph

43 Commits (e8683274ff4f452f4ad2a680285eb4ff1553d479)

Author SHA1 Message Date
TK Buristrakul a315f2fefb chore: added more descriptive TODOs 2 years ago
Arkid 623161e50d
fix: Revert deref change
Revert the addition of a deref in PR #1192 by me, which should not be there.

Apologies for the inconvenience caused.
2 years ago
Arkid 34ed235885
fix: Add a deref in the test code
It's virtually impossible to write a the `num_sq` function to take the Box since it doesn't implement `MulAssign`.
2 years ago
Rod Elias 9b66b2a0e9 fix(try_from_into): fix function name 2 years ago
mokou 4bebdb5f02 feat(as_ref_mut): add AsMut section 2 years ago
mokou 81d25aecff feat(try_from_into): add hint comments 2 years ago
mokou 74f44f55e3 feat(conversions): add hint comments 2 years ago
mokou ed0f278a8f chore: remove mod.rs files and exercises feature 2 years ago
fointard 452ab26aa7
refactor(using_as): improve readability by using sum() instead of fold() 2 years ago
x-hgg-x 179a75a68d
fix: Include exercises folder in the project structure behind a feature (#917)
closes #859
closes #913
closes #942
2 years ago
diannasoriel c2ed98deb3
Merge pull request #781 from tlyu/advanced-errs
feature: advanced errors
3 years ago
fmoko 6948905716
Merge pull request #737 from ghost/correct-small-typo
Correct small typo in exercises/conversions/from_str.rs
3 years ago
Taylor Yu 2dc93cadda fix(from_str, try_from_into): custom error types
Remove the use of trait objects as errors from `from_str` and
`try_from_into`; they seem to have caused a lot of confusion in
practice. (Also, it's considered best practice to use custom error
types instead of boxed errors in library code.) Instead, use custom
error enums, and update hints accordingly. Hints also provide
some guidance about converting errors, which could be covered
more completely in a future advanced errors section.

Also move from_str to directly after the similar exercise `from_into`,
for the sake of familiarity when solving.
3 years ago
Martin HART 86cc85295a fix: Correct small typo in exercises/conversions/from_str.rs 3 years ago
Zerotask 249ad44cc0
docs(exercises): updated all exercises readme files
all exercises readme files now have a unified structure and a description
3 years ago
Taylor Yu c3e7b83178 fix: use trait objects for from_str
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate 
errors.
3 years ago
Taylor Yu 2e93a588e0 fix: use trait objects for try_from_into
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.  In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
3 years ago
Jirka Kremser 5f7c89f85d
fix(from_str): Correct typos
typos in the comments
3 years ago
Jean-Francois Chevrette 15e71535f3 fix(from_str): test for error instead of unwrap/should_panic 4 years ago
Sang-Heon Jeon 4f1374a6e7 feat(from_into) : add test for checking unnecessary trailing value 4 years ago
Sang-Heon Jeon 5a0521e92c feat(from_str) : add test for checking unnecessary trailing value 4 years ago
Christos Kontas 04f1d079aa feat(try_from_into): remove duplicate annotation 4 years ago
Wei Hu 4f4cfcf3c3 fix(try_from_into): type error 4 years ago
JP 96347df9df
fix(try_from_into): Update description (#584)
Description update
4 years ago
fiplox 95ccd92616
feat(try_from_into): Add tests (#571)
Co-authored-by: Volodymyr Patuta <6977238-fiplox@users.noreply.gitlab.com>
4 years ago
Greg Leonard 2933f51949
chore: Change point to comma in from_into.rs
A typo in the fn test_bad_age() hint message had a point rather than comma

Prev:
// Test that "Mark.twenty"

Current:
// Test that "Mark,twenty"
4 years ago
Ryan McQuen 3286c5ec19
fix(using_as): Add test so that proper type is returned. (#512) 4 years ago
Étienne Barrié 3144d3ae63 chore: Run rustfmt on exercises 4 years ago
Chad Dougherty 523d18b873
feat(try_from_into): Add insufficient length test (#469) 4 years ago
Benjamin Jones bb5f404e35 chore: Alter whitespace for consistency
* Add newline after "I AM DONE" in exercises for consistency
* Remove trailing whitespace from exercises
4 years ago
millefalcon 307252e9ae Added example to show the AsRef working 4 years ago
IkaR49 763aa6e378
feat: Rewrite try_from_into (#393) 4 years ago
fmoko a39ffb2fb8
Merge pull request #368 from apatniv/update_test_case 4 years ago
apatniv 41f989135d Review Comments: Add other test cases 4 years ago
Jihchi Lee a901499ede
fix(from_into.rs): typo 4 years ago
apatniv 19fb1c240c test: Add missing test case for from_str exercise 4 years ago
lebedevsergey c9e4f2cfb4
fix: confusing comment in conversions/try_from_into.rs
Co-authored-by: Lebedev <sergey.lebedev@corp.mail.ru>
4 years ago
Tonći Galić 60393999b8
remove bottom comment instead of top 4 years ago
Tonći Galić dab90f7b91
Remove duplicate not done comment
As indicated in #259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from #281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
4 years ago
skim bc22ec382f
adds additional test to meet exercise rules 4 years ago
dmitri-mamrukov dfdf8093eb
Enable a test and improve per clippy's suggestion. 5 years ago
Abdou Seck fc26b5e151 I AM NOT DONE comment in conversions exercise files 5 years ago
Abdou Seck 0c85dc1193 feat: Add type conversion and parsing exercises 5 years ago