marisa
2b766ef9f9
Merge pull request #648 from apogeeoak/iterator2
...
Moved iterators2.rs errors out of tests.
4 years ago
marisa
bd3d9ac9d5
Merge pull request #649 from apogeeoak/iterator3
...
Enabled iterators3.rs to run without commented out tests.
4 years ago
Shao Yang Hong
6bd791f2f4
fix(structs): Add 5.3 to structs/README ( #652 )
...
Co-authored-by: Shao Yang Hong <shaoyang.hong@ninjavan.co>
4 years ago
k12ish
b4de659438
fix(option2): Rename uninformative variables ( #675 )
...
Renaming uninformative names like `optional_value`, `value`, `optional_values_vec` and `value` helps users distinguish between the two parts of the task.
4 years ago
Pete Pavlovski
72aaa15e6a
fix(hashmap2): Update incorrect assertion ( #660 )
...
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :)
A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
4 years ago
Abdou Seck
f2ad3a6a0b
Merge pull request #697 from WowSuchRicky/main
...
Rename 'Lichi' to 'Lychee' in the fruit example
4 years ago
Abdou Seck
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming
...
Update collections exercises naming
4 years ago
WowSuchRicky
b790bafc02
Rename lichi to lychee in the fruit example
4 years ago
Taylor Yu
c3e7b83178
fix: use trait objects for from_str
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.
4 years ago
Taylor Yu
2e93a588e0
fix: use trait objects for try_from_into
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors. In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
4 years ago
Ignacio Le Fluk
a6509cc4d5
fix(functions3): improve function argument type ( #687 )
4 years ago
Rod Elias
3df094713f
chore: capitalize `c` letter
...
By capitalizing the `c` letter it makes clear that we're talking about the C programming language.
4 years ago
Mickael Fortunato
ab9995e76e
doc: Update collections exercises instruction to match the standard naming
4 years ago
Mickael Fortunato
bef39b1259
fix(collections): Naming exercises for vectors and hashmap
4 years ago
Pascal H
0d894e6ff7
fix(quiz3): Force an answer to Q2 ( #672 )
...
Add also an example of unimplemented!() macro.
4 years ago
Pascal H
3bce2ef8d6
chore: clarify collections documentation
...
C++ `map` is more like BTreeMap.
`unordered_map` in C++(11) is the equivalent of `HashMap` in Rust.
(+ additional like for references).
4 years ago
Darius Wiles
9f3e8c2dde
fix(structs3): reword heading comment ( #664 )
4 years ago
cadolphs
05a753fe63
fix: add check to prevent naive implementation of is_international
...
* fix(structs3): Add check to prevent naive implementation
* chore(structs3): Add a missed newline after the test I added
4 years ago
Jirka Kremser
5f7c89f85d
fix(from_str): Correct typos
...
typos in the comments
4 years ago
apogeeoak
c6712dfccd
fix(iterators3): Enabled iterators3.rs to run without commented out tests.
4 years ago
apogeeoak
baf4ba175b
fix(iterators2): Moved errors out of tests.
...
Closes #359
4 years ago
apogeeoak
b29ea17ea9
feat: Added iterators5.rs exercise.
4 years ago
Tal
cc266d7d80
fix(move_semantics4): Remove redundant "instead" ( #640 )
4 years ago
Jean-Francois Chevrette
15e71535f3
fix(from_str): test for error instead of unwrap/should_panic
4 years ago
Sang-Heon Jeon
4f1374a6e7
feat(from_into) : add test for checking unnecessary trailing value
4 years ago
Sang-Heon Jeon
5a0521e92c
feat(from_str) : add test for checking unnecessary trailing value
4 years ago
Christian Zeller
7857b0a689
fix(threads1): line number correction
4 years ago
Marius Ungureanu
10965920fb
fix(move_semantics4): Small readbility improvement ( #617 )
...
* Small readbility improvement move_semantics4 doc
* Remove `an` as it refers to the argument
4 years ago
Axel Viala
0ef95947cc
fix(functions2): Change signature to trigger precise error message: ( #605 )
...
Now trigger this error:
```
error: expected type, found `)`
--> exercises/functions/functions2.rs:10:16
|
10 | fn call_me(num:) {
| ^ expected type
```
4 years ago
seancad
bcf14cf677
fix: update structs README
4 years ago
JuliaCao
90cfb6ff28
fix: added missing exercises to info.toml
4 years ago
Peter N
30644c9a06
fix: gives a bit more context to magic number
4 years ago
JuliaCao
033bf1198f
feat: match exercise order to book chapters ( #541 )
...
Added exercise to book chapter mapping table to exercise README
4 years ago
fmoko
cdc7d92e57
Merge pull request #592 from tinkhauser/vec1_bugfix
...
fix(vec1): Have test compare every element in a and v
4 years ago
Christos Kontas
04f1d079aa
feat(try_from_into): remove duplicate annotation
4 years ago
Jacob Tinkhauser
9b6c629397
fix(vec1): Have test compare every element in a and v
...
The previous test would stop comparing elements in array a and vec v upon reaching the last element of either. This resulted in the test passing even if v did not contain all the elements in a. This change to the test fixes that bug and should only pass if all the elements in a and v are present and equal.
4 years ago
Wei Hu
4f4cfcf3c3
fix(try_from_into): type error
4 years ago
JP
96347df9df
fix(try_from_into): Update description ( #584 )
...
Description update
4 years ago
fiplox
95ccd92616
feat(try_from_into): Add tests ( #571 )
...
Co-authored-by: Volodymyr Patuta <6977238-fiplox@users.noreply.gitlab.com>
4 years ago
JP
197d3a3d89
fix(iterators2): Update description ( #578 )
...
grammar fix in the description
4 years ago
sazid
633c00cf80
feat: Add HashMap exercises
4 years ago
sazid
0c12fa31c5
feat: Add Vec exercises
4 years ago
Matthew Smillie
472d8592d6
fix(primitive_types6): remove 'unused doc comment' warning
4 years ago
Matthew Smillie
4fb230daf1
fix(primitive_types6): missing comma in test
4 years ago
Axel Viala
2b1fb2b739
feat(primitive_types6): Add a test ( #548 )
...
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com>
Co-authored-by: fmoko <mokou@posteo.de>
4 years ago
Ryan McQuen
18e0bfef1d
fix(quiz3): Second test is for odd numbers, not even. ( #553 )
4 years ago
fmoko
69fc9ce10e
Merge pull request #545 from YJDoc2/main
4 years ago
Yashodhan Joshi
2ec0bdfd99
fix(variables5) : make shadowing more prominent
...
closes #375
4 years ago
fmoko
2a682abeef
Merge pull request #522 from calvinbrown085/adding-test-for-false-case
4 years ago
Greg Leonard
2933f51949
chore: Change point to comma in from_into.rs
...
A typo in the fn test_bad_age() hint message had a point rather than comma
Prev:
// Test that "Mark.twenty"
Current:
// Test that "Mark,twenty"
4 years ago
Calvin Brown
bec97b6c76
Fixing test3 to have enough tests to make sure we test all cases
4 years ago
Jannek Squar
114b54cbdb
fix(structs3): Small adjustment of variable name
...
Co-authored-by: Jannek <squar@informatik.uni-hamburg.de>
4 years ago
fmoko
0f16463794
Merge pull request #489 from mukundbhudia/iterators1
4 years ago
Ryan McQuen
3286c5ec19
fix(using_as): Add test so that proper type is returned. ( #512 )
4 years ago
Koalab99
ee7cdc66b3
chore: Removed extra whitespaces
...
Co-authored-by: Corentin ARNOULD <corentin.arn@gmail.com>
4 years ago
Samuel Batista
6bb0b48b10
Make macros4 not compile by default
...
Did you mean this? I'm new to rust and this test passed right away, so unsure what the intention was.
4 years ago
Antoine Barthelemy
101072ab9f
fix(exercises): adding question mark to quiz2
...
Question marks added for consistency.
closes #496
4 years ago
John Heath
dd54ccf677
Make comments on example clearer
...
I actually struggled because I overlooked the fact that I needed to change the 2.1 to "A+".
So I wanted to make things clearer for future rustlings.
4 years ago
seeplusplus
b4062ef699
fix(arc1): index mod should equal thread count
4 years ago
Étienne Barrié
3144d3ae63
chore: Run rustfmt on exercises
4 years ago
Mukund Bhudia
9642f5a3f6
feat: Added iterators1.rs exercise
4 years ago
Chad Dougherty
523d18b873
feat(try_from_into): Add insufficient length test ( #469 )
4 years ago
Benjamin Jones
bb5f404e35
chore: Alter whitespace for consistency
...
* Add newline after "I AM DONE" in exercises for consistency
* Remove trailing whitespace from exercises
4 years ago
DEWA Kazuyuki/出羽和之
4b6540c71a
fix(enums3): Update Message::ChangeColor to take a tuple. ( #457 )
4 years ago
fmoko
75c0053bb1
Merge pull request #433 from SebastienCaunes/fix#432
...
fix : Use of integer for prices, therefore also for weight
4 years ago
Alexx Roche
113cdae2d4
fix(arc1): Passively introduce attributes ( #429 )
...
Ensure that std::sync::Arc is actually used, as this exercise can be compiled using things already learnt in previous exercises.
4 years ago
Sebastien Caunes
9ca08b8f2b
fix : Use of integer for prices, therefore also for weight
...
rename confusing "from" and "to" to sender_country and recipient_country as suggested
4 years ago
millefalcon
307252e9ae
Added example to show the AsRef working
4 years ago
Alexx Roche
bb2ca25110
fix(box1): fix comment typo ( #426 )
...
Doesn't effect the code.
4 years ago
Alexx Roche
5563adbb89
fix: fix quiz naming inconsistency ( #421 )
...
Inconsistent naming when compared with the other quiz files.
4 years ago
Alexx Roche
524e17df10
fix(variables6): minor typo ( #419 )
...
Looks like this was cloned from variables5.rs
4 years ago
fmoko
73e848e96f
Merge pull request #416 from danwilhelm/traits-readme
...
feat: Add traits README
4 years ago
fmoko
5f0806967c
Merge pull request #409 from AlexandruGG/feature/box-exercise
4 years ago
Dan Wilhelm
173bb14140
feat: Add traits README
4 years ago
fmoko
918f310674
Merge pull request #410 from tsauvajon/fix-option1
...
fix(option1): Don't add only zeros to the numbers array
4 years ago
Dan Wilhelm
0311c03735
chore: Limit generics3 lines to 90 chars
4 years ago
AlexandruGG
df81141d6f
Address PR feedback: add tests
4 years ago
Thomas Sauvajon
cce6a44277
fix(option1): Don't add only zeros to the numbers array
4 years ago
AlexandruGG
7479a4737b
feat: Add box1.rs exercise
4 years ago
Evan Carroll
06ef4cc654
fix: confine the user further in variable exercises
...
We want to teach a specific lesson. To ensure that we do, let's try to
provide more clarity on what the user should not do.
4 years ago
Jade McGough
c7c3130507
chore: remove struct2 hint comment
4 years ago
Sanjay K
010a045692
feat: renames test to quiz, fixes #244
...
BREAKING CHANGE
* changed test to quiz: fixes issues in #244
* fixed info.toml: #244
* fixed naming related issues
4 years ago
fmoko
51666609f1
Merge pull request #365 from sjmann/generics-2-fix
4 years ago
Stefan Kupresak
10967bce57
fix(option2): Add TODO to comments ( #400 )
4 years ago
IkaR49
763aa6e378
feat: Rewrite try_from_into ( #393 )
5 years ago
Gaurang Tandon
d6c0a688e6
fix(test2): name of type String and &str ( #394 )
5 years ago
Evan Carroll
2b20c8a0f5
fix(errorsn): Try harder to confine the user. ( #388 )
5 years ago
Siobhan Jacobson
09e89bbcd3
Update Message::Move in the enums3 test to take a Point.
5 years ago
fmoko
7c4b1f910c
Merge pull request #372 from DiD92/exercise_structs3
5 years ago
fmoko
3ceabe91f8
Merge pull request #383 from wrobstory/wrobstory-exercises
5 years ago
fmoko
a39ffb2fb8
Merge pull request #368 from apatniv/update_test_case
5 years ago
apatniv
41f989135d
Review Comments: Add other test cases
5 years ago
Rob Story
f6cffc7e48
fix(option1): Add cast to usize, as it is confusing in the context of an exercise about Option
5 years ago
Rob Story
1da84b5f7c
feat: Add if2 exercise
5 years ago
Christofer Bertonha
c301814d68
chore: Remove deprecated description from error_handling/errorsn.rs
5 years ago
Jihchi Lee
a901499ede
fix(from_into.rs): typo
5 years ago
Dan Wilhelm
9590082848
fix: update iterator and macro text for typos and clarity
...
- /macros/README.md: Typo "modules" => "macros"
- iterators2.py: Reduce line length to <90-char width.
- iterators4.py: Update 'fun' => 'challenge' as per PR#177
- rustlings hint iterators4: improve clarity
5 years ago
Dídac Sementé Fernández
b66e2e0962
feat: Added exercise structs3.rs
5 years ago
apatniv
19fb1c240c
test: Add missing test case for from_str exercise
5 years ago
Steven Mann
630ff0e00b
chore: add explanatory comment to clippy1
5 years ago
sjmann
964c974a02
fix: update generics2 closes #362
5 years ago
lebedevsergey
c9e4f2cfb4
fix: confusing comment in conversions/try_from_into.rs
...
Co-authored-by: Lebedev <sergey.lebedev@corp.mail.ru>
5 years ago
Ufuk Celebi
6c3cc2caf5
chore: delete orphaned `error_handling/option1.rs`
...
`error_handling/option1.rs` has been replaced by `option/option1.rs` and
is not referenced in `info.toml` any more.
5 years ago
Said Aspen
5999acd24a
feat: Add exercise variables6 covering const ( #352 )
5 years ago
fmoko
052f0aa7d4
Merge pull request #292 from Tuxified/patch-1
...
Remove duplicate not done comment
5 years ago
Tonći Galić
60393999b8
remove bottom comment instead of top
5 years ago
Roberto Vidal
b3a3351e8e
fix: revert primitive_types4 ( #296 )
5 years ago
Sanjay K
86b5c08b9b
feat: Add Option2 exercise ( #290 )
...
* added option2
* changed up the exercise, modified the help section
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
Co-authored-by: fmoko <mokou@posteo.net>
5 years ago
Tonći Galić
dab90f7b91
Remove duplicate not done comment
...
As indicated in #259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from #281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
5 years ago
Roberto Vidal
3b6d5c3aaa
feature: makes "compile" exercise print output, resolves #270
...
When running "compile"-mode exercises in interactive `verify` mode,
we print their output when we prompt the learner if they want to
continue. This improves the "experimentation" experience, since
trying different things does produce a visible change.
5 years ago
fmoko
7ce42941ea
Merge pull request #282 from sanjaykdragon/master
...
feat: added option exercise
5 years ago
fmoko
b135b589e0
Merge pull request #280 from sjmann/generics-exercises
...
feat: added generics exercises
5 years ago
Sanjay K
05ca3d77f7
Merge branch 'master' of https://github.com/sanjaykdragon/rustlings
5 years ago
Sanjay K
6deee7e3e9
fixed spacing
5 years ago
Sanjay K
9788496a85
Update option1.rs
5 years ago
Sanjay K
6d3a412d47
Update option1.rs
5 years ago
skim
bc22ec382f
adds additional test to meet exercise rules
5 years ago
Sanjay K
135e5d47a7
feat: added excercise for option
5 years ago
sjmann
0f8001ea44
add I AM NOT DONE comments
5 years ago
sjmann
29b30ec946
Merge branch 'master' of https://github.com/sjmann/rustlings into generics-exercises
5 years ago
sjmann
76be5e4e99
feat: added new exercises for generics
5 years ago
Mario Reder
1e2fd9c92f
feat: Add clippy lints
...
- adds a new 'clippy' category for exercises
- clippy exercises should throw no warnings
- install script now also installs clippy
is related to https://github.com/rust-lang/rust-clippy/issues/2604
5 years ago
bors
78295ce92f
Auto merge of #274 - sjmann:master, r=fmoko
...
chore: fixed merge conflicts from traits exercises added by s-marios
I hope this doesn't step on any toes but I wanted to try the traits exercises from #216 so I updated them to match the new structure with hints included in info.toml
5 years ago
Stig Johan Berggren
a45486f2d0
Add a second test case
5 years ago
Stig Johan Berggren
8b971ffab6
Enable test for exercise test4
5 years ago
Steven Mann
dc84aacc65
remove confusing comment wording
5 years ago
sjmann
b559cdd73f
added traits exercises
5 years ago
sjmann
a3f70124dc
fixed typo
5 years ago
sjmann
bec8e3a644
reworded missing exercise explanation
5 years ago
Jason Tsai
39fa7ae8b7
chore: Correct test command in tests1.rs comment
5 years ago
Paul Bissex
ade52ffb73
Fixed mangled sentence from book; edited for clarity
5 years ago
Torben Jonas
0c73609e6f
feat: Add variables5.rs exercise
...
closes #260
5 years ago
gnodarse
fd57f8f2c1
Created consistent money unit
5 years ago
dmitri-mamrukov
dfdf8093eb
Enable a test and improve per clippy's suggestion.
5 years ago
Abdou Seck
fc26b5e151
I AM NOT DONE comment in conversions exercise files
5 years ago
Abdou Seck
0c85dc1193
feat: Add type conversion and parsing exercises
5 years ago
marisa
fe10e06c37
fix(tests1): Change test command
...
Closes #243 .
5 years ago
Rahat Ahmed
54571a5fca
fix(iterators2): Remove reference to missing iterators2.rs
5 years ago
Jens
31c25ebb50
Add link to chapter on pattern syntax
...
After being stuck on exercise enums3.rs for about an hour or two, having read the entire chapter on enums 2-3 times, and still being unable to complete the exercise, i started broadening my reading. I finally found the answer in the rust docs via google.
5 years ago
Roberto Vidal
b565c4d3e7
fix: line numbers in several exercises and hints
...
The introduction of `I AM NOT DONE` shifted the lines of all
exercises, which now need adjustment.
5 years ago
Chris Keschnat
c42c3b2101
fix(arc1): Fix some words in the comment
5 years ago
Chris Keschnat
fda5a47069
fix(variables1): Correct wrong word in comment
5 years ago
Roberto Vidal
ded2c034ba
fix(primitive_types4): update outdated comment
5 years ago
marisa
1a7bb5a400
Address feedback
5 years ago
marisa
ec2d4bd3ee
Merge branch 'master' into refactor-hints
5 years ago
marisa
9bdb0a12e4
feat: Refactor hint system
...
Hints are now accessible using the CLI subcommand `rustlings hint
<exercise name`.
BREAKING CHANGE: This fundamentally changes the way people interact with exercises.
5 years ago
Roberto Vidal
2cdd61294f
feat: improve `watch` execution mode
...
The `watch` command now requires user action to move to the next
exercise.
BREAKING CHANGE: this changes the behavior of `watch`.
5 years ago
marisa
f72e5a8f05
fix(structs1): Remove misleading comment
5 years ago
marisa
6dcecb38a4
fix(strings): Move Strings before Structs
...
Closes #204 .
5 years ago
marisa
dcfb427b09
fix(errors3): Update hint
...
Closes #185 .
5 years ago