Commit Graph

14 Commits (74f44f55e381384dc89ec421568aa1509cd7f277)

Author SHA1 Message Date
mokou 74f44f55e3 feat(conversions): add hint comments 2 years ago
Taylor Yu 2dc93cadda fix(from_str, try_from_into): custom error types
Remove the use of trait objects as errors from `from_str` and
`try_from_into`; they seem to have caused a lot of confusion in
practice. (Also, it's considered best practice to use custom error
types instead of boxed errors in library code.) Instead, use custom
error enums, and update hints accordingly. Hints also provide
some guidance about converting errors, which could be covered
more completely in a future advanced errors section.

Also move from_str to directly after the similar exercise `from_into`,
for the sake of familiarity when solving.
3 years ago
Taylor Yu 2e93a588e0 fix: use trait objects for try_from_into
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.  In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
3 years ago
Christos Kontas 04f1d079aa feat(try_from_into): remove duplicate annotation 4 years ago
Wei Hu 4f4cfcf3c3 fix(try_from_into): type error 4 years ago
JP 96347df9df
fix(try_from_into): Update description (#584)
Description update
4 years ago
fiplox 95ccd92616
feat(try_from_into): Add tests (#571)
Co-authored-by: Volodymyr Patuta <6977238-fiplox@users.noreply.gitlab.com>
4 years ago
Étienne Barrié 3144d3ae63 chore: Run rustfmt on exercises 4 years ago
Chad Dougherty 523d18b873
feat(try_from_into): Add insufficient length test (#469) 4 years ago
IkaR49 763aa6e378
feat: Rewrite try_from_into (#393) 4 years ago
apatniv 41f989135d Review Comments: Add other test cases 4 years ago
lebedevsergey c9e4f2cfb4
fix: confusing comment in conversions/try_from_into.rs
Co-authored-by: Lebedev <sergey.lebedev@corp.mail.ru>
4 years ago
Abdou Seck fc26b5e151 I AM NOT DONE comment in conversions exercise files 5 years ago
Abdou Seck 0c85dc1193 feat: Add type conversion and parsing exercises 5 years ago