Commit Graph

268 Commits (537abe273a20adac617e4a81a6fb45fec86bc2c5)

Author SHA1 Message Date
Gaurang Tandon d6c0a688e6
fix(test2): name of type String and &str (#394) 4 years ago
Evan Carroll 2b20c8a0f5
fix(errorsn): Try harder to confine the user. (#388) 4 years ago
Siobhan Jacobson 09e89bbcd3 Update Message::Move in the enums3 test to take a Point. 4 years ago
fmoko 7c4b1f910c
Merge pull request #372 from DiD92/exercise_structs3 4 years ago
fmoko 3ceabe91f8
Merge pull request #383 from wrobstory/wrobstory-exercises 4 years ago
fmoko a39ffb2fb8
Merge pull request #368 from apatniv/update_test_case 4 years ago
apatniv 41f989135d Review Comments: Add other test cases 4 years ago
Rob Story f6cffc7e48 fix(option1): Add cast to usize, as it is confusing in the context of an exercise about Option 4 years ago
Rob Story 1da84b5f7c feat: Add if2 exercise 4 years ago
Christofer Bertonha c301814d68 chore: Remove deprecated description from error_handling/errorsn.rs 4 years ago
Jihchi Lee a901499ede
fix(from_into.rs): typo 4 years ago
Dan Wilhelm 9590082848 fix: update iterator and macro text for typos and clarity
- /macros/README.md: Typo "modules" => "macros"
- iterators2.py: Reduce line length to <90-char width.
- iterators4.py: Update 'fun' => 'challenge' as per PR#177
- rustlings hint iterators4: improve clarity
4 years ago
Dídac Sementé Fernández b66e2e0962 feat: Added exercise structs3.rs 4 years ago
apatniv 19fb1c240c test: Add missing test case for from_str exercise 4 years ago
Steven Mann 630ff0e00b
chore: add explanatory comment to clippy1 4 years ago
sjmann 964c974a02 fix: update generics2 closes #362 4 years ago
lebedevsergey c9e4f2cfb4
fix: confusing comment in conversions/try_from_into.rs
Co-authored-by: Lebedev <sergey.lebedev@corp.mail.ru>
4 years ago
Ufuk Celebi 6c3cc2caf5
chore: delete orphaned `error_handling/option1.rs`
`error_handling/option1.rs` has been replaced by `option/option1.rs` and
is not referenced in `info.toml` any more.
4 years ago
Said Aspen 5999acd24a
feat: Add exercise variables6 covering const (#352) 4 years ago
fmoko 052f0aa7d4
Merge pull request #292 from Tuxified/patch-1
Remove duplicate not done comment
4 years ago
Tonći Galić 60393999b8
remove bottom comment instead of top 4 years ago
Roberto Vidal b3a3351e8e
fix: revert primitive_types4 (#296) 4 years ago
Sanjay K 86b5c08b9b
feat: Add Option2 exercise (#290)
* added option2

* changed up the exercise, modified the help section

* Update exercises/option/option2.rs

Co-Authored-By: fmoko <mokou@posteo.net>

* Update exercises/option/option2.rs

Co-Authored-By: fmoko <mokou@posteo.net>

* Update exercises/option/option2.rs

Co-Authored-By: fmoko <mokou@posteo.net>

Co-authored-by: fmoko <mokou@posteo.net>
4 years ago
Tonći Galić dab90f7b91
Remove duplicate not done comment
As indicated in #259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from #281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
4 years ago
Roberto Vidal 3b6d5c3aaa feature: makes "compile" exercise print output, resolves #270
When running "compile"-mode exercises in interactive `verify` mode,
we print their output when we prompt the learner if they want to
continue. This improves the "experimentation" experience, since
trying different things does produce a visible change.
4 years ago
fmoko 7ce42941ea
Merge pull request #282 from sanjaykdragon/master
feat: added option exercise
4 years ago
fmoko b135b589e0
Merge pull request #280 from sjmann/generics-exercises
feat: added generics exercises
4 years ago
Sanjay K 05ca3d77f7 Merge branch 'master' of https://github.com/sanjaykdragon/rustlings 4 years ago
Sanjay K 6deee7e3e9 fixed spacing 4 years ago
Sanjay K 9788496a85
Update option1.rs 4 years ago
Sanjay K 6d3a412d47
Update option1.rs 4 years ago
skim bc22ec382f
adds additional test to meet exercise rules 4 years ago
Sanjay K 135e5d47a7 feat: added excercise for option 4 years ago
sjmann 0f8001ea44 add I AM NOT DONE comments 4 years ago
sjmann 29b30ec946 Merge branch 'master' of https://github.com/sjmann/rustlings into generics-exercises 4 years ago
sjmann 76be5e4e99 feat: added new exercises for generics 4 years ago
Mario Reder 1e2fd9c92f feat: Add clippy lints
- adds a new 'clippy' category for exercises
- clippy exercises should throw no warnings
- install script now also installs clippy

is related to https://github.com/rust-lang/rust-clippy/issues/2604
4 years ago
bors 78295ce92f Auto merge of #274 - sjmann:master, r=fmoko
chore: fixed merge conflicts from traits exercises added by s-marios

I hope this doesn't step on any toes but I wanted to try the traits exercises from #216 so I updated them to match the new structure with hints included in info.toml
4 years ago
Stig Johan Berggren a45486f2d0
Add a second test case 4 years ago
Stig Johan Berggren 8b971ffab6
Enable test for exercise test4 4 years ago
Steven Mann dc84aacc65
remove confusing comment wording 4 years ago
sjmann b559cdd73f added traits exercises 4 years ago
sjmann a3f70124dc fixed typo 4 years ago
sjmann bec8e3a644 reworded missing exercise explanation 4 years ago
Jason Tsai 39fa7ae8b7 chore: Correct test command in tests1.rs comment 5 years ago
Paul Bissex ade52ffb73
Fixed mangled sentence from book; edited for clarity 5 years ago
Torben Jonas 0c73609e6f feat: Add variables5.rs exercise
closes #260
5 years ago
gnodarse fd57f8f2c1 Created consistent money unit 5 years ago
dmitri-mamrukov dfdf8093eb
Enable a test and improve per clippy's suggestion. 5 years ago
Abdou Seck fc26b5e151 I AM NOT DONE comment in conversions exercise files 5 years ago
Abdou Seck 0c85dc1193 feat: Add type conversion and parsing exercises 5 years ago
marisa fe10e06c37
fix(tests1): Change test command
Closes #243.
5 years ago
Rahat Ahmed 54571a5fca
fix(iterators2): Remove reference to missing iterators2.rs 5 years ago
Jens 31c25ebb50
Add link to chapter on pattern syntax
After being stuck on exercise enums3.rs for about an hour or two, having read the entire chapter on enums 2-3 times, and still being unable to complete the exercise, i started broadening my reading. I finally found the answer in the rust docs via google.
5 years ago
Roberto Vidal b565c4d3e7 fix: line numbers in several exercises and hints
The introduction of `I AM NOT DONE` shifted the lines of all
exercises, which now need adjustment.
5 years ago
Chris Keschnat c42c3b2101
fix(arc1): Fix some words in the comment 5 years ago
Chris Keschnat fda5a47069 fix(variables1): Correct wrong word in comment 5 years ago
Roberto Vidal ded2c034ba fix(primitive_types4): update outdated comment 5 years ago
marisa 1a7bb5a400 Address feedback 5 years ago
marisa ec2d4bd3ee
Merge branch 'master' into refactor-hints 5 years ago
marisa 9bdb0a12e4 feat: Refactor hint system
Hints are now accessible using the CLI subcommand `rustlings hint
<exercise name`.

BREAKING CHANGE: This fundamentally changes the way people interact with exercises.
5 years ago
Roberto Vidal 2cdd61294f feat: improve `watch` execution mode
The `watch` command now requires user action to move to the next
exercise.

BREAKING CHANGE: this changes the behavior of `watch`.
5 years ago
marisa f72e5a8f05 fix(structs1): Remove misleading comment 5 years ago
marisa 6dcecb38a4 fix(strings): Move Strings before Structs
Closes #204.
5 years ago
marisa dcfb427b09 fix(errors3): Update hint
Closes #185.
5 years ago
marisa ad03d180c9 fix(if1): Remove `return` reference
This closes #153.
5 years ago
bors c6dad28ddc Auto merge of #224 - nyxtom:feat-enums, r=fmoko
feat: Add enums exercises

Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
5 years ago
marisa 79a569422c
fix: Rewrite test1 logic 5 years ago
Thomas Holloway dc15032112 feat: Add enums exercises 5 years ago
Scott Sweeny 2821227acf chore: Clarify comment in exercises/test1.rs
closes #194

The author of issue #194 suggests that the wording of the comment is at
least ambiguous about the desired results. I believe this change more
clearly describes the expectation of the exercise.
5 years ago
bors 2191ef7eee Auto merge of #219 - vyaslav:master, r=fmoko
Added exercise for struct update syntax

Added one exercise for struct update syntax `struct2.rs`
5 years ago
Niklas Anderson ead4f7af9e fix(option1): Fix arguments passed to assert! macro 5 years ago
Viacheslav Avramenko 1c4c8764ed feat: Added exercise for struct update syntax 5 years ago
Damian S 8109cbad97 fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objectscloses #211 5 years ago
Dylan Nugent 5b1e673cec fix(primitive_types4): Fail on a slice covering the wrong area
This commit converts primitive_types4 to a test and asserts that the
slice given is equal to the expected slice.

The intent of the primitive_types4 exercise appears to be to ensure the
user understands inclusive and exclusive bounds as well as slice syntax.
`rustlings` commands using `compile` do not verify that a specific
println is reached and, in the case of `watch` and `verify` (but not
`run`), they do not output the `println`s at all.

This fix is semantically similar to #198. It does not take a stance on
the correct way to handle this for all exercises; see #127. There are
likely other exercises whose intent are masked by this issue.
5 years ago
Enrico Miccoli 76b4cb5c00
chore: Correct typo 5 years ago
Niklas Anderson e3931718fb chore(iterators2): Add exercise instructions 5 years ago
Niklas Anderson 4cde86643e fix(iterators2): Remove syntax resulting in misleading error message
closes #199
5 years ago
Andre Pratama e0db987441
docs: Fix wrong title
fix #200
5 years ago
Niklas Anderson a750e4a1a3 fix(option1): Add test for prematurely passing exercise
Fixes the bug referenced in #160, but does not address the larger feature work referenced by the issue.
5 years ago
Pete McFarlane 4086d463a9
fix(test1): Swap assertion parameter order
`Expected` should come before `actual`, other wise it leads to confusing compiler messages, e.g.
```
note: expected type `()`
         found type `{integer}`
```
5 years ago
Jesse 9288fccf07 feat(iterators2): adds iterators2 exercise including config 5 years ago
Jesse 89d5186c0d fix(test1): renamed function name to snake case
closes #180
5 years ago
bors aaad60d07e Auto merge of #172 - miller-time:fix-book-links, r=komaeda
chore: Fix a couple broken book links

While I was fixing these, I figured maybe it's good to just use a consistent URL for book links: https://doc.rust-lang.org/book/

Is there a plan for what to do with this old 1.4.0 example that doesn't exist in the current version of the book? Perhaps at least include a disclaimer when recommending that folks check it out?

34e31232df/exercises/threads/README.md (L1)
5 years ago
bors 5f16469807 Auto merge of #171 - miller-time:rustfmt-exercises, r=komaeda
chore: Clean up some formatting in exercises

I noticed some formatting that isn't consistent with the `rustfmt` style and tried my best to run it on the files in the exercises directory (which does fail for files that can't compile!), which just caught some minor whitespace things here and there.

Note: also can't just apply `rustfmt` blindly because of the blank lines that lead to the hint comments
5 years ago
bors 752bc27e2b Auto merge of #179 - briankung:fix_irrefutable_let_pattern_structs1, r=komaeda
Fixes the irrefutable let pattern warning in `structs1.rs`

PR https://github.com/rust-lang/rustlings/pull/163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.
5 years ago
Brian Kung cc6a14104d Fixes the irrefutable let pattern warning 5 years ago
Russell Cousineau eb13c2b6af chore: Clean up some formatting in exercises 5 years ago
Russell Cousineau 63c133e4a3 chore: Fix a couple broken book links 5 years ago
bors 5586613eec Auto merge of #170 - miller-time:rename-iterator-exercise, r=komaeda
fix(iterators): Rename iterator3.rs

fixes #155
5 years ago
Rohan Prinja 080d6cdd11 chore: Fix link to Arc<T> in the book 5 years ago
Russell Cousineau 433d2115bc fix(iterators): Rename iterator3.rs 5 years ago
bors 41170ce341 Auto merge of #164 - HanKruiger:master, r=komaeda
Fix broken link
5 years ago
gushroom fd1441d122 fixed outdated links 5 years ago
HanKruiger e1422c6443 Fix broken link 5 years ago
Brian Kung 9b92aa08ae Adds a simple exercise for structures 5 years ago
bors 8bf8cbbd61 Auto merge of #162 - c-rustacean:rustfmt-and-ws-fixes, r=komaeda
errorsn.rs: Separate also the hints from each other to avoid accidental viewing
5 years ago
Eddy Petrisor f507844102 errorsn.rs: Separate also the hints from each other to avoid accidental viewing
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
5 years ago
bors fffbb60ed9 Auto merge of #161 - c-rustacean:rustfmt-and-ws-fixes, r=komaeda
Rustfmt and ws fixes
5 years ago
Eddy Petrisor 9aec4abc4d rustfmt the exercises
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
5 years ago
Eddy Petrisor a53b3f199f iterator3.rs: whitespace fixes
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
5 years ago
Eddy Petrisor d6d696b66a errorsn.rs: Separate hints from code, so hints are not accidentally seen
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
5 years ago
Julien Bisconti 187d2ad226
Update errors1.rs
Add Result type signature as it is difficult for new comers to understand Generics and Error all at once
5 years ago
Yvan Sraka a71bc62c29
Add errors to exercises that compile without user changes 5 years ago
Diod FR d7e58ee1af
Fix links by deleting book version 5 years ago
zacanger c5a374fbf2
Fix permissions on source files 5 years ago
Kyle Isom c1f4257a91 errors2.rs: update link to Rust book. 5 years ago
liv 02ceb0ba8c fix test command execution
seems like i forgot that you actually need to run executables created
with `rustc --test`! this also reworks the "test1" exercise a bit

closes #108
5 years ago
Jean-Philippe Moresmau 4e3bd8d51b Renamed readme files properly 6 years ago
Jean-Philippe Moresmau 3073ff3f82 Renamed readme files properly 6 years ago
liv 05f65d67ae thematically refactor modules2 6 years ago
liv a49a22071a redo the section readmes 6 years ago
liv dc1f3b79f8 add tests; refactor exercise links 6 years ago
liv 17e12433cb add a test 6 years ago
liv b90f642029 remove the ex*.rs files 6 years ago
delet0r b0c9b33978 Changed Rust Book versions in links to 2018
Forgot to add changes to last commit.
6 years ago
delet0r 0973e60056 Created sub READMEs for CLI only version
Sub READMEs contain the relevant resources from the main
README of the web version. All second edition Rust Book links
were updated to the 2018 edition.

Fixed to typos in main README.md.
6 years ago
olivia f7846af7ac right let's try this one again 6 years ago