Commit Graph

1188 Commits (3e7e65b9f0e6e9a2f8ddd55f8403a5e3c2c852da)
 

Author SHA1 Message Date
marisa 9b9a89c79a
Merge pull request #668 from cseltol/main
fix(installation): first PowerShell command
3 years ago
marisa 123e6426d1
Merge pull request #789 from kolbma/exercise-clippy1-hint-390
chore: clippy1 hint enhancement
3 years ago
marisa 427ec6b2e4
Merge pull request #790 from rust-lang/all-contributors/add-jazzplato
docs: add jazzplato as a contributor for code
3 years ago
allcontributors[bot] 03dcb582e6
docs: update .all-contributorsrc [skip ci] 3 years ago
allcontributors[bot] 1043a06124
docs: update README.md [skip ci] 3 years ago
Richthofen d20e413a68
feat(cli): Add "next" to run the next unsolved exercise. (#785)
* Add "run next" to run the next unsolved exercise.

* Fix a grammar error in the message.

* Update README.md with the suggested change

Co-authored-by: marisa <mokou@fastmail.com>

* Update the README.md for "rustlings hint next".

Co-authored-by: marisa <mokou@fastmail.com>
3 years ago
arlecchino 9bf4c5e8df
chore: clippy1 hint enhancement
Added some explanation and links about floating point representation and to use the clippy suggestion. (fixes #390)
3 years ago
marisa 633303d4b8
Merge pull request #787 from kolbma/exercise-iterator3-hint
chore: Update hint of iterators3
3 years ago
arlecchino a4a1098766
Update info.toml
Co-authored-by: marisa <mokou@fastmail.com>
3 years ago
marisa 0bd459dcac
Merge pull request #788 from rust-lang/all-contributors/add-kolbma
docs: add kolbma as a contributor for doc
3 years ago
allcontributors[bot] 3b4514b686
docs: update .all-contributorsrc [skip ci] 3 years ago
allcontributors[bot] 2e05606edc
docs: update README.md [skip ci] 3 years ago
marisa c8c1b87a01
Merge pull request #786 from kolbma/git-clone-release-tag
docs: Faster git clone command
3 years ago
arlecchino 34ea029df8
chore: Update hint of iterators3
`collect()` needs some hint for standard_library_types/iterators3 exercise with doc link for understanding different return types via `FromIterator`.
3 years ago
arlecchino 3a4433d5a2
docs: Faster git clone command
Clone only release tag without history
3 years ago
Taylor Yu 2dc93cadda fix(from_str, try_from_into): custom error types
Remove the use of trait objects as errors from `from_str` and
`try_from_into`; they seem to have caused a lot of confusion in
practice. (Also, it's considered best practice to use custom error
types instead of boxed errors in library code.) Instead, use custom
error enums, and update hints accordingly. Hints also provide
some guidance about converting errors, which could be covered
more completely in a future advanced errors section.

Also move from_str to directly after the similar exercise `from_into`,
for the sake of familiarity when solving.
3 years ago
marisa de6c45ad24
Merge pull request #779 from rust-lang/all-contributors/add-hyperparabolic
docs: add hyperparabolic as a contributor for code
3 years ago
allcontributors[bot] fadade8592
docs: update .all-contributorsrc [skip ci] 3 years ago
allcontributors[bot] d91044f3a2
docs: update README.md [skip ci] 3 years ago
marisa a3ea37b76e
Merge pull request #771 from tlyu/iterators5-trait-tweak
fix(iterators5): derive Clone, Copy
3 years ago
marisa ec63cadadb
Merge pull request #772 from tlyu/errors-rework
feature: improve error_handling exercises
3 years ago
marisa 84d8305730
Merge pull request #778 from rust-lang/all-contributors/add-kayuapi
docs: add kayuapi as a contributor for content
3 years ago
allcontributors[bot] 73777980f1
docs: update .all-contributorsrc [skip ci] 3 years ago
allcontributors[bot] 75788b1148
docs: update README.md [skip ci] 3 years ago
marisa dd9b2ddc89
Merge pull request #773 from kayuapi/patch-1
fix(variables5): confine the answer further
3 years ago
Taylor Yu b7ddd09fab address review feedback
Adjust error text and naming to conform with best practices.
Use `map_err()` instead of `or()`. Wrap lower-level errors instead of
ignoring their details.

Also, don't "cheat" by bypassing the `new()` function in tests.

Fix a dangling reference in the try_from_into hints.
3 years ago
ZC 48ffcbd2c4
fix(variables5): confine the answer further
let mut number = 3; can lead to a correct answer, so the comment helps to direct the users to the intended answer.
3 years ago
Taylor Yu 68d3ac567c feature: improve error_handling exercises
Add new exercises errors5 and errors6, to introduce boxed errors and
custom error enums more gently. Delete errorsn, because it tried to do
too much too soon.
3 years ago
Taylor Yu 50ab289da6 fix: rename result1 to errors4
Also put it in the ERROR HANDLING section where it probably belongs.
3 years ago
Taylor Yu 4e079fdd08 chore(iterators5): conciseness hint 3 years ago
Taylor Yu 91fc9e3118 fix(iterators5): derive Clone, Copy
To allow more flexibility in solutions, derive `Clone` and `Copy`
for `Progress`.
3 years ago
marisa a2f0401c4c
Merge pull request #762 from tlyu/move-semantics5-fixes
fix: move_semantics5 hints
3 years ago
Taylor Yu 1b85828548 fix: move_semantics5 hints
Improve the hints for move_semantics5, as well as the explanatory
comments in the code.

Previously, it was not clear what possible changes were allowed.
It seems that reordering the statements might be the intended solution.
The previous comment about not "adding newlines" doesn't make sense,
so treating it as "adding new lines" makes it more clear.
3 years ago
Taylor Yu 4c46e5e1a3 chore: minor typos in move_semantics5 hints 3 years ago
marisa 4da9e7ee29
Merge pull request #758 from rust-lang/all-contributors/add-sateeshkumarb
docs: add sateeshkumarb as a contributor
3 years ago
allcontributors[bot] 72e615aa7a
docs: update .all-contributorsrc [skip ci] 3 years ago
allcontributors[bot] cd02abc481
docs: update README.md [skip ci] 3 years ago
Sateesh 399ab328d8
feat: Add move_semantics5 exercise. (#746)
* feat: Add move_semantics5 exercise.

* feat: Add option3 exercise

* Address review comments. Fix typos, sentence formatting.

* Remove unwanted newline.

* Address review comments: make comment inline, fix format in print.
3 years ago
marisa 809ec2ce01
Merge pull request #755 from tlyu/dyn-error-hints
fix(try_from_into, from_str): hints for dyn Error
3 years ago
Taylor Yu 11d2cf0d60 fix(try_from_into, from_str): hints for dyn Error
Add hints about how to return the correct type for functions that
return `Result<_, Box<dyn Error>`. Some feedback from Discord suggests
that people run into trouble with that.
3 years ago
marisa dbb2624403
Merge pull request #751 from juanprq/main
fix: remove trailing whitespace
3 years ago
Juan Pablo Ramirez 4d4fa77459 fix: remove trailing whitespaces from iterators1 3 years ago
Juan Pablo Ramirez 3145794084 fix: add hints to generics1 and generics2 exercises 3 years ago
Juan Pablo Ramirez d9b69bd1a0 fix: remove trailing whitespace 3 years ago
marisa 7cd635fa84
Merge pull request #740 from rust-lang/all-contributors/add-PiDelport
docs: add PiDelport as a contributor
3 years ago
allcontributors[bot] ce40e201f0
docs: update .all-contributorsrc [skip ci] 3 years ago
allcontributors[bot] 404f3ef465
docs: update README.md [skip ci] 3 years ago
marisa e1be594fdd
Merge pull request #739 from PiDelport/patch-1
style(standard_library_types): stray line break
3 years ago
Pi Delport 9569c9a9e7
style(standard_library_types): stray line break 3 years ago
apogeeoak f78c480208 fix(cli): Move long text strings into constants. 3 years ago