1822 Commits (30291a3c253f08a4191cfd544ba36867612ebb7a)

 

All Branches   

Search

Author	SHA1	Message	Date
liv	f2c48cfac5	fix the --nocapture functionality	5 years ago
liv	6ae0a00211	1.2.0	5 years ago
liv	bfcf38c8bc	damn it	5 years ago
liv	9e328da641	use -- --nocapture when testing	5 years ago
bors	e336d04c79	Auto merge of #144 - yvan-sraka:patch-0, r=komaeda ... Add errors to exercises that compile without user changes Hi ! I played a bit with rustlings, and I felt that some exercises were incorrect because they passed the tests without me needing to edit the files! This gave me the feeling that the exercise was skiped! Especially when I use `rustlings watch`, it is easy to miss an exercise because the compilation error that is displayed is the one of the next exercise ... It is easy to identify "broken" exercises with: ```bash % find exercises -name "*.rs" | xargs -n 1 rustlings run ... ✅ Successfully ran exercises/move_semantics/move_semantics4.rs ✅ Successfully tested exercises/test2.rs ``` My suggestion is to make sure that these files trigger a compilation error by adding a simple syntax error (e.g. with `???` in the code that must change) so that our Rustacean can then play with it!	5 years ago
Yvan Sraka	a71bc62c29	Add errors to exercises that compile without user changes	5 years ago
liv	4b0b7093e5	1.1.1	5 years ago
bors	8387de64d3	Auto merge of #143 - cjpearce:fix-exercise-path-matching, r=komaeda ... Canonicalize paths to fix path matching This PR should fix #126. The main solution to the issue was using `canonicalize()` on the paths we create for the exercises from `info.toml` and any user-specified paths, so that path `ends_with` matching will work correctly. As adding calls to the canonicalize function everywhere requires unwrapping, I also decided to extract a struct representing an exercise and use serde to deserialize the paths from the `info.toml` file up front. I also tried to move the path handling out into the `exercise.rs` file and down into `main.rs` so that it doesn't create as much clutter. There was already a lot of unwrapping and path handling in the other files and I felt like it was getting a bit too repetitive. If the approach is going too far (too many changes etc.) I'm happy to try to produce a smaller PR that fixes the bug without any refactoring.	5 years ago
Chris Pearce	77de6e5d6a	Clean up test includes for File and Path	5 years ago
Chris Pearce	8c867a001a	Remove unwrap on canonicalize result	5 years ago
Chris Pearce	d01a71f7de	Extract exercise struct to encapsulate path logic	5 years ago
bors	04d1d4c00e	Auto merge of #142 - diodfr:patch-1, r=komaeda ... Fix links by deleting book version	5 years ago
Diod FR	d7e58ee1af	Fix links by deleting book version	5 years ago
bors	ffb165ce26	Auto merge of #140 - cjpearce:fix/test-race-condition, r=komaeda ... Fix intermittent test failure caused by race condition First public pull request 😬 There's an intermittent integration test failure when you use multiple test threads (at least for me on a mac). I narrowed it down to two tests each spawning a process using `Command` which then try to compile the same file at the same time. If the timing doesn't work out, they both try to compile, and then one process runs `clean` before the other can run the executable - causing a panic.  You can prevent it from happening by running with a single thread (`cargo test -- --test-threads=1`), because the `Command` blocks. That's not a particularly good solution though because it's not something you can configure in `Cargo.toml`. I considered making the affected tests just run serially, but it occurred to me that this could also happen if someone accidentally runs rustlings in watch mode in two terminals without realising it. I wound't consider this that unlikely given it's a tool for learning. I fixed it by ensuring that the executables made from separate processes don't conflict by appending a process id to the output executable name. I also extracted the commands into a single file next to `clean` so that we don't have to repeat the generated file name everywhere and risk missing something.	5 years ago
Chris Pearce	65cb09eb2e	Update ci test command to allow multithreaded tests	5 years ago
bors	78552ebd7a	Auto merge of #141 - cjpearce:fix/run-panics-on-compile-fail, r=komaeda ... Stop run from panicking when compile fails Currently if you use the `rustlings run` command and your program fails to compile, rustlings will panic while trying to exit. First I've added a couple of integration tests to cover this case, which also meant moving a few tests so that the new fixtures didn't cause `verify_all_success` to fail. Then I noticed that the existing integration tests that test for failure pass even when rustlings panics, preventing the new tests from failing. I've updated the integration tests to distinguish between when rustlings has failed in the way that we want (exit code 1) rather than a panic (exit code 101). Finally I fixed the actual panic, which was just caused by unwrapping when rustlings should probably be exiting cleanly.	5 years ago
Chris Pearce	0c7bd12372	Fix test failing due to panic	5 years ago
Chris Pearce	3d11d7685b	Modify integration tests to fail on panic	5 years ago
Chris Pearce	592ae6b4d2	Add process id to temp file name	5 years ago
Chris Pearce	4fa79ee02f	Extract command builders into util	5 years ago
bors	fbd0ccbd5b	Auto merge of #134 - rust-lang:fix/windows-paths, r=komaeda ... fix watch command path execution @hades32 @guttume could you test whether this works on windows by checking out the branch locally and running `cargo run watch`?	5 years ago
komaeda	8c008a0e7d	Merge pull request #137 from mgeier/patch-1 ... Fix order of true/false in tests for executables	5 years ago
Matthias Geier	11fe19d08a	Fix order of true/false in tests for executables ... 1b3469f236 has fixed the tests themselves, but now the original error shows itself.	5 years ago
liv	1b3469f236	make installation command checks more thorough	5 years ago
liv	022921168d	fix watch command path execution	5 years ago
komaeda	c6765eb3eb	Merge pull request #133 from zacanger/bug/permissions ... Fix permissions on exercise files	5 years ago
zacanger	c5a374fbf2	Fix permissions on source files	5 years ago
lyn	f3ee70489f	1.1.0	5 years ago
lyn	6a27ba735c	cargo fmt	5 years ago
komaeda	91dce31265	Merge pull request #131 from ColinPitrat/master ... Verify that rust version is recent enough to install rustlings.	5 years ago
lyn	040ca18a64	add travis config	5 years ago
lyn	f43cb124f6	add tests	5 years ago
komaeda	11875aed6e	adjust author name	5 years ago
Colin Pitrat	f07703eb7a	Fix comment position	5 years ago
Colin Pitrat	fd4eda8bda	Verify that rust version is recent enough to install rustlings. ... I would have liked to write some tests for the vercomp function I introduce, but there doesn't seem to be any CI setup yet?	5 years ago
komaeda	bf8d927ab2	Merge pull request #123 from kisom/master ... Be nicer when rustlings isn't run from the right directory.	5 years ago
Kyle Isom	9fc4a83987	Be nicer when rustlings isn't run from the right directory. ... Before, rustlings would panic if it wasn't in the right directory. It took me a minute to figure out why, and this wasn't my first intro to Rust. It would probably help new users if they saw a helpful message instead of a stack trace.	5 years ago
komaeda	63280ed9e4	Merge pull request #119 from LesnyRumcajs/patch-1 ... Add standard library types to exercises suite	5 years ago
komaeda	25f9d61410	Merge pull request #124 from kisom/update-link ... errors2.rs: update link to Rust book.	5 years ago
Kyle Isom	c1f4257a91	errors2.rs: update link to Rust book.	5 years ago
komaeda	8f9d7ce3d8	Merge pull request #120 from abagshaw/master ... Start verification at most recently modified file	5 years ago
Andrew Bagshaw	3b5dfac44e	Remove unnessecary whitespace	5 years ago
Andrew Bagshaw	a6a8b61b12	Change to \n	5 years ago
Andrew Bagshaw	6cd42bb821	Add clear break between verify executions	5 years ago
Andrew Bagshaw	4d7ce6e571	deduplicate	5 years ago
Andrew Bagshaw	3f114cc069	Start verification at most recently modified file	5 years ago
LesnyRumcajs	58ccd72aff	Add standard library types to exercises suite	5 years ago
lyn	abf175111d	clippy-ify	5 years ago
lyn	9144c816bf	remove obsolete paragraph on `--test` flag	5 years ago
lyn	999601d828	1.0.1	5 years ago