Commit Graph

99 Commits

Author SHA1 Message Date
Nicolas Perriault
4424b0bad7 Refs #128 - Add support for options to Readability constructor. r=@gijsk 2015-04-09 11:56:58 +02:00
Gijs Kruitbosch
c53ca31907 Fixed test result output being sent at once 2015-04-08 15:24:34 +01:00
Nicolas Perriault
4d41f5e4ed Refs #117 - Drop social/share buttons. 2015-04-07 23:00:52 +02:00
Nicolas Perriault
d725ebc953 Fixes #99: JSDOMParser tag name case handling. r=@gijsk 2015-04-07 14:19:54 +02:00
Gijs Kruitbosch
a04f9d9a68 Fix embedded video testcase to work with both jsdom and JSDOMParser 2015-04-03 22:42:29 +01:00
Gijs Kruitbosch
225adef137 Turn off JS when using JSDOM in tests. 2015-04-03 22:42:29 +01:00
Gijs Kruitbosch
b1f6c62b25 Fix tests for readability to also work with jsdom
For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this.

Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-04-03 22:41:55 +01:00
Gijs Kruitbosch
62801faa0e Fix JSDOMParser to do some HTML escaping and identify as JSDOMParser + add tests 2015-04-03 22:32:06 +01:00
Nicolas Perriault
3b636b59f0 Added readerable value to test pages metadata. 2015-04-03 15:14:49 +02:00
Margaret Leibovic
6b7834f798 add test for isProbablyReaderable 2015-04-02 17:40:06 -04:00
Nicolas Perriault
2bfa678cab Added separate command for reference benchmark. 2015-04-01 22:35:06 +01:00
Nicolas Perriault
1e14d47bb7 Added benchmarks. 2015-04-01 21:58:42 +02:00
Gijs
f2b04930c1 Merge pull request #87 from gijsk/script-parsing-should-deal-with-comments
Fix script parsing to ignore closing tags in comments
2015-04-01 11:45:03 +01:00
Gijs Kruitbosch
8ddba60425 Fix script parsing to ignore closing tags in comments 2015-04-01 11:12:16 +01:00
Nicolas Perriault
f8d37e4276 Don't remove elements containing figures or having them as a parent. 2015-03-31 19:12:45 +02:00
Nicolas Perriault
b6730703a1 Fixes #81 - Keep article images. 2015-03-31 18:46:04 +02:00
Gijs Kruitbosch
cdcbd94cd5 Add tests for the lifehacker page 2015-03-30 20:52:05 +02:00
Gijs
194a5376c8 Merge pull request #63 from mozilla/preserve-embedded-tweets
Preserve inline tweets as they're part of article contents.
2015-03-25 13:57:34 +00:00
Nicolas Perriault
aeeabb7c79 Print exception stack when generating a test case fails. 2015-03-23 15:59:06 +01:00
Gijs
14b33b69db Merge pull request #65 from mozilla/support-embed-videos
Fixes #56 - Updated support for embedded Youtube & Vimeo videos.
2015-03-23 14:48:00 +00:00
Nicolas Perriault
ad52d8ee30 Fixes #53 - Fixed dot-slash relative URI resolution. 2015-03-23 12:54:46 +01:00
Nicolas Perriault
2d5f59f3eb Fixes #56 - Updated support for embedded Youtube & Vimeo videos. 2015-03-23 10:07:04 +01:00
Nicolas Perriault
d83763c8a1 Preserve inline tweets as they're part of article contents. 2015-03-22 18:19:34 +01:00
Nicolas Perriault
cf3dce6cf2 Refs #58 - Stripped embed tags. 2015-03-22 17:52:23 +01:00
Nicolas Perriault
eee224560b Addressed review comments from @Gijsk. 2015-03-21 18:05:58 +01:00
Nicolas Perriault
4f9615cb9a Use forEach when it makes sense. 2015-03-21 15:10:00 +01:00
Gijs Kruitbosch
14afc21b96 Fix code to ignore titles when we already have one. 2015-03-20 20:34:12 -07:00
Gijs Kruitbosch
a924e31729 Add testcase for current Medium behaviour including SVG that desktop sees. 2015-03-20 20:20:45 -07:00
Gijs Kruitbosch
955951659d Bug 1143725 - fix the Herald Sun website 2015-03-20 17:49:42 -07:00
Gijs Kruitbosch
f9e770ad3b Write a bunch of tests for jsdomparser 2015-03-20 10:32:28 -07:00
Margaret Leibovic
d0df9d8479 Merge pull request #40 from leibovic/byline
Improve byline algorithm. r=Gijs
2015-03-20 09:18:57 -07:00
Margaret Leibovic
3c2d93cd09 Improve byline algorithm 2015-03-20 09:16:28 -07:00
Nicolas Perriault
f4670a1531 Better test docs. 2015-03-20 16:42:18 +01:00
Nicolas Perriault
df02218905 More detailed test reports. 2015-03-20 11:28:10 +01:00
Gijs Kruitbosch
2b09db3300 Improve logging for errors in test runs, add a way to run just some tests (using an env var because mocha doesn't support passing arguments) 2015-03-19 18:29:08 -07:00
Margaret Leibovic
639c878af5 Generate expected-metadata.json in generate-testcase.js 2015-03-19 14:47:36 -07:00
Margaret Leibovic
1b5d896b8b Add expected-metadata.json for existing tests 2015-03-19 14:39:50 -07:00
Margaret Leibovic
6490d7205d Update test to check metadata 2015-03-19 14:39:50 -07:00
Gijs Kruitbosch
5efddf6620 Update all the tests, add a bunch of random things so we have some base idea of what stuff we're breaking when changing things. 2015-03-19 10:10:50 -07:00
Gijs Kruitbosch
1c42f29aa5 Create a script to generate testcases, actually use our version of JSDOMParser 2015-03-19 10:10:42 -07:00
Nicolas Perriault
fac76c6c1a Added support for readability log messages forwarding to node. 2015-03-18 19:39:13 +01:00
Nicolas Perriault
7da6e82fec Switched to using jsdom for tests. 2015-03-18 18:49:36 +01:00
Gijs Kruitbosch
1d2df4a70e Bug 1144441 - avoid leaving out paragraphs 2015-03-17 18:18:44 -07:00
Margaret Leibovic
03d9e36161 Merge pull request #22 from gijsk/fix-empty-classes
Don't create/leave empty class attributes around all the nodes we're using. r=margaret
2015-03-17 15:01:44 -07:00
Nicolas Perriault
99f338a03a Added logging to test output. 2015-03-17 22:42:59 +01:00
Gijs Kruitbosch
b62fd27ba6 Don't create/leave empty class attributes around all the nodes we're using. 2015-03-17 13:17:49 -07:00
Gijs Kruitbosch
aebd13b12b Bug 1127778 - fix Readability test suite to always use its own copy so travis build passes 2015-03-17 12:49:48 -07:00
Gijs Kruitbosch
3c277a1701 Bug 1127778 - fix paragraph reordering and add a test for it. 2015-03-17 12:01:45 -07:00
Nicolas Perriault
3bef3e7029 Added basic functional test + travis setup. 2015-03-16 15:12:10 +01:00