From 62fae22849d7837ea00fdce1158f6e64e1d519b3 Mon Sep 17 00:00:00 2001 From: Nicolas Perriault Date: Mon, 23 Mar 2015 11:56:04 +0100 Subject: [PATCH] Closes #66 - Keep tabular data as they're most likely to be part of content. --- Readability.js | 1 - .../keep-tabular-data/expected-metadata.json | 5 + .../keep-tabular-data/expected.html | 90 ++++++++++++++++++ test/test-pages/keep-tabular-data/source.html | 95 +++++++++++++++++++ 4 files changed, 190 insertions(+), 1 deletion(-) create mode 100644 test/test-pages/keep-tabular-data/expected-metadata.json create mode 100644 test/test-pages/keep-tabular-data/expected.html create mode 100644 test/test-pages/keep-tabular-data/source.html diff --git a/Readability.js b/Readability.js index d532977..b927051 100644 --- a/Readability.js +++ b/Readability.js @@ -357,7 +357,6 @@ Readability.prototype = { // Do these last as the previous stuff may have removed junk // that will affect these - this._cleanConditionally(articleContent, "table"); this._cleanConditionally(articleContent, "ul"); this._cleanConditionally(articleContent, "div"); diff --git a/test/test-pages/keep-tabular-data/expected-metadata.json b/test/test-pages/keep-tabular-data/expected-metadata.json new file mode 100644 index 0000000..d0115d6 --- /dev/null +++ b/test/test-pages/keep-tabular-data/expected-metadata.json @@ -0,0 +1,5 @@ +{ + "title": "Keep tabular data test", + "byline": null, + "excerpt": "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod\n tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,\n quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo\n consequat." +} diff --git a/test/test-pages/keep-tabular-data/expected.html b/test/test-pages/keep-tabular-data/expected.html new file mode 100644 index 0000000..f6184b1 --- /dev/null +++ b/test/test-pages/keep-tabular-data/expected.html @@ -0,0 +1,90 @@ +
+
+

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod + tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, + quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo + consequat.

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
World + Africa + Asia + Europe + North America + Oceania + South America +
Theora55%64%58%62%42%49%66%
WebM51%55%52%57%38%45%62%
H.26445%38%42%44%47%50%53%
No <video> + 28%27%32%21%32%25%25%
Unknown0%0%0%0%0%0%0%
+

Duis aute irure dolor in reprehenderit in voluptate velit esse cillum + dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non + proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

+
+

Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, + quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo + consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse + cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat + non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

+
\ No newline at end of file diff --git a/test/test-pages/keep-tabular-data/source.html b/test/test-pages/keep-tabular-data/source.html new file mode 100644 index 0000000..02d222a --- /dev/null +++ b/test/test-pages/keep-tabular-data/source.html @@ -0,0 +1,95 @@ + + + + + Keep tabular data test + + +
+

Lorem

+
+

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod + tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, + quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo + consequat.

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
WorldAfricaAsiaEuropeNorth AmericaOceaniaSouth America
Theora55%64%58%62%42%49%66%
WebM51%55%52%57%38%45%62%
H.26445%38%42%44%47%50%53%
No <video>28%27%32%21%32%25%25%
Unknown0%0%0%0%0%0%0%
+

Duis aute irure dolor in reprehenderit in voluptate velit esse + cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non + proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

+
+

Foo

+
+ Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, + quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo + consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse + cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non + proident, sunt in culpa qui officia deserunt mollit anim id est laborum. +
+
+ +