Archives/readability
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert removing ids from elements

Browse Source
This commit is contained in:
Gijs Kruitbosch 2017-11-29 13:48:44 +00:00 committed by Gijs
parent eb895b97a2
commit 092a8aeaff
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Readability.js
View File

@ -124,8 +124,7 @@ Readability.prototype = {
DEPRECATED_SIZE_ATTRIBUTE_ELEMS: [ "TABLE", "TH", "TD", "HR", "PRE" ], DEPRECATED_SIZE_ATTRIBUTE_ELEMS: [ "TABLE", "TH", "TD", "HR", "PRE" ],
// These are the IDs and classes that readability sets itself. // These are the classes that readability sets itself.
IDS_TO_PRESERVE: [ "readability-content", "readability-page-1" ],
CLASSES_TO_PRESERVE: [ "readability-styled", "page" ], CLASSES_TO_PRESERVE: [ "readability-styled", "page" ],
/** /**
@ -138,8 +137,8 @@ Readability.prototype = {
// Readability cannot open relative uris so we convert them to absolute uris. // Readability cannot open relative uris so we convert them to absolute uris.
this._fixRelativeUris(articleContent); this._fixRelativeUris(articleContent);
// Remove IDs and classes. // Remove classes.
this._cleanIDsAndClasses(articleContent); this._cleanClasses(articleContent);
}, },
/** /**
@ -234,18 +233,14 @@ Readability.prototype = {
}, },
/** /**
* Removes the id="" and class="" attribute from every element in the given * Removes the class="" attribute from every element in the given
* subtree, except those that match IDS_TO_PRESERVE, CLASSES_TO_PRESERVE and * subtree, except those that match CLASSES_TO_PRESERVE and
* the classesToPreserve array from the options object. * the classesToPreserve array from the options object.
* *
* @param Element * @param Element
* @return void * @return void
*/ */
_cleanIDsAndClasses: function(node) { _cleanClasses: function(node) {
if (this.IDS_TO_PRESERVE.indexOf(node.id) == -1) {
node.removeAttribute("id");
}
var classesToPreserve = this._classesToPreserve; var classesToPreserve = this._classesToPreserve;
var className = node.className var className = node.className
.split(/\s+/) .split(/\s+/)
@ -261,7 +256,7 @@ Readability.prototype = {
} }
for (node = node.firstElementChild; node; node = node.nextElementSibling) { for (node = node.firstElementChild; node; node = node.nextElementSibling) {
this._cleanIDsAndClasses(node); this._cleanClasses(node);
} }
}, },