Archives/readability
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
79aa2fca87
readability/test/test-readability.js

129 lines
4.1 KiB
JavaScript
Raw Normal View History

Fixes #130 - Using js-beautify for HTML formatting.
2015-04-21 08:26:15 +00:00
var prettyPrint = require("./utils").prettyPrint;
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
var jsdom = require("jsdom").jsdom;
Improve logging for errors in test runs, add a way to run just some tests (using an env var because mocha doesn't support passing arguments)
2015-03-20 00:01:31 +00:00
var chai = require("chai");
chai.config.includeStack = true;
var expect = chai.expect;
Added basic functional test + travis setup.
2015-03-13 16:19:15 +00:00
Added readerable value to test pages metadata.
2015-04-03 10:29:05 +00:00
var readability = require("../index");
Added benchmarks.
2015-04-01 19:56:08 +00:00
var Readability = readability.Readability;
var JSDOMParser = readability.JSDOMParser;
Create a script to generate testcases, actually use our version of JSDOMParser
2015-03-19 02:44:47 +00:00
Fixes #130 - Using js-beautify for HTML formatting.
2015-04-21 08:26:15 +00:00
var testPages = require("./utils").getTestPages();
Added basic functional test + travis setup.
2015-03-13 16:19:15 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
function runTestsWithItems(label, beforeFn, expectedContent, expectedMetadata) {
describe(label, function() {
Fixes #130 - Using js-beautify for HTML formatting.
2015-04-21 08:26:15 +00:00
this.timeout(5000);
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
var result;
Fixes #130 - Using js-beautify for HTML formatting.
2015-04-21 08:26:15 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
before(function() {
result = beforeFn();
});
add test for isProbablyReaderable
2015-04-02 21:35:57 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
it("should return a result object", function() {
expect(result).to.include.keys("content", "title", "excerpt", "byline");
});
add test for isProbablyReaderable
2015-04-02 21:35:57 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
it("should extract expected content", function() {
Fixes #163 - Avoid including footer tag contents.
2015-04-17 15:33:04 +00:00
expect(expectedContent.split("\n")).eql(prettyPrint(result.content).split("\n"));
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
});
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
it("should extract expected title", function() {
expect(expectedMetadata.title).eql(result.title);
});
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
it("should extract expected byline", function() {
expect(expectedMetadata.byline).eql(result.byline);
});
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
it("should extract expected excerpt", function() {
expect(expectedMetadata.excerpt).eql(result.excerpt);
});
it("should probably be readerable", function() {
expect(expectedMetadata.readerable).eql(result.readerable);
});
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
});
}
function removeCommentNodesRecursively(node) {
[].forEach.call(node.childNodes, function(child) {
if (child.nodeType === child.COMMENT_NODE) {
node.removeChild(child);
} else if (child.nodeType === child.ELEMENT_NODE) {
removeCommentNodesRecursively(child);
}
});
}
add test for isProbablyReaderable
2015-04-02 21:35:57 +00:00
Refs #128 - Add support for options to Readability constructor. r=@gijsk
2015-04-08 17:49:33 +00:00
describe("Readability API", function() {
describe("#constructor", function() {
it("should accept a debug option", function() {
expect(new Readability({}, {})._debug).eql(false);
expect(new Readability({}, {}, {debug: true})._debug).eql(true);
});
it("should accept a nbTopCandidates option", function() {
expect(new Readability({}, {})._nbTopCandidates).eql(5);
expect(new Readability({}, {}, {nbTopCandidates: 42})._nbTopCandidates).eql(42);
});
it("should accept a maxPages option", function() {
expect(new Readability({}, {})._maxPages).eql(5);
expect(new Readability({}, {}, {maxPages: 42})._maxPages).eql(42);
});
it("should accept a maxElemsToParse option", function() {
expect(new Readability({}, {})._maxElemsToParse).eql(0);
expect(new Readability({}, {}, {maxElemsToParse: 42})._maxElemsToParse).eql(42);
});
});
describe("#parse", function() {
it("shouldn't parse oversized documents as per configuration", function() {
var doc = new JSDOMParser().parse("<html><div>yo</div></html>");
expect(function() {
new Readability({}, doc, {maxElemsToParse: 1}).parse();
}).to.Throw("Aborting parsing document; 2 elements found");
});
});
});
describe("Test pages", function() {
Added basic functional test + travis setup.
2015-03-13 16:19:15 +00:00
testPages.forEach(function(testPage) {
describe(testPage.dir, function() {
More detailed test reports.
2015-03-20 10:20:49 +00:00
var uri = {
spec: "http://fakehost/test/page.html",
host: "fakehost",
prePath: "http://fakehost",
scheme: "http",
Fixes #53 - Fixed dot-slash relative URI resolution.
2015-03-23 11:54:46 +00:00
pathBase: "http://fakehost/test/"
More detailed test reports.
2015-03-20 10:20:49 +00:00
};
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
runTestsWithItems("jsdom", function() {
Turn off JS when using JSDOM in tests.
2015-04-02 17:12:12 +00:00
var doc = jsdom(testPage.source, {
features: {
FetchExternalResources: false,
ProcessExternalResources: false
}
});
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
removeCommentNodesRecursively(doc);
var readability = new Readability(uri, doc);
var readerable = readability.isProbablyReaderable();
var result = readability.parse();
result.readerable = readerable;
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
return result;
}, testPage.expectedContent, testPage.expectedMetadata);
More detailed test reports.
2015-03-20 10:20:49 +00:00
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
runTestsWithItems("JSDOMParser", function() {
Fix tests for readability to also work with jsdom For instance, jsdom's more spec-compliant parsing causes issues with auto-closing elements (lifehacker article) and with not having self-closing <img> and <br> tags. The former was fixed by removing offending markup, the latter by adjusting JSDOMParser to be more sane, and the expected outputs to cope with this. Finally, JSDOMParser automatically drops comments. The test code needed to manually do this in the jsdom case.
2015-03-25 13:53:12 +00:00
var doc = new JSDOMParser().parse(testPage.source);
var readability = new Readability(uri, doc);
var readerable = readability.isProbablyReaderable();
var result = readability.parse();
result.readerable = readerable;
Fixed test result output being sent at once
2015-04-08 14:24:34 +00:00
return result;
}, testPage.expectedContent, testPage.expectedMetadata);
Added basic functional test + travis setup.
2015-03-13 16:19:15 +00:00
});
Bug 1127778 - fix Readability test suite to always use its own copy so travis build passes
2015-03-17 19:08:41 +00:00
});
Added basic functional test + travis setup.
2015-03-13 16:19:15 +00:00
});
Reference in New Issue Copy Permalink