From 99ea3a6989ce6c70a1dd3891cd7f24e843310f39 Mon Sep 17 00:00:00 2001
From: Bruno Pinto <brunoferreirapinto@gmail.com>
Date: Tue, 20 Jan 2015 22:10:39 -0200
Subject: [PATCH] simplifying expect tests

---
 .../spec/expect.to_be_false.spec.fish         | 24 +++++-----
 .../spec/expect.to_be_true.spec.fish          | 24 +++++-----
 .../spec/expect.to_contain_all.spec.fish      | 44 +++++++------------
 .../fish-spec/spec/expect.to_equal.spec.fish  | 24 ++++------
 .../spec/expect.to_not_contain_all.spec.fish  | 44 ++++++++++---------
 5 files changed, 72 insertions(+), 88 deletions(-)

diff --git a/plugins/fish-spec/spec/expect.to_be_false.spec.fish b/plugins/fish-spec/spec/expect.to_be_false.spec.fish
index 5d5681a..b3d07c7 100644
--- a/plugins/fish-spec/spec/expect.to_be_false.spec.fish
+++ b/plugins/fish-spec/spec/expect.to_be_false.spec.fish
@@ -1,28 +1,28 @@
 import plugins/fish-spec
 
 function describe_expect_to_be_false
-  function before_each
-    set -e result
-  end
-
   function it_returns_1_when_evaluated_value_is_0
-    echo (expect true --to-be-false; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect true --to-be-false
+
+    expect $status --to-equal 1
   end
 
   function it_returns_0_when_evaluated_value_is_1
-    echo (expect false --to-be-false; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect false --to-be-false
+
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_evaluated_function_returns_0
-    echo (expect "eval true" --to-be-false; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect "eval true" --to-be-false
+
+    expect $status --to-equal 1
   end
 
   function it_returns_0_when_evaluated_function_returns_1
-    echo (expect "eval false" --to-be-false; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect "eval false" --to-be-false
+
+    expect $status --to-equal 0
   end
 end
 
diff --git a/plugins/fish-spec/spec/expect.to_be_true.spec.fish b/plugins/fish-spec/spec/expect.to_be_true.spec.fish
index 7096062..3d2b7c9 100644
--- a/plugins/fish-spec/spec/expect.to_be_true.spec.fish
+++ b/plugins/fish-spec/spec/expect.to_be_true.spec.fish
@@ -1,28 +1,28 @@
 import plugins/fish-spec
 
 function describe_expect_to_be_true
-  function before_each
-    set -e result
-  end
-
   function it_returns_0_when_evaluated_value_returns_0
-    echo (expect true --to-be-true; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect true --to-be-true
+
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_evaluated_value_returns_1
-    echo (expect false --to-be-true; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect false --to-be-true
+
+    expect $status --to-equal 1
   end
 
   function it_returns_0_when_evaluated_function_returns_0
-    echo (expect "eval true" --to-be-true; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect "eval true" --to-be-true
+
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_evaluated_function_returns_1
-    echo (expect "eval false" --to-be-true; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect "eval false" --to-be-true
+
+    expect $status --to-equal 1
   end
 end
 
diff --git a/plugins/fish-spec/spec/expect.to_contain_all.spec.fish b/plugins/fish-spec/spec/expect.to_contain_all.spec.fish
index 7ff7bd7..db69874 100644
--- a/plugins/fish-spec/spec/expect.to_contain_all.spec.fish
+++ b/plugins/fish-spec/spec/expect.to_contain_all.spec.fish
@@ -1,64 +1,52 @@
 import plugins/fish-spec
 
 function describe_expect_to_contain_all
-  function before_each
-    set -e result
-  end
-
   function it_returns_0_when_lists_are_the_same
-    set -l array 1 2
+    expect 1 2 --to-contain-all 1 2
 
-    echo (expect $array --to-contain-all $array; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_lists_are_different
-    set -l array 1 2
+    expect 1 2 --to-contain-all 8 9
 
-    echo (expect $array --to-contain-all 8 9; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect $status --to-equal 1
   end
 
   function it_returns_0_when_lists_have_the_same_item_but_in_different_order
-    set -l array 1 2
+    expect 1 2 --to-contain-all 2 1
 
-    echo (expect $array --to-contain-all 2 1; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect $status --to-equal 0
   end
 
   function it_returns_0_when_expected_list_contains_the_item
-    set -l array 1 2
+    expect 1 2 --to-contain-all 1
 
-    echo (expect $array --to-contain-all 1; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_expected_list_does_not_contain_the_item
-    set -l array 1 2
+    expect 1 2 --to-contain-all 9
 
-    echo (expect $array --to-contain-all 9; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect $status --to-equal 1
   end
 
   function it_returns_0_when_expected_list_contains_all_items
-    set -l array 1 2 3
+    expect 1 2 3 --to-contain-all 1 2
 
-    echo (expect $array --to-contain-all 1 2; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_expected_list_does_not_contain_all_items
-    set -l array 1 2 3
+    expect 1 2 3 --to-contain-all 1 2 9
 
-    echo (expect $array --to-contain-all 1 2 9; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect $status --to-equal 1
   end
 
   function it_returns_1_when_expected_list_contains_less_items
-    set -l array 1 2
+    expect 1 2 --to-contain-all 1 2 9
 
-    echo (expect $array --to-contain-all 1 2 9; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect $status --to-equal 1
   end
 end
 
diff --git a/plugins/fish-spec/spec/expect.to_equal.spec.fish b/plugins/fish-spec/spec/expect.to_equal.spec.fish
index 843b710..178b4e4 100644
--- a/plugins/fish-spec/spec/expect.to_equal.spec.fish
+++ b/plugins/fish-spec/spec/expect.to_equal.spec.fish
@@ -1,36 +1,28 @@
 import plugins/fish-spec
 
 function describe_expect_to_equal
-  function before_each
-    set -e result
-  end
-
   function it_returns_0_when_compared_values_are_the_same
-    set -l equal "equal"
+    expect 'equal' --to-equal 'equal'
 
-    echo (expect $equal --to-equal $equal; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_compared_values_are_different
-    set -l equal "equal"
+    expect 'equal' --to-equal 'different'
 
-    echo (expect $equal --to-equal 'different'; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect $status --to-equal 1
   end
 
   function it_returns_0_when_list_items_are_in_the_same_order
-    set -l array 1 2
+    expect 1 2 --to-equal 1 2
 
-    echo (expect $array --to-equal 1 2; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect $status --to-equal 0
   end
 
   function it_returns_1_when_list_items_are_in_different_order
-    set -l array 1 2
+    expect 1 2 --to-equal 2 1
 
-    echo (expect $array --to-equal 2 1; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect $status --to-equal 1
   end
 end
 
diff --git a/plugins/fish-spec/spec/expect.to_not_contain_all.spec.fish b/plugins/fish-spec/spec/expect.to_not_contain_all.spec.fish
index 0f8a7f2..6c7bc54 100644
--- a/plugins/fish-spec/spec/expect.to_not_contain_all.spec.fish
+++ b/plugins/fish-spec/spec/expect.to_not_contain_all.spec.fish
@@ -1,48 +1,52 @@
 import plugins/fish-spec
 
 function describe_expect_to_not_contain_all
-  function before_each
-    set -e result
-  end
-
   function it_is_false_when_lists_are_the_same
-    echo (expect 1 2 --to-not-contain-all 1 2; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect 1 2 --to-not-contain-all 1 2
+
+    expect $status --to-equal 1
   end
 
   function it_is_true_when_lists_are_different
-    echo (expect 1 2 --to-not-contain-all 8 9; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect 1 2 --to-not-contain-all 8 9
+
+    expect $status --to-equal 0
   end
 
   function it_is_false_when_lists_have_the_same_items_but_in_different_order
-    echo (expect 1 2 --to-not-contain-all 2 1; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect 1 2 --to-not-contain-all 2 1
+
+    expect $status --to-equal 1
   end
 
   function it_is_false_when_expected_list_contains_an_item
-    echo (expect 1 2 --to-not-contain-all 1; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect 1 2 --to-not-contain-all 1
+
+    expect $status --to-equal 1
   end
 
   function it_is_true_when_expected_list_does_not_contain_an_item
-    echo (expect 1 2 --to-not-contain-all 9; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect 1 2 --to-not-contain-all 9
+
+    expect $status --to-equal 0
   end
 
   function it_is_false_when_expected_list_contains_all_items
-    echo (expect 1 2 3 --to-not-contain-all 1 2; set result $status) >/dev/null
-    expect $result --to-equal 1
+    expect 1 2 3 --to-not-contain-all 1 2
+
+    expect $status --to-equal 1
   end
 
   function it_is_true_when_expected_array_does_not_contain_any_items
-    echo (expect 1 2 3 --to-not-contain-all 8 9; set result $status) >/dev/null
-    expect $result --to-equal 0
+    expect 1 2 3 --to-not-contain-all 8 9
+
+    expect $status --to-equal 0
   end
 
   function it_is_true_when_expected_array_contains_less_items
-    echo (expect 1 2 --to-not-contain-all 1 2 9; set result $status)
-    expect $result --to-equal 0
+    expect 1 2 --to-not-contain-all 1 2 9
+
+    expect $status --to-equal 0
   end
 end