Archives/oh-my-fish
2
0
Fork 0
mirror of https://github.com/oh-my-fish/oh-my-fish synced 2024-11-03 15:40:32 +00:00
Code Issues Projects Releases Wiki Activity

lib/git/git_is_touched: Speed up (#706)

Browse Source 
* lib/git/git_is_touched: Speed up

This used to use `git status --porcelain`, which by necessity needs to
check the entire repo for all kinds of changes, just to figure out if
there are any.

Instead, we now use git commands that can exit early.

In large repos, this can be faster by a factor of 15 or so.

Fixes #624.

* Fix return status

`git diff` also returns 1 if there *is* a diff.
This commit is contained in:
Fabian Homborg 2019-06-07 21:14:11 +02:00 committed by Derek W. Stavis
parent 18821a5420
commit 131c8d74e5
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/git/git_is_touched.fish
View File

@ -1,5 +1,8 @@
function git_is_touched -d "Check if repo has any changes" function git_is_touched -d "Check if repo has any changes"
git_is_repo; and begin git_is_repo; and begin
test -n (echo (command git status --porcelain)) # The first checks for staged changes, the second for unstaged ones.
# We put them in this order because checking staged changes is *fast*.
not command git diff-index --cached --quiet HEAD -- >/dev/null 2>&1
or not command git diff --no-ext-diff --quiet --exit-code >/dev/null 2>&1
end end
end end