mirror of
https://github.com/dankamongmen/notcurses.git
synced 2024-11-08 01:10:23 +00:00
a29bfe9c42
Fixes: https://github.com/dankamongmen/notcurses/issues/1009 Whenever a widget is created with its `*_create` function it currently claims full ownership of the passed panel, including its destruction. However, the C++ wrapper around the panel is not aware of this and will attempt to destroy the native panel in the destructor, leading to segfaults. Fix this by introduction of a `Widget` class which contains the logic to properly modify the `Panel` instance to not double-destroy the native panel. The solution is a bit fragile since the `Panel` instance is left intact (we can't free it for the user) in a state that's safe for the C++ wrapper, but calling any C function via the wrapper **will** pass a `NULL` pointer in the panel argument - therefore the C functions MUST be proofed against this. The proofing belongs in the C backend code since this protects also C and other language binding users from such abuse. The Widget class will first verify that the passed `Plane` instance hasn't already been "disowned" and will throw an exception to the effect if it was. Next, it will proceed to take over ownership of the native panel instance and mark the passed `Panel` as "invalid" (i.e. not owning any native panel instance anymore) The above changes require modification of `Panel` instances and so all the widget constructors taking `const*` or `const&` have been removed from widget classes.
70 lines
1.6 KiB
C++
70 lines
1.6 KiB
C++
#define NCPP_EXCEPTIONS_PLEASE
|
|
//
|
|
// This is a **build** test - it does nothing else except ensure that all the C++ wrapper classes are included and that
|
|
// the program builds.
|
|
//
|
|
// Once there are demos which exercise all the C++ classes this "test" can be removed
|
|
//
|
|
#include <cstdlib>
|
|
#include <clocale>
|
|
#include <iostream>
|
|
#include <ncpp/NotCurses.hh>
|
|
#include <ncpp/Menu.hh>
|
|
#include <ncpp/Plane.hh>
|
|
#include <ncpp/Reel.hh>
|
|
#include <ncpp/MultiSelector.hh>
|
|
#include <ncpp/Selector.hh>
|
|
#include <ncpp/Visual.hh>
|
|
#include <ncpp/Direct.hh>
|
|
#include <ncpp/Plot.hh>
|
|
#include <ncpp/FDPlane.hh>
|
|
#include <ncpp/Subproc.hh>
|
|
|
|
using namespace ncpp;
|
|
|
|
int run ()
|
|
{
|
|
NotCurses nc;
|
|
|
|
const char *ncver = nc.version ();
|
|
{
|
|
Plane p1 (1, 1, 0, 0);
|
|
Plot plot1 (p1);
|
|
Plane p2 (1, 1, 0, 0);
|
|
PlotU plot2 (p2);
|
|
Plane p3 (1, 1, 0, 0);
|
|
PlotD plot3 (p3);
|
|
}
|
|
|
|
nc.stop ();
|
|
|
|
Direct direct (getenv ("TERM"));
|
|
direct.set_fg_rgb (0xb5, 0x0d, 0xff);
|
|
std::cout << "notcurses version: ";
|
|
direct.set_bg_rgb (0x05, 0x6e, 0xee);
|
|
direct.set_fg_rgb (0xe2, 0xbf, 0x00);
|
|
std::cout << ncver << std::endl;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int main ()
|
|
{
|
|
if (!setlocale (LC_ALL, "")){
|
|
std::cerr << "Couldn't set locale based on user preferences" << std::endl;
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
try {
|
|
return run ();
|
|
} catch (ncpp::init_error &e) {
|
|
std::cerr << "Initialization error: " << e.what () << std::endl;
|
|
} catch (ncpp::invalid_state_error &e) {
|
|
std::cerr << "Invalid state error: " << e.what () << std::endl;
|
|
} catch (ncpp::invalid_argument &e) {
|
|
std::cerr << "Invalid argument error: " << e.what () << std::endl;
|
|
}
|
|
|
|
return 1;
|
|
}
|