11 Commits (de3cd3c644449ce535fc28cd44ad6710df6348fc)

Author	SHA1	Message	Date
Marek Habersack	a29bfe9c42	[C++] Deal with widgets grabbing full ownership of Panel ... Fixes: https://github.com/dankamongmen/notcurses/issues/1009 Whenever a widget is created with its `*_create` function it currently claims full ownership of the passed panel, including its destruction. However, the C++ wrapper around the panel is not aware of this and will attempt to destroy the native panel in the destructor, leading to segfaults. Fix this by introduction of a `Widget` class which contains the logic to properly modify the `Panel` instance to not double-destroy the native panel. The solution is a bit fragile since the `Panel` instance is left intact (we can't free it for the user) in a state that's safe for the C++ wrapper, but calling any C function via the wrapper **will** pass a `NULL` pointer in the panel argument - therefore the C functions MUST be proofed against this. The proofing belongs in the C backend code since this protects also C and other language binding users from such abuse. The Widget class will first verify that the passed `Plane` instance hasn't already been "disowned" and will throw an exception to the effect if it was. Next, it will proceed to take over ownership of the native panel instance and mark the passed `Panel` as "invalid" (i.e. not owning any native panel instance anymore) The above changes require modification of `Panel` instances and so all the widget constructors taking `const*` or `const&` have been removed from widget classes.	4 years ago
Marek Habersack	943e23535f	[C++] API sync ... Fixes: https://github.com/dankamongmen/notcurses/issues/1025 Added: * Direct: flush (`ncdirect_flush`) * Direct: getc (`ncdirect_getc_blocking` and `ncdirect_getc_nblock`) * Direct: getc (`ncdirect_getc`) * Direct: get_inputready_fd (`ncdirect_inputready_fd`) * NotCurses: align (`notcurses_align`) * NotCurses: ucs32_to_utf8 (`notcurses_ucs32_to_utf8`) * NotCurses: get_bottom (`notcurses_bottom`) * Plane: resize_realign (`ncplane_resize_realign`) * Plane: get_x (`ncplane_x`) * Plane: get_y (`ncplane_y`) * Plane: mergedown (`ncplane_mergedown`) * Plane: putwc_stained (`ncplane_putwc_stained`) * Plane: putstr_stained (`ncplane_putstr_stained`) * Plane: set_fchannel (`ncplane_set_fchannel`) * Plane: set_bchannel (`ncplane_set_bchannel`) * Plane: get_styles (`ncplane_styles`) * Plane: get_above (`ncplane_above`) * Reader: move_left (`ncreader_move_left`) * Reader: move_right (`ncreader_move_right`) * Reader: move_up (`ncreader_move_up`) * Reader: move_down (`ncreader_move_down`) * Reader: write_egc (`ncreader_write_egc`) * Visual: get_default_blitter (`ncvisual_default_blitter`) Fixed: * NotCurses: `cursor_{enable,disable}` must use `NOEXCEPT_MAYBE` * Plane: renamed `putcw` to `putwc`	4 years ago
nick black	c3e5e47a2a	ncreader: conform to the New Way #627	4 years ago
Marek Habersack	b5d8549bb3	[C++] Allow multiple instances of `NotCurses` ... This is to make it possible, in the future, to create multiple instances of `NotCurses` for multiple terminals. The first instance of `NotCurses` becomes the default one, so that any instances of other classes that aren't explicitly created with a pointer to another `NotCurses` instance still work as expected. Note that currently trying to call `notcurses_init` twice results in the following error for me: 0x55555559bfc0 is already registered for signals Couldn't drop signals: 0x55555559bfc0 != 0x5555555b6720 terminate called after throwing an instance of 'ncpp::init_error*' Program received signal SIGABRT, Aborted. The error is signalled by `setup_signals` and the pointer shown in the message points to the first `struct notcurses` instance created.	4 years ago
Marek Habersack	e0462ed53a	[C++] Sync API changes (#633) ... Added: * NotCurses: can_utf8 (`notcurses_canutf8`) * NotCurses: debug (`notcurses_debug`) * Plane: center_abs (`ncplane_center_abs`) * Plane: set_channels (`ncplane_set_channels`) * Plane: set_attr (`ncplane_set_attr`) * Reader: clear (`ncreader_clear`) Changed: * USAGE.md: clarfied when C++ throws exceptions	4 years ago
Marek Habersack	9ca8d9c9c6	Correctly cast `ncpp::Plane` to `ncplane*` ... Fixes: https://github.com/dankamongmen/notcurses/issues/616 SIGSEGV was caused by an invalid cast. Short explanation: PEBKAC Long explanation: `Selector.hh`, `Plot.hh` and `MultiSelector.hh` did not include `Plane.hh`, they merely declared `class Plane;` because inclusion of `Plane.hh` would cause circular dependencies to appear and the compiler would be unhappy. On top of that, yours truly wrenched the compiler's hands and caused it to believe that a pointer to `Plane` is really a pointer to `ncplane*` which was quite a silly thing to do as the compiler, not having included `Plane.hh` and thus not knowing full definition of the type, wasn't able to look up the type cast operator in `Plane`. Don't abuse `reinterpret_cast`, kids!	4 years ago
nick black	0d696be0cc	ncpp: normalize Notcurses capitalization	4 years ago
nick black	eaaa36f0c8	ncreader: ncplane as first arg #590	4 years ago
nick black	5b0d773fb5	modernize some PoC c++ according to clang-tidy	4 years ago
nick black	48de25821c	ncreader man page #403	4 years ago
nick black	312e42add2	ncreader: C++ wrapper	4 years ago