notcurses

Commit Graph

Author	SHA1	Message	Date
Marek Habersack	9ca8d9c9c6	Correctly cast `ncpp::Plane` to `ncplane` Fixes: https://github.com/dankamongmen/notcurses/issues/616 SIGSEGV was caused by an invalid cast. Short explanation: PEBKAC Long explanation: `Selector.hh`, `Plot.hh` and `MultiSelector.hh` did not include `Plane.hh`, they merely declared `class Plane;` because inclusion of `Plane.hh` would cause circular dependencies to appear and the compiler would be unhappy. On top of that, yours truly wrenched the compiler's hands and caused it to believe that a pointer to `Plane` is really a pointer to `ncplane` which was quite a silly thing to do as the compiler, not having included `Plane.hh` and thus not knowing full definition of the type, wasn't able to look up the type cast operator in `Plane`. Don't abuse `reinterpret_cast`, kids!	4 years ago

Author

SHA1

Message

Date

Marek Habersack

9ca8d9c9c6

Correctly cast `ncpp::Plane` to `ncplane*`

Fixes: https://github.com/dankamongmen/notcurses/issues/616

SIGSEGV was caused by an invalid cast.

Short explanation: PEBKAC

Long explanation: `Selector.hh`, `Plot.hh` and `MultiSelector.hh` did
not include `Plane.hh`, they merely declared `class Plane;` because
inclusion of `Plane.hh` would cause circular dependencies to appear and
the compiler would be unhappy.  On top of that, yours truly wrenched the
compiler's hands and caused it to believe that a pointer to `Plane` is
really a pointer to `ncplane*` which was quite a silly thing to do as
the compiler, not having included `Plane.hh` and thus not knowing full
definition of the type, wasn't able to look up the type cast operator in
`Plane`.

Don't abuse `reinterpret_cast`, kids!

1 Commits (dbc20bd5c018543ed90c1c958e275225b9625a0a)