Commit Graph

561 Commits

Author SHA1 Message Date
nick black
29c7f960cc add writeout_ stats, document stats #1039 2020-10-04 10:04:02 -04:00
Marek Habersack
a29bfe9c42 [C++] Deal with widgets grabbing full ownership of Panel
Fixes: https://github.com/dankamongmen/notcurses/issues/1009

Whenever a widget is created with its `*_create` function it currently
claims full ownership of the passed panel, including its destruction.
However, the C++ wrapper around the panel is not aware of this and will
attempt to destroy the native panel in the destructor, leading to
segfaults.

Fix this by introduction of a `Widget` class which contains the logic to
properly modify the `Panel` instance to not double-destroy the native
panel.  The solution is a bit fragile since the `Panel` instance is left
intact (we can't free it for the user) in a state that's safe for the
C++ wrapper, but calling any C function via the wrapper **will** pass a
`NULL` pointer in the panel argument - therefore the C functions MUST be
proofed against this.  The proofing belongs in the C backend code since
this protects also C and other language binding users from such abuse.

The Widget class will first verify that the passed `Plane` instance
hasn't already been "disowned" and will throw an exception to the effect
if it was.  Next, it will proceed to take over ownership of the native
panel instance and mark the passed `Panel` as "invalid" (i.e. not owning
any native panel instance anymore)

The above changes require modification of `Panel` instances and so all
the widget constructors taking `const*` or `const&` have been removed
from widget classes.
2020-10-03 13:19:49 -04:00
nick black
683217ef07 normalize style setters #1034 2020-09-29 13:09:44 -04:00
nick black
174a00b56c
add deprecated nctablet_ncplane() for old binaries 2020-09-29 11:59:33 -04:00
nick black
6ddf105746
uninline ncplane_new() so older binaries continue to link 2020-09-29 11:52:48 -04:00
nick black
c236b65266 name standard plane 'std' 2020-09-28 07:08:17 -04:00
nick black
a591e11c96 retain nctablet_ncplane() as deprecated alias 2020-09-28 07:08:17 -04:00
nick black
afd444cea3
kill stray decl ncdirect_getc_nonblocking() #1028 2020-09-28 01:28:46 -04:00
nick black
20bf1ae2d4
nctablet_ncplane() -> nctablet_plane() 2020-09-27 16:46:39 -04:00
nick black
ec85dd1c3b
ncreel_destroy: return void 2020-09-27 15:57:03 -04:00
Marek Habersack
943e23535f [C++] API sync
Fixes: https://github.com/dankamongmen/notcurses/issues/1025

Added:
  * Direct: flush (`ncdirect_flush`)
  * Direct: getc (`ncdirect_getc_blocking` and `ncdirect_getc_nblock`)
  * Direct: getc (`ncdirect_getc`)
  * Direct: get_inputready_fd (`ncdirect_inputready_fd`)
  * NotCurses: align (`notcurses_align`)
  * NotCurses: ucs32_to_utf8 (`notcurses_ucs32_to_utf8`)
  * NotCurses: get_bottom (`notcurses_bottom`)
  * Plane: resize_realign (`ncplane_resize_realign`)
  * Plane: get_x (`ncplane_x`)
  * Plane: get_y (`ncplane_y`)
  * Plane: mergedown (`ncplane_mergedown`)
  * Plane: putwc_stained (`ncplane_putwc_stained`)
  * Plane: putstr_stained (`ncplane_putstr_stained`)
  * Plane: set_fchannel (`ncplane_set_fchannel`)
  * Plane: set_bchannel (`ncplane_set_bchannel`)
  * Plane: get_styles (`ncplane_styles`)
  * Plane: get_above (`ncplane_above`)
  * Reader: move_left (`ncreader_move_left`)
  * Reader: move_right (`ncreader_move_right`)
  * Reader: move_up (`ncreader_move_up`)
  * Reader: move_down (`ncreader_move_down`)
  * Reader: write_egc (`ncreader_write_egc`)
  * Visual: get_default_blitter (`ncvisual_default_blitter`)

Fixed:
  * NotCurses: `cursor_{enable,disable}` must use `NOEXCEPT_MAYBE`
  * Plane: renamed `putcw` to `putwc`
2020-09-27 15:32:25 -04:00
nick black
2f26f06386
alignment: add NCALIGN_UNALIGNED, preserve align type #364 2020-09-20 11:46:49 -04:00
nick black
2d9598b913
introduce ncplane_resize_realign #364 2020-09-20 10:14:05 -04:00
nick black
7b51bab79a add resizecb to ncplane_options struct #869 2020-09-20 08:54:56 -04:00
nick black
73f9973a2c Plane.hh: fix up indentation #1020 2020-09-20 05:52:27 -04:00
nick black
36aed3c521 add ncplane_create() + ncplane_options #1020 2020-09-20 05:52:27 -04:00
nick black
607c03edc4
rename _rgb_clipped functions rgb8_clipped 2020-09-19 21:55:01 -04:00
nick black
a4367fcfb5 rip out ncplane_ creation functions #985 2020-09-18 17:46:57 -04:00
nick black
e42dbdfd60 _stainable() -> _stained() #985 2020-09-18 02:02:08 -04:00
nick black
c5c608b22e add ncplane_putwc_stainable, ncplane_putwstr_stainable #985 2020-09-18 02:02:08 -04:00
nick black
b7a57eaab7 convert all channel rgb calls #985 2020-09-18 01:39:21 -04:00
nick black
0e34bec3fb start converting rgb->rgb8 #985 2020-09-18 01:39:21 -04:00
nick black
4bb1f3fc85 mbswidth -> ncstrwidth() #985 2020-09-15 01:39:42 -04:00
nick black
dab7247cdd
mbswidth: use utf8_egc_len() for segmentation #1014 2020-09-15 00:29:53 -04:00
nick black
dca9db9687
ncreel: conform to the New Way #627 2020-09-13 14:18:42 -04:00
nick black
c3e5e47a2a
ncreader: conform to the New Way #627 2020-09-13 13:53:11 -04:00
nick black
4f04f1bc31 remove bgchannels field from selector_options #627 2020-09-13 13:22:58 -04:00
nick black
306948507f ncmultiselect: normalize per new widget API #627 #1006 2020-09-13 13:22:58 -04:00
nick black
8839d44454 selector: transfer ownership of ncplane #1006 #627 2020-09-13 13:22:58 -04:00
nick black
a801f975a6
all widget creators get attribute ((nonnull)) #627 2020-09-13 04:51:49 -04:00
nick black
3f726edd4c
all widgets check flags and warn on undefined #627 2020-09-13 04:42:18 -04:00
nick black
89a4b6f726
all widget options structs end in flagword #627 2020-09-11 09:19:55 -04:00
nick black
af05ae7a92 man pages: document NCREADER_OPTION_CURSOR 2020-09-06 23:10:16 -04:00
nick black
f88c8ae79c
expose ncvisual_default_blitter(), name blitter in notcurses-view #995 2020-09-06 12:56:16 -04:00
nick black
3afcfc97d6
ncreader: define NCREADER_OPTIONS_EMACSKEYS 2020-08-31 22:43:42 -04:00
nick black
2f28420034 rename ncplane_putsimple() -> ncplane_putchar() #912 2020-08-31 21:14:29 -04:00
nick black
4c7a1d0427 ncdirect_init: add flags parameter #976 2020-08-30 13:38:33 -04:00
nick black
5fc6705ce3
add notcurses_ucs32_to_utf8() 2020-08-30 04:43:27 -04:00
nick black
5901fce433 unite putegc_yx+putc_yx into ncplane_put #961 2020-08-29 20:29:04 -04:00
nick black
0cee9bdb5c ReelsGap unit test #901 2020-08-29 18:24:45 -04:00
nick black
66f80c77f9
add ncplane_y() and ncplane_x() 2020-08-29 15:50:45 -04:00
Nick Black
d4ad59f285 FreeBSD compilation fixes 2020-08-27 14:26:44 -04:00
nick black
9f84c1524e
cell_load_simple: need an ntole() #906 2020-08-27 12:25:57 -04:00
nick black
c24ca8ab56
introduce ntole() #906 2020-08-27 06:59:11 -04:00
nick black
c66d8f52d5
Endianness fixes for inlined egcs #906 2020-08-27 06:02:37 -04:00
nick black
8f65211bf8 declare ncdirect input layer #919 2020-08-26 23:12:59 -04:00
nick black
9d75f575db
ncplane_set_[fb]channels 2020-08-25 17:28:29 -04:00
nick black
70a28feb63
ncreader: horizontal scrolling mostly works #839 2020-08-25 08:58:49 -04:00
nick black
7cbb2e9110 zoo demo: show cursor in reader box #835 2020-08-25 06:29:03 -04:00
nick black
a53d5a21a8 disable/enable cursor for rasterize 2020-08-25 04:55:06 -04:00