From ff3b4b0a10f54765a76b232df859d9c2deaf0b3e Mon Sep 17 00:00:00 2001
From: KristofferC <kcarlsson89@gmail.com>
Date: Thu, 23 Dec 2021 15:39:31 +0100
Subject: [PATCH] some updates from review

---
 src/libffi/ffi.c          |   3 ++-
 tools/a.out               | Bin 0 -> 15920 bytes
 tools/generate_ffi.py     |   2 +-
 tools/notcurses-ffi.pc.in |   4 ++--
 tools/tmp.cc              |   2 ++
 5 files changed, 7 insertions(+), 4 deletions(-)
 create mode 100755 tools/a.out
 create mode 100644 tools/tmp.cc

diff --git a/src/libffi/ffi.c b/src/libffi/ffi.c
index 7eb058a2b..57c140b7c 100644
--- a/src/libffi/ffi.c
+++ b/src/libffi/ffi.c
@@ -1,7 +1,8 @@
-// Cointains all inline functions in include/notcurses/*.h
+// Contains all inline functions in include/notcurses/*.h
 // This file is auto generated from tools/generate_ffi.py
 #include <notcurses/notcurses.h>
 #include <notcurses/direct.h>
+
 #include <notcurses/nckeys.h>
 
 bool nccapability_canchangecolor(const nccapabilities* caps);
diff --git a/tools/a.out b/tools/a.out
new file mode 100755
index 0000000000000000000000000000000000000000..85f28cf5f737d94ce1fc48aac10363a6ba44df31
GIT binary patch
literal 15920
zcmeHOZ){sv6~A_pHf62j{-dESs~N4-Li3vRpR&=cb`qyA$ZbcPY(iW2<k)Uv$$v8Y
znI#jjLSPWB*`lcuLI??M+L*KnZJ)LeMWiZB`@j(WGK!#DG#Kj;Y}sHaz*=+8edp&q
zzd4=6_=5DVWdH8@opbIz@7(*G`||F6FrF9)1_BDDN!_kkiiRB~DvE`JQXz<{ZncKK
zKdrW^6(l!n&e2C5Agxm_2kWs__$EU3Yv)P>-0INOgHsS8Bl|5^F1I)uppxrgKdllO
zJn$FN0T6txzlikc!A|i5y8Spe3muN%LQg$LBriJ!;m0ETDZ{a+;c$xJob(4oJ~=1+
z>6UzYu~V7>di}=4&x`%y2jo7uoP5Jh|2O^JA%4vf-Hh_$A%|8#^!Fw5(|Hm7M*)WU
zg!H%EID{qtKuNFKlgo}A+`lK6?#N{em5Gjt?t>i%_Z#J+u~&D^aYg9EbLz;kVMWc%
zF(+wM!84AG_E@(;^lX3X#N2m!?#{)ZA9&@;n~6t8zgarp%QhT0`>+icZVyw0Wv+9d
zY~$qP8&s3IO?WButGp(b`RXP<(m==ku4}*#5f^E|r<UP4u3H+|E6YkvB(2lgLNb?q
zAVVT0IAxXXWXZPj$!tNf%=ta2jwA+q`>egjUgLnW28WJX=}ajznl0Oz($LYqT(OWD
zN{-~XjnRCuAZ=KVX+uLDkCR2@GC&#RI5AHuo3pDpySpWJ+^@J#B5NJRqTI*e=cR$x
zsG|oD`SM|h=dt44pv=2?#KgL*E*^7<`2`ox^8{tl#q+%Ii=P2M1AYel4EP!FGvH^y
z&w!tS8)e{cZ8!hRocc?v`Ebi`_b6q4d(IA4e{D|vy!E1Xs~&iq==Z8So*-!3rr4gO
zpK7UJX}RmKgVUGpHK$)Ur~bHb$53LX<xX1anlo!&qbAImo(lxkjU{sV`z(pyr;0h#
z@)*Odi}pt9`WV-#>s8hHwryv)<BNi1pVjsUMi_QoH>VfO3vVAbFDy2hftSon*X<3|
zzz%7kwK{*gZ5zb}e~$M|535z>^TXy;PmrtT^c(hS^WmNqBwXE9tyZt5>FcGIYxL9|
zI7Pm7{%_q+N^WSF{9fef*yLMW(bpflD>2ja1U)&#?i`$cH8wmr{eEmHHvPe{In!~D
z=#z<E*Eq*lAH80!nisA$+1t8)C)bylelIcocK`I7vFe7`%&Ch3^VTbsKXd-?J{7ws
zb}Dvn%({5`wBhcLN2WGzwUN@{_+Neo{0#UR@H60Nz|Vl60Y3wN2K)^88SpdUXP{vQ
z0`$%+u%+n>{9cgXQEgqQR&#{A3C|H8BII{~JKn8UpJkcwmxRv}ZlI@pey7PL@W2Tb
zm<R{9tX|nVD?GoupMR%X<tJ{{zf!*`+fLQ}^m&?iO@zV&q4qDf-E@EJ8FhH`ZJ*n>
zonOo8cJCpag&mVrxJ{cr_fcGJOvFRshk|`;Rt!+bB+{e5I!B)|(q{<OKq&lZa4^*V
zNK-r%nQ4xPcAjnN4|P7Y!VGm!tvnKn7DC;zP-iT(vo{p!4Yl`%!o8tZ{a*0*<UUL7
z`0v#?k$&+r;Ag<kfS&<B1AYel4EP!FGvH_7|1AU9$B2E4^r)tbe(0jwYLT%qa*fC@
z%KpbsiH!Y`TSUgb$IT*RpCmu8ae@B*>(wI5&&lRSJX?)5GmAZ~N?jKHCmdRRP4Fhc
zcEOE;0C7`uvM+Ka?4={bF(*82`qTyO-7GTf{#|wAr95eh-r(x^7bRYLGpuFgkscSd
z{3p@>Q)I*?&HwKJ`@=tGi`cJvq_6L`$j;%BO2Mu~x;l-0MrTJ?MT=d#gt$>xoQG!h
zZq;kUc@B`~tRx~L2I~nM+4DFARY;9vgRa;|g#VF;-zPlgwV10xssvQK3P&9V<HWnG
z1N2`8%u`3J)K{s({o+0W|6OgrUSZyY|1nh>#lPHj{Y1C3PVN2-T3EtH?VQ)@^&g7!
z72OWae$V*7D)!zu-_rcr+J1X2($@#{38+uj?icV+Qlf&2?lw=J*Ac&t^7EYh9^n4H
zh4=`ZU6|4QCZ(b-lB%~8A6A=c;{xqg;@1V+6n<~O$C-!V!j!b*ZGW8jh|3Pu2Z>)B
z+@vty!JlQGFIJr7_EkS1p0775*P9WCmkGl(uiB$R2xMU|dD|oWGsLq!<{`XZ5c^%y
zew!%H6VGva?O!H70%sS#PCS0YT{LYzNtNs_qez?OlOtKnPL3)f%65hJl%&+s#(K-n
zTPfaJUna|R(HhMaN0K=!Z5K;rD_NOPsbYRSm$5TxqqDIE@9oc8$x<mfX=Ms_X;Pgo
zCG#08UCHMs$;BmEWNFu#+WB!Kl_INw6S1RlD}Josq7D7^c4=kxfB9JK=wM&HMxP-d
zijGWJaZ_3_`%ftANaA>JEMXlV7&sXpvW8;4i8!~aPadSo6&>-7PZ(s<NjnLbrNau*
zx+4k}8#%`i$h7`Uf|V{8t+8Yw&F2*ckCRn8Td*qS3|-AqAe;}9N6KYsMxThVEIRIh
zT<|%FhKC#K4_4Ggri}7r-cF7X+9e0aP|FtRIK{X!3Pn3(j20@!c&Rv^DcO@QYNV2-
z12EaNP_f>@4xT{Td@NZWQ$~8SKwUU!mmJMkGNp31Sf~>$(v>o~Bs(ZWU#>BpvlV|C
zqeZINnF;#lIYgF4opvKLCbMQNP5zJ^e`oqQ9;j2}$$U0N;qa&#lul*Pyv@^eth*;Z
zhQR9`y4C2n(J9{ZYgq4yTHB(|_*we!ngssKozr4lE?9>+l2UvO&+YF$ueBY9g7_T+
z&3_Nw{`h+gjKEOP>wg#V|DZJu;>S7;i2j|kNgs|sN&dWsgFn`Jz**^+W8^&J`msLC
z630sj_+#A&#5$2obm2DK<vtR4%?5w0(|}n2B7WEbzfS(V284`tATT1GdE*ya%}|AN
z3jcQb0}7lIL-g;x{_l~VuL*kolckFw*5ktJzEEfUA${Eb5%B|}Iru;ZKJM}F6a^4=
z%lSX!@sElFu;LjoZ+p*s{IN~|;&}!Ad*|;9;$K@!M8s0iYY!RtGx5jxHN#Kv5b50o
ze&C#S+tT<)BaQ~R07F5HKj`03B}5-QPhg#g^Nn76$iP34FRwA+kM-|j2a!}@=SWL3
z_;*Oba}WNt^{1Ryos;q7`OgJ@7{{lGV-xt}Ic-iBN>S3e3;cnLq;&hMs91M8h<=2v
z^$+<vRk$tmkM&hp{Lv5W<#HgZCL)*<^BNET9W}<Oz~7CSJ8si%Y4B+YjPGN9wnaSn
l{aZyGVt4z`^8*l-Yv{-kb*xg=z{|`={#On-R;xe4|3BsU0tNs8

literal 0
HcmV?d00001

diff --git a/tools/generate_ffi.py b/tools/generate_ffi.py
index 258a803aa..da02deebc 100644
--- a/tools/generate_ffi.py
+++ b/tools/generate_ffi.py
@@ -17,7 +17,7 @@ def generate_ffi(notcurses_dir):
     lines.sort()
 
     with open(os.path.join(notcurses_dir, "src", "libffi", "ffi.c"), 'w') as f:
-        f.write("// Cointains all inline functions in include/notcurses/*.h\n")
+        f.write("// Contains all inline functions in include/notcurses/*.h\n")
         f.write("// This file is auto generated from tools/generate_ffi.py\n")
         f.write("#include <notcurses/notcurses.h>\n")
         f.write("#include <notcurses/direct.h>\n\n")
diff --git a/tools/notcurses-ffi.pc.in b/tools/notcurses-ffi.pc.in
index 95e81eef0..6dac27f45 100644
--- a/tools/notcurses-ffi.pc.in
+++ b/tools/notcurses-ffi.pc.in
@@ -4,11 +4,11 @@ libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
 includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@
 
 Name: @PROJECT_NAME@
-Description: TUI library for modern terminal emulators (ffi support)
+Description: TUI library for modern terminal emulators (ffi library)
 Version: @PROJECT_VERSION@
 
 Requires: notcurses-ffi
 Requires.private:
 Libs: -L${libdir} -lnotcurses-ffi
-Libs.private: -lstdc++
+Libs.private: -lunistring -lm
 Cflags: -I${includedir}
diff --git a/tools/tmp.cc b/tools/tmp.cc
new file mode 100644
index 000000000..e0ab68033
--- /dev/null
+++ b/tools/tmp.cc
@@ -0,0 +1,2 @@
+#include "../include/notcurses/notcurses.h"
+int main() { return 0; }