From bdd0917ea497a98f80d8ac44d6ba2a989eb0ef6a Mon Sep 17 00:00:00 2001
From: nick black <dankamongmen@gmail.com>
Date: Sun, 23 Feb 2020 09:38:58 -0500
Subject: [PATCH] selector: transparent where we aren't

---
 include/notcurses/notcurses.h |  2 +-
 src/lib/selector.c            |  4 ++++
 src/poc/selector.c            | 35 ++++++++++++++++++++++++++++-------
 3 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/include/notcurses/notcurses.h b/include/notcurses/notcurses.h
index adf75e4cc..b879a8a57 100644
--- a/include/notcurses/notcurses.h
+++ b/include/notcurses/notcurses.h
@@ -1035,7 +1035,7 @@ channel_set_alpha(unsigned* channel, int alpha){
     return -1;
   }
   *channel = (alpha << CELL_ALPHA_SHIFT) | (*channel & ~CELL_ALPHA_MASK);
-  if(alpha == CELL_ALPHA_HIGHCONTRAST){
+  if(alpha != CELL_ALPHA_HIGHCONTRAST){
     *channel |= CELL_BGDEFAULT_MASK;
   }
   return 0;
diff --git a/src/lib/selector.c b/src/lib/selector.c
index 3be20615c..f71358649 100644
--- a/src/lib/selector.c
+++ b/src/lib/selector.c
@@ -217,6 +217,10 @@ ncselector* ncselector_create(ncplane* n, int y, int x, const selector_options*
     goto freeitems;
   }
   cell_init(&ns->background);
+  uint64_t transchan = 0;
+  channels_set_fg_alpha(&transchan, CELL_ALPHA_TRANSPARENT);
+  channels_set_bg_alpha(&transchan, CELL_ALPHA_TRANSPARENT);
+  ncplane_set_base(ns->ncp, transchan, 0, "");
   if(cell_prime(ns->ncp, &ns->background, " ", 0, opts->bgchannels) < 0){
     ncplane_destroy(ns->ncp);
     goto freeitems;
diff --git a/src/poc/selector.c b/src/poc/selector.c
index c166ba5a2..4a6598c3f 100644
--- a/src/poc/selector.c
+++ b/src/poc/selector.c
@@ -70,40 +70,61 @@ int main(void){
   channels_set_fg(&sopts.boxchannels, 0x20e040);
   channels_set_fg(&sopts.opchannels, 0xe08040);
   channels_set_fg(&sopts.descchannels, 0x80e040);
+  channels_set_bg(&sopts.opchannels, 0);
+  channels_set_bg(&sopts.descchannels, 0);
   channels_set_fg(&sopts.footchannels, 0xe00040);
   channels_set_fg(&sopts.titlechannels, 0xffff80);
   channels_set_fg(&sopts.bgchannels, 0x002000);
   channels_set_bg(&sopts.bgchannels, 0x002000);
   channels_set_fg_alpha(&sopts.bgchannels, CELL_ALPHA_BLEND);
   channels_set_bg_alpha(&sopts.bgchannels, CELL_ALPHA_BLEND);
-  ncplane_set_fg(notcurses_stdplane(nc), 0x40f040);
-  ncplane_putstr_aligned(notcurses_stdplane(nc), 0, NCALIGN_RIGHT, "selector widget demo");
-  struct ncselector* ns = ncselector_create(notcurses_stdplane(nc), 3, 0, &sopts);
+  struct ncplane* n = notcurses_stdplane(nc);
+
+  int averr;
+  struct ncvisual* ncv = ncplane_visual_open(n, "../data/changes.jpg", &averr);
+  if(!ncv){
+    goto err;
+  }
+  if(!ncvisual_decode(ncv, &averr)){
+    goto err;
+  }
+  if(ncvisual_render(ncv, 0, 0, 0, 0)){
+    goto err;
+  }
+
+
+  ncplane_set_fg(n, 0x40f040);
+  ncplane_putstr_aligned(n, 0, NCALIGN_RIGHT, "selector widget demo");
+  struct ncselector* ns = ncselector_create(n, 3, 0, &sopts);
   run_selector(nc, ns);
 
   sopts.title = "short round title";
-  ns = ncselector_create(notcurses_stdplane(nc), 3, 0, &sopts);
+  ns = ncselector_create(n, 3, 0, &sopts);
   run_selector(nc, ns);
 
   sopts.title = "short round title";
   sopts.secondary = "now this secondary is also very, very, very outlandishly long, you see";
-  ns = ncselector_create(notcurses_stdplane(nc), 3, 0, &sopts);
+  ns = ncselector_create(n, 3, 0, &sopts);
   run_selector(nc, ns);
 
   sopts.title = "the whole world is watching";
   sopts.secondary = NULL;
   sopts.footer = "now this FOOTERFOOTER is also very, very, very outlandishly long, you see";
-  ns = ncselector_create(notcurses_stdplane(nc), 3, 0, &sopts);
+  ns = ncselector_create(n, 3, 0, &sopts);
   run_selector(nc, ns);
 
   sopts.title = "chomps";
   sopts.secondary = NULL;
   sopts.footer = NULL;
-  ns = ncselector_create(notcurses_stdplane(nc), 3, 0, &sopts);
+  ns = ncselector_create(n, 3, 0, &sopts);
   run_selector(nc, ns);
 
   if(notcurses_stop(nc)){
     return EXIT_FAILURE;
   }
   return EXIT_SUCCESS;
+
+err:
+  notcurses_stop(nc);
+  return EXIT_FAILURE;
 }