Archives/notcurses
2
0
Fork 0
mirror of https://github.com/dankamongmen/notcurses.git synced 2024-11-04 06:00:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

ncplane_erase_region(): protect against overflow

Browse Source
This commit is contained in:
nick black 2021-09-21 17:51:54 -04:00 committed by nick black
parent 0c41b3ddc5
commit 8a0d924baf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/notcurses.c
View File

@ -2144,7 +2144,7 @@ int ncplane_erase_region(ncplane* n, int ystart, int xstart, int ylen, int xlen)
xstart = 0;
xlen = ncplane_dim_x(n);
}
if(xstart + xlen > ncplane_dim_x(n)){
if(xlen > ncplane_dim_x(n) || xstart + xlen > ncplane_dim_x(n)){
xlen = ncplane_dim_x(n) - xstart;
}
if(ylen < 0){
@ -2154,7 +2154,7 @@ int ncplane_erase_region(ncplane* n, int ystart, int xstart, int ylen, int xlen)
ystart = 0;
ylen = ncplane_dim_y(n);
}
if(ystart + ylen > ncplane_dim_y(n)){
if(ylen > ncplane_dim_y(n) || ystart + ylen > ncplane_dim_y(n)){
ylen = ncplane_dim_y(n) - ystart;
}
// special-case the full plane erasure, as it's powerfully optimized (O(1))