From 2e1ccdce152a2b63e6211c1cf448e186c74bf3ac Mon Sep 17 00:00:00 2001 From: nick black Date: Fri, 3 Sep 2021 05:09:26 -0400 Subject: [PATCH] interrogate_terminfo: avoid double-free on error path --- src/lib/termdesc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/termdesc.c b/src/lib/termdesc.c index 78238cc55..77e8c38c8 100644 --- a/src/lib/termdesc.c +++ b/src/lib/termdesc.c @@ -745,7 +745,6 @@ int interrogate_terminfo(tinfo* ti, const char* termtype, FILE* out, unsigned ut // need to send the identification queries. the controls are sufficient. bool minimal = (ti->qterm != TERMINAL_UNKNOWN); if(send_initial_queries(ti->ttyfd, minimal)){ - free(ti->tpreserved); goto err; } } @@ -755,7 +754,6 @@ int interrogate_terminfo(tinfo* ti, const char* termtype, FILE* out, unsigned ut int termerr; if(setupterm(termtype, ti->ttyfd, &termerr)){ logpanic("Terminfo error %d for %s (see terminfo(3ncurses))\n", termerr, termtype); - free(ti->tpreserved); goto err; } tname = termname(); // longname() is also available