From 064da8acb985e86a438e656c91c7c9078392541e Mon Sep 17 00:00:00 2001 From: nick black Date: Thu, 7 May 2020 14:32:33 -0400 Subject: [PATCH] ncreader_destroy() / ncreader_plane() --- include/notcurses/notcurses.h | 6 ++++-- src/lib/reader.c | 9 ++++++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/include/notcurses/notcurses.h b/include/notcurses/notcurses.h index 026d62d8c..86da64ef2 100644 --- a/include/notcurses/notcurses.h +++ b/include/notcurses/notcurses.h @@ -2768,14 +2768,16 @@ API int ncplane_qrcode(struct ncplane* n, int maxversion, const void* data, size API struct ncvisual* ncvisual_from_plane(struct ncplane* n); // ncreaders provide freeform input in a (possibly multiline) region, -// supporting readline keybindings. -API struct ncreader* ncreader_create(struct ncplane* n); +// supporting readline keybindings. 'rows' and 'cols' both must be negative. +// there are no restrictions on 'y' or 'x'. creates its own plane. +API struct ncreader* ncreader_create(int rows, int cols, int y, int x); // empty the ncreader of any user input, and home the cursor. API int ncreader_clear(struct ncreader* n); API struct ncplane* ncreader_plane(struct ncreader* n); +// destroy the reader and its bound plane. API void ncreader_destroy(struct ncreader* n); #undef API diff --git a/src/lib/reader.c b/src/lib/reader.c index b0cc089c4..7ccc33542 100644 --- a/src/lib/reader.c +++ b/src/lib/reader.c @@ -1,14 +1,21 @@ #include "internal.h" -ncreader* ncreader_create(ncplane* n){ +ncreader* ncreader_create(int rows, int cols, int y, int x){ + // FIXME } // empty the ncreader of any user input, and home the cursor. int ncreader_clear(ncreader* n){ + // FIXME } ncplane* ncreader_plane(ncreader* n){ + return n->ncp; } void ncreader_destroy(ncreader* n){ + if(n){ + ncplane_destroy(n->ncp); + free(n); + } }