From dfb5334f18e28c5ce6dcc190771957a8baa0b9b3 Mon Sep 17 00:00:00 2001 From: Adam Pash Date: Wed, 7 Sep 2016 13:29:11 -0400 Subject: [PATCH] fix: encoding request response as null This fixes an issue with gzipped content --- src/extractor/generic/content/extract-clean-node.test.js | 2 +- src/resource/utils/fetch-resource.js | 1 + src/resource/utils/fetch-resource.test.js | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/extractor/generic/content/extract-clean-node.test.js b/src/extractor/generic/content/extract-clean-node.test.js index f7bae528..e1a959ee 100644 --- a/src/extractor/generic/content/extract-clean-node.test.js +++ b/src/extractor/generic/content/extract-clean-node.test.js @@ -26,7 +26,7 @@ describe('extractCleanNode(article, $, { cleanConditionally })', () => { // console.log(result) // console.log(bestNode.html()) - assert.equal($(bestNode).text().length, 3652) + assert.equal($(bestNode).text().length, 2687) }) }) diff --git a/src/resource/utils/fetch-resource.js b/src/resource/utils/fetch-resource.js index d043dd71..7263d9e6 100644 --- a/src/resource/utils/fetch-resource.js +++ b/src/resource/utils/fetch-resource.js @@ -23,6 +23,7 @@ export default async function fetchResource(url) { url: parsedUrl, headers: REQUEST_HEADERS, timeout: FETCH_TIMEOUT, + encoding: null, } const { response, body } = await get(options) diff --git a/src/resource/utils/fetch-resource.test.js b/src/resource/utils/fetch-resource.test.js index dfaefee6..16347ba7 100644 --- a/src/resource/utils/fetch-resource.test.js +++ b/src/resource/utils/fetch-resource.test.js @@ -13,7 +13,7 @@ describe('fetchResource(url)', () => { const url = 'http://theconcourse.deadspin.com/1786177057' const { body, response } = await fetchResource(url) - assert.equal(typeof body, 'string') + assert.equal(typeof body, 'object') }) })