Commit Graph

396 Commits (5443b7e8f300a0084abde7354360ecbe909178bb)

Author SHA1 Message Date
Manos Pitsidianakis dcccd303ac
melib/mbox: rename MboxReader to MboxFormat 4 years ago
Manos Pitsidianakis 22a64e2d76
melib: Remove unnecessary "pub use" std exports 4 years ago
Manos Pitsidianakis 781a1d0e1b
melib/backends: add collection() method to MailBackend
Keep track of the Collection state in the backend side
4 years ago
Manos Pitsidianakis 2f47f1eebd
melib/jmap: fix mailbox children relationships being ignored 4 years ago
Manos Pitsidianakis a697dfabbd
melib/jmap: use receivedAt as alternative to Date in Envelope gen 4 years ago
Manos Pitsidianakis 23997bdec0
melib/jmap: add UTCDate queries in EmailFilterCondition
Not necessarily working, added as stubs for future work

Closes #62
4 years ago
Manos Pitsidianakis 50cd81772f
melib/jmap: impl watch() with polling
Concerns #22
4 years ago
Manos Pitsidianakis 62db7d7f32
melib/jmap: put JmapSession behind mutex
And deserialize API urls to Arc<String>.
4 years ago
Manos Pitsidianakis db69349251
melib/notmuch: avoid parsing entire email in Envelope creation 4 years ago
Manos Pitsidianakis 806254436b
melib/notmuch: add AccountHash field to NotmuchDb 4 years ago
Manos Pitsidianakis 4f164dc700
melib/notmuch: cleanup Query new() method 4 years ago
Manos Pitsidianakis 829f1243fb
melib/imap: fix invalid FETCH edge case
If mailbox was empty, this FETCH would request "0:*" which is an invalid
message set since message sequence numbers start with 1.
4 years ago
Manos Pitsidianakis 1be30968ca
melib/mbox: fix FreeBSD compilation
Reported in #92
4 years ago
Manos Pitsidianakis 92475c349a
melib/mbox: return Result in file locking 4 years ago
Zisu Andrei 0034f195e3
melib/imap: Lazy evaluate idle capability
With the eager evaluation, you run the risk of checking the capabilities
store before any connection to the server may have been opened.
Therefore, the capabilities uid_store will be empty and it will fall
back to poll_with_examine even if the server might have support for
idle.
4 years ago
Manos Pitsidianakis b2e853dd7b
melib/imap: update unseen count on \Seen set_flags() 4 years ago
matzipan@gmail.com aa503deb76
melib/imap: Set special usage attributes for INBOX
Without this change, the usage is not correctly identified when calling
imap_mailboxes in the imap backend.
4 years ago
Manos Pitsidianakis fee8f5b575
melib/backends: move IsSubscribedFn to backends mod 4 years ago
Manos Pitsidianakis 7e977fe627
melib/imap/cache/sync: explicitly remove new seen messages from unseen counter 4 years ago
Manos Pitsidianakis 09684e821d
melib/imap: check INBOX when pausing IDLE 4 years ago
Manos Pitsidianakis 68f9d1220b
melib/imap: remove DoubleEndedIterator for ImapLineIterator 4 years ago
Manos Pitsidianakis 1408690a9a
melib/imap: don't retry watch conn on non-network error 4 years ago
Manos Pitsidianakis bedf181aff
melib/imap: examine all mailboxes before idle 4 years ago
Manos Pitsidianakis 9dd21eea50
melib/threads: prefer local ThreadNode env_hash
When inserting an envelope in a thread and its Message-ID already exists
with an associated envelope, overwrite the association if the previous
associated envelope is from a foreign mailbox and current envelope is
not. This happens when mail from a sent folder has been inserted in eg
your INBOX, but somehow INBOX has a copy of your own message as well.
This can happen when mailing lists that send you copies of your own
posts.

The problem with this was that in IMAP your mailing list copy was unseen
and you could not mark it seen because the thread only knew about your
Sent mailbox copy.
4 years ago
Manos Pitsidianakis 4939a1ad9e
melib/imap: remove some debug prints 4 years ago
Manos Pitsidianakis 8e7583a32f
melib/imap: don't clear mailbox counts before fetching 4 years ago
Manos Pitsidianakis 5f6b4745b8
melib/imap: don't use UNSEEN select response for unseen count
UNSEEN field in SELECT/EXAMINE response is meant to be the message
sequence number of the first unseen message, not the count of unseen
messages.
4 years ago
Manos Pitsidianakis 76c1c1a213
melib/imap: don't examine unloaded mailboxes for updates
In examine_updates() which is periodically executed in the IMAP watch
thread, the mailbox's contents get fetched regardless if the user has
fetched the mailbox before. That means eg a large mailbox that was
unused by the user might perform a large fetch all of a sudden without
the user's knowledge/touch.

Add `warm` property in ImapMailbox that states whether the mailbox has
been loaded before in current execution.

Closes #88 IMAP: don't examine unloaded mailboxes for updates, just for message count stats
4 years ago
Manos Pitsidianakis ddfadc748d
melib/imap: don't fetch RFC822 except when requested
In some cases when handling new server events, the entire body message
was unnecessarily fetched.

Closes #87 IMAP: don't fetch RFC822 except when requested
4 years ago
Manos Pitsidianakis 92c12d3526
melib/imap: implement OAUTH2 authentication 4 years ago
Manos Pitsidianakis 2ef2add67f
imap: fix untrimmed query str resulting in invalid search criteria in cyrus 4 years ago
Manos Pitsidianakis f9ce5327c2
melib/imap: fix some LazyCountSet logic errors in sync 4 years ago
Manos Pitsidianakis f0800f38a8
melib/maildir: make MaildirOp return Result<PathBuf> 4 years ago
Manos Pitsidianakis a34f0aac5b
melib: fix bincode serialization
Previous commit changed bincode deserializes in maildir and sqlite3.rs
from bincode::deserialize_from to using bincode::config::DefaultOptions
and bincode::Options trait's method deserialize_from.

However, these two different deserializes use a different default
settings: https://github.com/servo/bincode/issues/348

Specifically, varint encoding for integers is the default for
DefaultOptions but not when using bincode::{de,}serialize_* functions.
That means that serialized structs were not able to be deserialized.
This commit makes all {de,}serializations use the DefaultOptions
interface rather than the top level functions.
4 years ago
Manos Pitsidianakis 353ac2d029
melib: set upper limit for bincode deserialize
If struct memory layout changes, bincode deserialize fails with memory
allocation error of an obscene amount of bytes. Set upper limit to
deserialized bytes in each place deserialize happens.
4 years ago
Rudi Horn f1bdae65ee
melib/jmap: add HTTP redirect policy to client
Meli currently uses the .well-known/jmap URL and the RFC8620 requires that any redirects are followed (https://tools.ietf.org/html/rfc8620#section-2.2). This small change allows redirects to happen.
4 years ago
Manos Pitsidianakis 00f5c4b9c0
melib/maildir: split parsing into big chunks 4 years ago
Manos Pitsidianakis 662706607b
melib: remove memmap dependency
It's unmaintained, and the IO performance gains are negligible
4 years ago
Manos Pitsidianakis 91fe7435f7
melib/imap: add suggestion on STARTTLS error
If server port is 993 (IMAPS) and starttls is enabled, suggest turning
it off if starttls fails.
4 years ago
Manos Pitsidianakis 7a9c150f33
melib/imap: fetch References header along with ENVELOPE
Threading was broken if information was needed from References header.
For example, mailman might alter some Message-IDs when using its NNTP
bridge and the complete references are necessary to rebuild the thread,
which is only available in References whereas ENVELOPE has only
In-Reply-To.
4 years ago
Manos Pitsidianakis b9f4d718c7
melib/sqlite3: reset db on version mismatch 4 years ago
Manos Pitsidianakis d51d0187a6
melib/imap: change byte cache String -> Vec<u8> 4 years ago
Manos Pitsidianakis 2944fc992b
melib/imap/untagged: handle EXPUNGE if our MSNs invalid 4 years ago
Manos Pitsidianakis 535d04f4f0
melib/imap/untagged: lower mbox count on EXPUNGE events 4 years ago
Manos Pitsidianakis cd68008e67
melib: Implement delete_messages for IMAP, Maildir 4 years ago
Manos Pitsidianakis 5d968b7c40
imap: fix out of bounds panic on receive EXPUNGE
Closes #82
4 years ago
Manos Pitsidianakis a1e3f269de
melib/imap: don't manually check for mailbox permissions 4 years ago
Manos Pitsidianakis e556191bab
melib/imap: hide LOGIN from debug log 4 years ago
Manos Pitsidianakis ce559b05d7
melib/imap: EXAMINE instead of SELECT in IDLE connection 4 years ago
Manos Pitsidianakis 36cc0d4212
melib/jmap: implement refresh()
Closes #77
4 years ago
Manos Pitsidianakis 425f4b9930
melib/jmap: add Type parameter to Id, State
Make Id, State have a type parameter to the object it refers to (eg
`Id<EmailObject>`) instead of just a String
4 years ago
Manos Pitsidianakis 19d4a191d8
melib/jmap: add email state sync 4 years ago
Manos Pitsidianakis 4cf0b9ffec
melib/jmap: impl copy_messages()
Closes #76
4 years ago
Manos Pitsidianakis 28deba708c
melib/imap: check if FETCH reply was intended for us
After sending a FETCH, the command results might be mixed with
unsolicited FETCH replies. Check if that happens.
4 years ago
Manos Pitsidianakis ea0fb114e1
melib/imap: delete reverse_modseq storage
Modsequences are not unique, and many messages may share the same
modsequence. So storing a reverse mapping of modsequences to messages is
invalid.
4 years ago
Manos Pitsidianakis 8e036f045c
melib/imap: accept literal astrings in bodystructure 4 years ago
Manos Pitsidianakis 3210ee5c67
melib/jmap: impl save() message
Closes #60
4 years ago
Manos Pitsidianakis cfc380b47d
melib/jmap: allow empty to,from etc fields in EmailObject 4 years ago
Manos Pitsidianakis 40b63cc3e0
melib/imap: fix unseen count on cache sync 4 years ago
Manos Pitsidianakis 38eff71971
IMAP: don't show \Recent flag as tag
Closes #74
4 years ago
Manos Pitsidianakis 3004789f32
melib/imap: FETCH comma-sep list on untagged Recent response
FETCHing RECENT messages when receiving an untagged RECENT response from
the server didn't separate the message numbers with comma but with
space, which is invalid.
4 years ago
Manos Pitsidianakis 9bafba3905
melib/imap: don't print raw bytes in debug prints 4 years ago
Manos Pitsidianakis 98949a4a72
melib/imap: expand special mailbox detection cases 4 years ago
Manos Pitsidianakis e8f3b6aa24
melib/imap: check for max uid == 0 when resyncing 4 years ago
Manos Pitsidianakis 64a2af3777
melib/email: smarter attachment detection
Look for Content-Disposition: attachment to detect attachments
4 years ago
Manos Pitsidianakis e518b3f16d
melib/imap: use SystemTime for IMAP server timeout 4 years ago
Manos Pitsidianakis 3618bdcffb
melib/imap: treat server input as bytes
Server input was assumed valid ascii and converted haphazardly to &str.
Don't do that, since it might not be valid UTF8.
4 years ago
Manos Pitsidianakis 9b0180fdbc
melib/email/parser: impl RFC5322 parser for dates 4 years ago
Manos Pitsidianakis 0e2641f7ed
melib/imap: always retry connection in watch() 4 years ago
Manos Pitsidianakis a5b6f29f2b
melib/imap: ensure connection is alive before fetching bytes/flags 4 years ago
Manos Pitsidianakis 3b10fa3895
melib/imap: set 9min tcp keepalive on connection 4 years ago
Manos Pitsidianakis dee62cc118
melib/imap: fix NoSelect mailboxes not showing up as subscribed 4 years ago
Manos Pitsidianakis 17a4ccdcbc
melib/imap: perform reconnect on IDLE failure 4 years ago
Manos Pitsidianakis 670675edcc
melib/imap: impl LIST-EXTENDED
Closes #69
4 years ago
Manos Pitsidianakis 352f7505fc
melib/imap: don't poll \Noselect mailboxes for updates 4 years ago
Manos Pitsidianakis 06a58a70bd
melib/imap: introduce a conf flag for server timeout
timeout integer                       (optional) Timeout to use for server connections in seconds.  A timeout of 0 seconds means there's no timeout.  (16)
4 years ago
Manos Pitsidianakis 96985c9c1f
melib/imap: set conn to Err if watch returns Err 4 years ago
Manos Pitsidianakis 7c6e3658c7
melib/imap: try NOOPing in connect() 4 years ago
Manos Pitsidianakis 5079881a4c
melib/imap: add tags to tag_index when setting new tags 4 years ago
Manos Pitsidianakis 6d9cdce923
melib/imap: don't fail utterly if cache fails on fetch
Show notice to user, and then try a fresh fetch. Also try resetting the
cache if possible.
4 years ago
Manos Pitsidianakis 7b324359c5
melib/imap: ignore case for supported capability report in
MailBackendExtensionStatus
4 years ago
Manos Pitsidianakis 4829e13c47
melib/maildir: impl copy_messages for Maildir 4 years ago
Manos Pitsidianakis 9e20f6556a
melib/imap: refactor command generation on copy_messages 4 years ago
Manos Pitsidianakis d00055fdb1
melib/imap: update online instant only on server read IO 4 years ago
Manos Pitsidianakis 1751509739
melib/imap: prevent false IDLE wakeups
Prevent IDLE loop waking up when receiving continuation "+ " lines
4 years ago
Manos Pitsidianakis 927a0c3cc0
melib/imap: prevent panic in untagged fetch response 4 years ago
Manos Pitsidianakis c0c588be9c
melib/maildir: add message flag initialize in bytes
Maildir flags from filesystem path was not set correctly on Envelope
initialization in maildir backend
4 years ago
Manos Pitsidianakis c6c0da7fcb
melib: cleanup commit
Cleanup melib module exports, add some document tests, change some
documentation.
4 years ago
Manos Pitsidianakis d14f26569e
melib/email/parser: Add rfc5322 compliant parser for MessageID 4 years ago
Manos Pitsidianakis f8f3f1817d
melib/notmuch: fix search
Search was not available, it had been left out of date
4 years ago
Manos Pitsidianakis b4fe34eacf
melib/imap: add ImapCache trait 4 years ago
Manos Pitsidianakis e878c50af5
tools/imapshell: actually send LOGOUT instead of just closing socket 4 years ago
Manos Pitsidianakis 75f59ee726
melib/imap: split by lines when reading IDLE unsolicited responses 4 years ago
Manos Pitsidianakis be2d268a20
melib/imap: build uid<>msn cache in {select,examine}_mailbox() 4 years ago
Manos Pitsidianakis 209bd98814
melib/imap: fix cache not being updated in some events 4 years ago
Manos Pitsidianakis a37faf0bec
Fix imapconn IMAP shell binary
IMAP shell hasn't been working since updating IMAP to async. Now it
works by using block_on executor.
4 years ago
Manos Pitsidianakis e9a80b32ac
melib/imap: small cleanups 4 years ago
Manos Pitsidianakis 14663e46b9
Remove some old TODO comments 4 years ago
Manos Pitsidianakis 4217839155
melib/email: remove Envelope::from_token 4 years ago
Manos Pitsidianakis 96a3da3d7b
melib/imap: fix deflate feature flags 4 years ago