Manos Pitsidianakis
4026e25428
melib/notmuch: add some doc comments
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
ca7d7bb95d
melib/notmuch: use message freeze/thaw for flag changes
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
ebe1b3da7e
melib/notmuch: wrap *mut struct fields in NonNull<_>
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
506ae9f594
melib/error: Add ErrorKind::LinkedLibrary variant
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
b3079715f6
melib/smtp: disable flakey test_smtp()
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
86bbf1ea57
melib/notmuch: refresh NotmuchMailbox counts when setting flags
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
1b0bdd0a9a
melib/notmuch: split queries and mailbox into submodules
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
7412c23870
Bump meli version to 0.8.5-rc.3
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
e19f3e572c
Cargo-sort all Cargo.toml files
...
With:
cargo sort --grouped --order package,bin,lib,dependencies,features,build-dependencies,dev-dependencies,workspace meli
cargo sort --grouped --order package,bin,lib,dependencies,features,build-dependencies,dev-dependencies,workspace melib
cargo sort --grouped --order package,bin,lib,dependencies,features,build-dependencies,dev-dependencies,workspace tools
cargo sort --grouped --order package,bin,lib,dependencies,features,build-dependencies,dev-dependencies,workspace fuzz
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
f900dbea46
Use cargo-derivefmt to sort derives alphabetically
...
Used https://github.com/dcchut/cargo-derivefmt
With command:
cargo install --locked \
--git https://github.com/dcchut/cargo-derivefmt \
--bin cargo-derivefmt \
--rev 2ff93de7fb418180458dd1ba27e5655607c23ab6
Since it's not on crates.io at the moment.
Sample diff:
-#[derive(Debug, Deserialize, Clone, Serialize)]
+#[derive(Clone, Debug, Deserialize, Serialize)]
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
3a70979483
Update minimum rust version from 1.65.0 to 1.68.2
...
Found with `cargo msrv --bisect --min 1.67.0`
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
10 months ago
Manos Pitsidianakis
d16afc7d8d
Bump version to 0.8.5-rc.2
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
63a63253d7
melib/datetime: use type alias for c_char
...
On arm64, it's u8, not i8.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
10c3b0eabe
Bump version to 0.8.5-rc.1
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Andrei Zisu
64898a0583
melib/imap: Make UIDStore constructor pub
...
I honestly forget exactly why this change is needed, so I need to
recheck.
11 months ago
Andrei Zisu
77a8d9e2c2
melib: Make ModSequence publicly accessible
...
This way it can be imported from this namespace in depending code.
11 months ago
Manos Pitsidianakis
23c15261e7
mail/view: abstract envelope view filters away
...
Modularize an envelope view by introducing a stack of "view filters".
Example uses:
- html email can have a view on top of it that is plain text conversion
- selecting and viewing text/* attachments is just appending a new filter at
the stack
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
1c1be7d6c9
melib/address: add display_name(), display_slice(), display_name_slice() methods
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
23507932f9
imap: update cache on set_flags
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
6506fffb94
Rewrite email flag modifications
...
Flag and tag modifications are now somewhat typed better, and the
frontend applies them on its own on success. This means that if you set
an unseen mail as seen but it was already seen in the backend, you will
see the change locally. Previously it would remain unseen.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
f81a1e2338
Bump version to 0.8.4
...
0.8.3 had a misbehaving test.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
ef30228e08
melib/draft: fix failing test
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
bfc78a0803
melib/compose: replace CRLF with LF when editing
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
af241d25cb
melib: bump version to 0.8.3
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
ac2a5dcdd1
melib: add display() method for Address
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
688e39a67e
Fix clippy lints
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
8a21be2177
melib/imap: replace splice with truncate
...
splice() was calling memmove, it is a really inefficient way of
truncating a string.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
11 months ago
Manos Pitsidianakis
f702dc220c
Fix new clippy lints.
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Andrei Zisu
e95c275d68
Remove duplicate end sequence
...
Signed-off-by: Andrei Zisu <matzipan@gmail.com>
1 year ago
Andrei Zisu
3105a0373b
Add quit command
...
Signed-off-by: Andrei Zisu <matzipan@gmail.com>
1 year ago
Andrei Zisu
7aec5b8e78
Fix SMTP example doc
...
Signed-off-by: Andrei Zisu <matzipan@gmail.com>
1 year ago
Manos Pitsidianakis
e88957ae6e
melib/backends: add extra_submission_headers field in MailBackendCapabilities struct
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
3d85ca2edf
Bump version to 0.8.2
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
7888d8b2a5
melib/utils/xdg: fix doc test compilation
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
7eed82783a
Bump version to 0.8.1
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
fe0a96f085
melib: update to 2021 edition
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
9b9c38f769
mellib/imap: don't flood user with sqlite3 errors if db is corrupted
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
c43aeb0eb1
melib/email/parser: fix invalid address parse on folded values
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
6476985ce6
Add Cross.toml for aarch64-unknown-linux-gnu builds
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
a615b4701b
dependencies: embed xdg-utils crate
...
No reason to have it out of the tree.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
85af524458
email/parser.rs: fix invalid mailto() results when body field exists
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
2dc2940586
melib/build.rs: add feature to use cache instead of downloading unicode data
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
49a38a23bf
jmap: fix invalid Type link references
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
b4f2f33576
remove deflate feature; make it a hard dependency
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
a337e2269e
contacts: refactor module structure
...
To prepare for more functionality, refactor contacts module.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Damian Poddebniak
5459a84f3d
chore: Update to imap-codec 1.0.0 (w/o `-beta`)
1 year ago
Manos Pitsidianakis
59513b2670
melib/jmap: implement Backend::submit(), server-side submission
...
Well this was more complex that it should have been. And not very
optimized because we're not using pipelining in the submit() path:
1. first upload email bytes as a Blob object. This requires a standalone
API post call at a specific url so it cannot be changed with followup
calls to reference the blob's id.
2. Create an EmailObject in the drafts folder.
3. Create an EmailSubmission object referencing the email id of prevous
call. Unfortunately I cannot get the Result Reference to work in
stalwart jmap, so for now this is too a separate transaction.
Caveat emptor: Errors might not be returned to the user.
Closes #277 .
https://git.meli.delivery/meli/meli/issues/277
https://git.meli.delivery/meli/meli/pulls/279
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
38bc1369cc
melib/jmap: add an Identity type.
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
5d8f07c805
melib/jmap: rename some objects better
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
b95f778335
melib/jmap: move JmapSession to its own module
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
29fd8522e6
melib/jmap: implement Backend::create_mailbox()
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
31982931f5
melib/jmap: use Argument<OBJ> (value or resultreference) where appropriate
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
d9467d5fcd
melib/jmap: save all core capabilities to session store
...
We will need this in the future when we're going to support extra
extensions like Blob and also now to support server submission.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
11432ba2c3
melib/jmap: make `null` fields into Option<_>s
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
4f9b97736a
melib/jmap: Rename EmailImport to EmailImportObject
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
6ebdc7f9ae
melib/jmap: add Id<_>::empty() contructor
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
37a787e6bb
melib/jmap: use IndexMap instead of HashMap
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
c875dda496
melib/jmap: add last_method_response field to Connection
...
For book keeping.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
f7a4741bf1
melib/jmap: add jmap-trace feature
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
8551e1ba0b
clippy: fix new 1.72 default clippy lints
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
974b3a5305
Update bitflags, rusqlite dependencies
...
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
946309c6f3
melib: do some small parser refactoring
...
- Use HeaderName in parsers instead of raw byte strings.
- Use byte literal constants where appropriate instead of repeating
&b"___"[..]
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
66c21ab173
melib/email: move StandardHeader to its own module
...
Extract StandardHeader code to its own module to reduce name.rs
line-count size.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
3963103d55
contacts: prevent duplicate contact creation
...
When adding contacts from an envelope view, its hash/id/key was a random
Uuidv4, so it was always possible to add a contact again and again with
no limits. Now, the id is calculated from the hash of the email address
and display name, preventing duplicate additions.
Note that the hash algorithm is not supposed to be stable across
versions, meaning that in the future the same contact might have a
different hash. This means a more sophisticated method for
detecting/disallowing dupes must eventually be introduced.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
a1e7006186
melib: move Sort{Order,Field} to utils mod
...
We want to use SortOrder enum for non-thread purposes in the next
commit, so move it out of the thread module.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
b3858de2f4
melib/error: impl From<io::ErrorKind> for ErrorKind
...
We inspect errors in the frontend to check for network errors. If the
network error comes from std::io, this would get converted to an Error
with description "timed out", kind OSError, and source the actual
networking error.
This commit converts network std::io::ErrorKinds into appropriate
native ErrorKinds.
Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>
1 year ago
Manos Pitsidianakis
dc2b00442b
melib: run rustfmt and cargo-sort
1 year ago
Manos Pitsidianakis
da8e810448
melib/connections: remove leftover debug prints
1 year ago
Damian Poddebniak
4f6081b663
chore: Update to `imap-codec 1.0.0-beta`.
1 year ago
Manos Pitsidianakis
df638cceec
melib/connections: remove stale failing doc code example
...
This leftover doc test/example was failing to compile, so remove it.
1 year ago
Manos Pitsidianakis
97d3686815
melib/connections: use Happy Eyeballs algorithm Ꙭ
...
This commit adds a Happy Eyeballs [1] implementation taken from the
happy-eyeballs crate, which is in public domain.
While the function lookup_ip[0] iterates through the addresses returned by
A and AAAA records from a DNS lookup, it returns the first one which
always is an IPv4 address, unless there only is an AAAA record.
RFC6555 [1] recommends an algorithm for choosing the fastest address to
connect to, called "Happy Eyeballs". Ꙭ
[0]: melib/src/utils/connections.rs:497
[1]: https://www.rfc-editor.org/rfc/rfc6555
Fixes #268
1 year ago
Manos Pitsidianakis
5c2b04719b
Normalize std::fmt::* imports
1 year ago
Manos Pitsidianakis
7c7f6e1923
melib/thread: don't increase Thread length for duplicates
...
If an envelope that was already in the Threads object was inserted,
the only modification would be to erroneously increase the Thread len by
one.
1 year ago
Manos Pitsidianakis
84081f4ed7
melib/nntp: minor style fix
1 year ago
Manos Pitsidianakis
bf543855dc
melib/email: add PartialEq<str> for MessageID
1 year ago
Manos Pitsidianakis
448e0635e0
melib/nntp: log error when command length exceeds 512 octets
...
According to RFC 3977:
> Command lines MUST NOT exceed 512 octets, which includes the
> terminating CRLF pair
This commit adds a log::error entry when any sent command exceeds that
limit and recommends the user to report this as a bug.
1 year ago
Manos Pitsidianakis
4e654d2d02
melib/nntp: limit LIST ACTIVE command length to 512 octets
...
According to RFC 3977:
> Command lines MUST NOT exceed 512 octets, which includes the
> terminating CRLF pair
Sending a `LIST ACTIVE` command with lots of newgroups and passing the
512 byte limit is therefore invalid. This commit splits the mailboxes in
chunks and sends a separate command for each maximal chunk that has
a valid length.
Fixes #269 .
Reported-by: r3k2
1 year ago
Manos Pitsidianakis
40d4ecefa0
melib/nntp: accept invalid (non-ascii) address comment text
...
NNTP servers may return addresses that are not RFC 5322 compliant. An
address with a comment with non-ascii characters will make the parser loop indefinitely.
Fixes #269 .
1 year ago
Manos Pitsidianakis
8cb2a515e1
melib/smtp: use localhost in lieu of 127.0.0.1 for CI
1 year ago
Manos Pitsidianakis
ae25ffba43
melib/smtp: don't do plain EHLO before starting Tls connection
1 year ago
Manos Pitsidianakis
1e084c1d85
melib: move backends out of the backends module
...
No reason to have such a deep module tree.
1 year ago
Manos Pitsidianakis
9216e7bc65
melib/connections: add opt id string for tracing
1 year ago
Manos Pitsidianakis
8ecdb6df31
melib/imap: add imap-trace feature
1 year ago
Manos Pitsidianakis
b65934facc
melib/nntp: add nntp-trace feature
1 year ago
Manos Pitsidianakis
89c90f224a
melib: add `nntp` feature
1 year ago
Manos Pitsidianakis
7db930cabd
melib: rename `jmap_backend` feature to `jmap`
1 year ago
Manos Pitsidianakis
e9f09a153c
melib: rename `mbox_backend` feature to `mbox`
1 year ago
Manos Pitsidianakis
fe7dcc508e
melib: rename `notmuch_backend` feature to `notmuch`
1 year ago
Manos Pitsidianakis
fe027fa300
melib: rename `maildir_backend` feature to `maildir`
1 year ago
Manos Pitsidianakis
129f10911b
melib: rename `imap_backend` feature to `imap`
1 year ago
Manos Pitsidianakis
4874e30f3c
melib: add smtp-trace feature
...
If it's enabled, every read/write in an SMTP transaction will be logged
on TRACE level.
1 year ago
Manos Pitsidianakis
073d43b9b8
melib/test: move data files to data subdir
1 year ago
Manos Pitsidianakis
8e698cabcf
Fix unreachable-pub and disjoint-capture lint errors
1 year ago
Manos Pitsidianakis
bb7e119ade
Add gitea CI workflows
1 year ago
Manos Pitsidianakis
29b43e2c88
melib/datetime: replace mktime with timegm
1 year ago
Manos Pitsidianakis
6280bc75e5
melib/jmap: fix blob download URL formatting
1 year ago
Manos Pitsidianakis
48a10f7241
melib: remove unused BackendOp::fetch_flags() method
1 year ago
Manos Pitsidianakis
0219dc8707
melib/jmap: respect max_objects_in_get when fetching email
...
Fixes #144
1 year ago
Manos Pitsidianakis
c4c245ee19
melib/jmap: respect danger_accept_invalid_certs setting
1 year ago
Manos Pitsidianakis
e9cd800f49
melib/nntp: add support for storing read status locally
1 year ago
Manos Pitsidianakis
ab418c1d39
pgp: refresh documentation, fix encryption/signing
...
Closes #259
1 year ago
Manos Pitsidianakis
4e55fbc90d
nntp: add SEEN flag to all envs, since NNTP has no flags
1 year ago
Manos Pitsidianakis
13fe64a027
Cache pgp signature verification results
1 year ago
Manos Pitsidianakis
6086a3789d
Fix libgpgme segfault error and re-enable gpg
...
Closes #255
1 year ago
Manos Pitsidianakis
5b5869a2ec
logging: re-enable print to stderr ifdef MELI_DEBUG_STDERR
1 year ago
Manos Pitsidianakis
866166eb8e
attachments: don't print parsing error for empty bytes
1 year ago
Manos Pitsidianakis
d4e605c098
Add tagref source code annotations
...
Source Code Annotation Tags:
Global tags (in tagref format <https://github.com/stepchowfun/tagref >)
for source code annotation:
- [tag:hardcoded_color_value] Replace hardcoded color values with user
configurable ones.
- [tag:needs_unit_test]
- [tag:needs_user_doc]
- [tag:needs_dev_doc]
- [tag:FIXME]
- [tag:TODO]
- [tag:VERIFY] Verify whether this is the correct way to do something
- [tag:DEBT] Technical debt
1 year ago
Manos Pitsidianakis
d93ee413a7
melib/datetime: add timestamp_to_string_utc
...
Tests were using `timestamp_to_string` which in turn uses `localtime_r`
which assumes the local machine's time zone. Use gmtime_r instead.
Fixes #252
1 year ago
Manos Pitsidianakis
b0e867eb68
Move src to meli/src
1 year ago
Manos Pitsidianakis
b5657201db
melib: fix doctest compilation errors
1 year ago
rek2
3803d788ab
if auth is false checks if config has password entry
1 year ago
rek2
b5f205b77b
add availability to use server_password_command in the nntp backend like in the IMAP backend
1 year ago
Damian Poddebniak
7c33f8999b
chore: Use published imap-codec 0.10.0.
1 year ago
Damian Poddebniak
34a54d3c05
docs: Add some `TODO( #222 )`s.
1 year ago
Damian Poddebniak
9d51b6bd52
chore: Update `imap-codec`.
1 year ago
Manos Pitsidianakis
7998e1e77e
melib/datetime: add missing LC libc constants for openbsd target_os
...
Fixes #242
"Compilation failure on master on OpenBSD" #242
1 year ago
Manos Pitsidianakis
619fbef129
melib/thread: recursively calculate update_show_subject()
...
Walk the entire thread tree and update show_subject collectively when a
new entry is added.
1 year ago
Manos Pitsidianakis
1bcc0bbece
melib/mbox: add mbox parsing test
1 year ago
Manos Pitsidianakis
e8e49e741b
melib/mbox: fix wrong per message offset
1 year ago
Manos Pitsidianakis
1dc1d86848
melib/shellexpand: fix infinite loop bug
...
Introduced in recent "fixing clippy lints" commit
1 year ago
Manos Pitsidianakis
ba7f5dce1c
listing/thread: fix display of threaded conversations tree structure
...
When missing intermediate and/or parent messages in a thread, the
printed thread tree branches were completely invalid. This commit makes
sure thread node entries that have no corresponding envelopes are
accounted for in the tree structure.
1 year ago
Manos Pitsidianakis
5f29faa640
melib: clippy lint fixes
1 year ago
Manos Pitsidianakis
f98e36cee5
melib: Replace old-style /*! module doc comments with //!
1 year ago
Manos Pitsidianakis
f0d88005fb
melib/email: change message/rfc822 Display repr
...
Put subject first.
1 year ago
Manos Pitsidianakis
e64923eeaa
melib/email/headers/names: fix debug_assert condition
...
On invalid parsings, _cnt can be equal to probe and chunk len because
the value won't be a valid header
1 year ago
Manos Pitsidianakis
f5cfbd32e6
melib/imap: on set_flags, update {un,}seen sets in all mailboxes
...
Some envelopes might be in several mailboxes, for example in Gmail's
implementation of IMAP.
1 year ago
Manos Pitsidianakis
5699baecfb
melib: add utils::{futures, random}
1 year ago
Manos Pitsidianakis
4da5366959
Remove bincode dep, use serde_json for sqlite3 values
1 year ago
Manos Pitsidianakis
fd0faade06
melib/imap: add connection instance id string for debugging in logs
...
- Add an ID field in ImapConnection and ImapStream that records where
each instance was created. This is useful for differentiating main
backend connections from watching thread connections (the ones that
listen to updates from the IMAP server with IDLE or polling).
- Add an imap_trace! macro that uses log::trace! internally but also
prepends the connection's ID string to each log line.
1 year ago
Manos Pitsidianakis
8f14a2373e
melib/imap: put imap-codec logic under the imap_backend feature
1 year ago
Damian Poddebniak
330887c4f5
refactor: Introduce imap-codec.
1 year ago
Damian Poddebniak
6c6d9f4b4e
chore: Improve ordering of `flag_impl!`s.
1 year ago
Damian Poddebniak
579372b4a7
chore: Improve readability of `Envelope`.
...
* Sorted according to RFC.
* Separated IMAP4rev1 and other values.
1 year ago
Manos Pitsidianakis
cd85d83324
melib/email: replace timestamp with Date value in message/rfc822 Display
1 year ago
Manos Pitsidianakis
e0257c9d8d
Run cargo-sort
1 year ago
Manos Pitsidianakis
27a4dcb916
Fix some rustdoc lints
1 year ago
Manos Pitsidianakis
bf615e7d93
melib/thread: check for case when envelope has its own message id in References and In-Reply-To
...
Emails sent from meli's gitea do this, and it makes them invisible in
thread listings.
1 year ago
Manos Pitsidianakis
b92a80a23a
melib/imap: resync even if UIDVALIDITY is missing from cache
...
I think this is related to #98 meli gets stuck on `set seen' for mail (threads) at random
https://git.meli.delivery/meli/meli/issues/98
1 year ago
Manos Pitsidianakis
f8623d4b2c
melib/imap: implement more ResponseCode cases
1 year ago
Manos Pitsidianakis
299c8e0f99
meli: restructure pub use melib::* imports
1 year ago
Manos Pitsidianakis
c5ecaceae1
melib/search: fix some search criteria in Query type
1 year ago
Manos Pitsidianakis
6bf1756de8
melib/search: implement more search criteria in Query type
1 year ago
Manos Pitsidianakis
23d95973d4
melib/backends/imap: add search.rs module
...
Add trait to convert melib::search::Query type to an IMAP appropriate
query string (search criteria).
1 year ago
Manos Pitsidianakis
6388bea9a0
melib/email/headers: fix &[u8] index in HeaderMap
1 year ago
Manos Pitsidianakis
d332e4578d
melib/headers: add proper Display impl for HeaderName
1 year ago
Manos Pitsidianakis
aebff3d3d9
melib: implement mailto RFC properly
...
This allows mailto links with `In-Reply-To` parameters to work properly.
PS Mailto links can be used with the `mailto MAILTO_URI` command
1 year ago
Manos Pitsidianakis
235fceaf21
melib: Add standard heeder constants in email::headers
...
Like `http` crate does
1 year ago
Damian Poddebniak
1eea8bab77
tests: Fix `test_imap_fetch_response`.
1 year ago
Damian Poddebniak
30866f752b
chore: Bypass rustfmt bug.
1 year ago
Manos Pitsidianakis
cc27639fca
melib/email/compose: use Envelope attachments when editing and don't add already existing headers
1 year ago
Manos Pitsidianakis
91557c2c43
mail/listing.rs: prevent list blank when refreshing account
...
Mail list would go blank if the currently focused account received a
Status update event.
1 year ago
Manos Pitsidianakis
428f752b20
Remove obsolete crate::components::mail::get_display_name()
1 year ago
Manos Pitsidianakis
8c671935f9
Add compose (pre-submission) hooks for validation/linting
...
compose-hooks run before submitting an e-mail.
They perform draft validation and/or transformations.
If a hook encounters an error or warning, it will show up as a notification.
The currently available hooks are:
- past-date-warn
Warn if Date header value is far in the past or future.
- important-header-warn
Warn if important headers (From, Date, To, Cc, Bcc) are missing or invalid.
- missing-attachment-warn
Warn if Subject, draft body mention attachments but they are missing.
- empty-draft-warn
Warn if draft has no subject and no body.
They can be disabled with [composing.disabled_compose_hooks] setting.
1 year ago
Manos Pitsidianakis
85d4316a6a
Replace old logging module with the `log` create
1 year ago
Manos Pitsidianakis
b1a7188771
Clippy fixes
1 year ago
Manos Pitsidianakis
39d9c2af3b
melib/smtp: fix test smtp server logic
2 years ago
Manos Pitsidianakis
d679a74450
melib/jmap: Implement Bearer token authentication
...
Fastmail now uses an API token in a http header for authentication.
This can be used either as a server_password or provided by a
server_password_command like oauth2.
2 years ago
Manos Pitsidianakis
d9c07def0f
Add command to select charset encoding for email
...
Open dialog to select charset with `d`.
2 years ago
Manos Pitsidianakis
939dc15e28
Fix melib tests
2 years ago
Manos Pitsidianakis
3adf72aed0
Add support for utf-7 encoding
...
Closes #175
2 years ago
Johannes Schilling
2447a2cbfe
melib/jmap: avoid relying on hardcoded hash values
...
The hash values seem to have changed in the meantime, or aren't the same
on all environments.
2 years ago
Manos Pitsidianakis
d7ec97f03b
Small rustfmt change
2 years ago
Johannes Schilling
fbc1007ff4
jmap: deserialize `null` to empty vec for messageId
...
The spec says MessageId can be `null`, handle that case and deserialize
it to an empty Vec.
2 years ago
cos
256a3e252e
Update minimum supported rust version
...
Code requires label_break_value feature, which was [stabilized][0] in
release 1.65.0 of the toolchain.
[0]: https://github.com/rust-lang/rust/pull/99332
2 years ago
Manos Pitsidianakis
11140b4a76
Fix test output
...
test_compose_reply_subject_prefix requires access to / path, and fails
when building with deb-dist
2 years ago
Johannes Schilling
12cb717bda
melib: add server_password_command to jmap
...
Move the handling of either `server_password` or
`server_password_command` from the imap backend to the common
`AccountSettings` struct and add it for jmap as well.
2 years ago
Manos Pitsidianakis
660bacb926
Add `mailto` command to open composer with initial values from mailto template
2 years ago
Manos Pitsidianakis
de2f46fe61
rustfmt changes
2 years ago
Manos Pitsidianakis
5443b7e8f3
melib/sieve: remove literal_map() parse combinator
2 years ago
Manos Pitsidianakis
3c847ad26a
melib/sieve.rs: add beginning of sieve parser
...
Concerns #153
Support filtering rules to move mails to folders #153 <https://git.meli.delivery/meli/meli/issues/153 >
2 years ago
Manos Pitsidianakis
2878bbb8c8
melib/addressbook: add parser for mutt alias file
2 years ago
Manos Pitsidianakis
40c6647db8
Fix multipart/related with main text/html part not displayed correctly
2 years ago
Manos Pitsidianakis
7606317f24
melib/notmuch: add support for virtual mailbox hierarchy
...
Add optional "parent" property to notmuch mailbox configuration.
Closes #167
https://git.meli.delivery/meli/meli/issues/167
2 years ago
Manos Pitsidianakis
5634f95553
Rename MeliError struct to Error
2 years ago
Manos Pitsidianakis
259aeb0087
Convert {Account,Mailbox}Hash from typedef to wrapper struct
2 years ago
Manos Pitsidianakis
7382e30160
Convert EnvelopeHash from typedef to wrapper struct
2 years ago
Manos Pitsidianakis
eaecc5ea12
melib/notmuch: remove hardcoded major .so version for non linux/macos target_os
...
Credits to http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/mail/meli/patches/patch-melib_src_backends_notmuch_rs?rev=1.1&content-type=text/x-cvsweb-markup for discovering this.
2 years ago
Manos Pitsidianakis
2224a7100f
melib/imap: reset imap cache on init error
2 years ago
Manos Pitsidianakis
7924aa8bfe
melib/jmap: fix compilation
2 years ago
Manos Pitsidianakis
bd22f986f0
melib: fix clippy lints
2 years ago
_
ded9adde61
More descriptive "Unimplemented" messages
2 years ago
Manos Pitsidianakis
b776409d6c
melib/thread.rs: add thread, env hash index fields
2 years ago
Manos Pitsidianakis
56fc43bcf8
melib: add As{Ref,Mut} impls for RwRef{,Mut}
2 years ago
Manos Pitsidianakis
88a1f0d4bc
melib/imap/parser: fix FETCH response parsing bug
...
Closes #160
Closes #128
2 years ago
Manos Pitsidianakis
64346dd3fe
melib/parsec: add map_res, quoted_slice, is_a, alt, take, take_literal
2 years ago
Manos Pitsidianakis
17b42b1a6c
melib/parsec: add json deserialization tests
2 years ago
Manos Pitsidianakis
6d20abdde7
melib/gpgme: add #[allow(deref_nullptr)] in bindgen tests
2 years ago
Manos Pitsidianakis
803d3414fd
melib/imap/managesieve: implement some rfc5804 commands
...
Try with managesieve REPL in src/managesieve.rs:
cargo run --bin managesieve-client ~/.config/meli/config.toml
"accountname"
rfc5804 <https://www.rfc-editor.org/rfc/rfc5804.html >
2 years ago
Manos Pitsidianakis
3697b7d960
melib/datetime: don't use LC_ category in place of LC_ masks in libc calls
...
LC_ masks are bit masks, whereas category values are not.
Concerns #159
[imap] all mail timestamps are zero/epoch #159
https://git.meli.delivery/meli/meli/issues/159
2 years ago
Manos Pitsidianakis
0ef4dde939
melib/jmap: wrap serde_json deserialize errors in human readable errors
2 years ago
Manos Pitsidianakis
55ed962425
melib/jmap: use server_url instead of server_hostname + server_port in config
2 years ago
Manos Pitsidianakis
16646976d7
compose: fix reply subject prefixes stripping original prefix
...
Unintelligent heuristic but should cover most cases?
Configurable subject response prefix #142
https://git.meli.delivery/meli/meli/issues/142
Closes #142
2 years ago
Manos Pitsidianakis
7e09b1807f
melib/collection: replace _Ref deref unwraps with expect()
2 years ago
Manos Pitsidianakis
129573e0fd
melib/maildir: rename root_path to root_mailbox
2 years ago
Manos Pitsidianakis
0c08cb737c
melib/jmap: mark mailboxes as subscribed on personal accounts
...
The spec https://jmap.io/spec-mail.html#mailboxes says a mailbox property `isSubscribed` should be considered true if the account is marked as `isPersonal`.
Closes #157
JMAP incompatible with Stalwart server #157 https://git.meli.delivery/meli/meli/issues/157
2 years ago
Manos Pitsidianakis
117d7fbe04
melib/jmap/rfc8620.rs: make private fields public
2 years ago
Manos Pitsidianakis
347be54305
melib/error: add NetworkErrorKind enum
2 years ago
Manos Pitsidianakis
c3fdafde3b
Documentation touchups
2 years ago
Manos Pitsidianakis
c6bdda03cf
melib/backends.rs: fix notmuch error shown on any missing backend
2 years ago
Manos Pitsidianakis
b87d54ea3f
melib/backends.rs: impl Into<BTreeSet<EnvelopeHash>> for EnvelopeHashBatch
2 years ago
Manos Pitsidianakis
b138d9bc61
melib: fix some clippy lints
2 years ago
Manos Pitsidianakis
388d4e35d6
listing/offline.rs: add in-progress messages while connecting in IMAP
2 years ago
Manos Pitsidianakis
9cbbf71e0f
melib/email/attachments: Add DecodeOptions struct for decoding
2 years ago
Manos Pitsidianakis
3688369278
melib/smtp: add smtp test
2 years ago
Manos Pitsidianakis
3c0f5d8274
melib/smtp: add BINARYMIME support to smtp client
...
Concerns #49
IMAP: Lemonade profile tracking issue
2 years ago
Manos Pitsidianakis
a72c96a26a
melib/smtp: add 8BITMIME support to smtp client
...
Concerns #49
IMAP: Lemonade profile tracking issue
2 years ago
Manos Pitsidianakis
8c7b001aa5
listing/conversations.rs: add `thread_subject_pack` command to pack different inner thread subjects in entry title
2 years ago
Manos Pitsidianakis
2de69d17f1
melib/compose: fix erroneous placement of newlnes for wrap_header_preamble suffix
2 years ago
Manos Pitsidianakis
cbe593cf31
mail/compose: add configurable header preample suffix and prefix for editing
...
This commit adds a new configuration value for the composing section of
settings. Quoting the documentation:
wrap_header_preamble: Option<(String, String)>
optional
Wrap header preample when editing a draft in an editor. This allows you
to write non-plain text email without the preamble creating syntax
errors. They are stripped when you return from the editor. The values
should be a two element array of strings, a prefix and suffix. This can
be useful when for example you're writing Markdown; you can set the
value to ["<!--",\ "-->"] which wraps the headers in an HTML comment.
2 years ago
Manos Pitsidianakis
a484b397c6
melib/notmuch: show informative error messages if libloading fails
...
Add instructions on how to solve this, and also a config setting
`library_file_path` to set the path manually if necessary.
2 years ago
Manos Pitsidianakis
eb5949dc9b
melib/error.rs: switch summary<->details identifiers
...
They are more intuitive like this.
2 years ago
Manos Pitsidianakis
da9c80ccfd
melib: Enhance SubjectPrefix with strip_prefixes_from_list() method
...
And make it public.
2 years ago
Manos Pitsidianakis
480000ebbb
melib/notmuch: show error if account directory does not contain ".notmuch" subdirectory
...
Bug reported by user on mailing list.
2 years ago
Manos Pitsidianakis
29042aba59
melib/datetime: add mbox date format parse
2 years ago
Manos Pitsidianakis
7650805c60
Bring stripped binary size down to 7MiB
2 years ago
Guillaume Ranquet
9205f3b8af
conf.rs: handle a per account mail order parameter
...
The new order parameter adds the possibility to specify a
sort order on a per account basis.
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
2 years ago
Manos Pitsidianakis
7fca5f01ef
melib/jmap: fix jmap build with isahc 1.7.2
2 years ago
Manos Pitsidianakis
daa900ec9a
Fix embed terminal in macos
...
Pseudoterminal wasn't created correctly on macos
2 years ago
Manos Pitsidianakis
ce269c64e1
conf: don't fail on `server_password_command`
...
Don't fail when parsing an IMAP config when it has
`server_password_command` set.
Closes #139
Meli stopped recognizing server_password_command configuration #139
2 years ago
Manos Pitsidianakis
d6355a3043
melib/email/parser: impl Debug for ParsingError
2 years ago
Manos Pitsidianakis
6a843d4983
melib/maildir: export list_mail_in_maildir_fs() function
2 years ago
Manos Pitsidianakis
9558b2ae92
melib/email: parse Cp1253 as windows1253 encoding
2 years ago
Manos Pitsidianakis
721891c295
Update nom dependency
3 years ago
Manos Pitsidianakis
2c23ca34cd
Update most Cargo dependencies
3 years ago
Manos Pitsidianakis
81184b182c
Add extra_identities configuration flag
...
Closes #119
Multi identies per account #119 https://git.meli.delivery/meli/meli/issues/119
3 years ago
Manos Pitsidianakis
aa3524dd30
melib/backends/notmuch: fix tag not being removed in set_flags()
...
May be related to #132
Cannot remove tags in the notmuch backend #132
> Running tag remove TAG on the notmuch backend does nothing. At a
> glance, this seems to be because NotmuchMailbox::set_flags never bothers
> to remove tags that are already present but not in the list of new tags.
> I could try fixing it, but I have no idea how the contribution process
> works here (my guess is the mailing list, but, well, #131 ).
https://git.meli.delivery/meli/meli/issues/132
3 years ago
Manos Pitsidianakis
f5dc25ae0d
conf.rs: check that all conf flags are recognized in validation
...
This commit adds logic in configuration file validation that checks that
each account "extra" field is empty after getting it back from the
backend validation. This is to ensure the user doesn't set options that
are invalidly stated in the documentation or by accident.
Closes #135
Configuration error (xxx): the following flags are set but are not recognized: ["index_style"] https://git.meli.delivery/meli/meli/issues/135
3 years ago
Manos Pitsidianakis
e9aaa7b067
melib/datetime: use *const c_char instead of *const i8 for portability
...
Using *const i8 broke compatibility with arm64.
Fixes #127
3 years ago
Manos Pitsidianakis
d4b690d5d3
melib/imap: send password as byte literal on LOGIN
...
Concerns #125
Escape IMAP passwords properly https://git.meli.delivery/meli/meli/issues/125
3 years ago
Manos Pitsidianakis
ce2068d36b
melib/jmap: fix background watch using JSON paths incorrectly
3 years ago
Manos Pitsidianakis
0d8bedd2d5
melib/jmap: make is_online() await for connection
...
Closes #126 https://git.meli.delivery/meli/meli/issues/126
3 years ago
Manos Pitsidianakis
81d1265601
melib/imap: escape IMAP passwords properly
...
Closes #125
3 years ago
Manos Pitsidianakis
d8e9a00563
melib/imap: add quoted REFERENCES field in parsing of responses
3 years ago
Manos Pitsidianakis
36e29cb6fd
Add configurable mailbox sort order
...
Closes #25
```
sort_order unsigned integer (optional) Override sort order on the sidebar for this mailbox. Example:
[accounts."imap.example.com".mailboxes]
"INBOX" = { index_style = "plain" }
"INBOX/Sent" = { sort_order = 0 }
"INBOX/Drafts" = { sort_order = 1 }
"INBOX/Lists" = { sort_order = 2 }
```
3 years ago
Manos Pitsidianakis
5f003a31be
melib/addressbook/vcard: Parse vCards with just LF instead of CRLF line endings
...
According to the vcard RFC
https://datatracker.ietf.org/doc/html/rfc6350#section-3.2 all lines must
end with CRLF (\r\n or 0x0d 0x0a)
Some VCard sources use only newline, which, while spec violating is easy
to recover from. So parse them as if they are correct.
Closes #121
3 years ago
Manos Pitsidianakis
2580522931
melib/addressbook: log vcard parsing failures
3 years ago
Manos Pitsidianakis
15ca25af73
Bump version to 0.7.2
3 years ago
Manos Pitsidianakis
37d0846195
melib/email/address: quote display_name if it contains ","
3 years ago
Manos Pitsidianakis
ffc498a5d0
melib/smtp: fix Cc and Bcc ignored when sending mail
3 years ago
Manos Pitsidianakis
240374950a
melib/email/address: quote display_name if it contains "."
3 years ago
Manos Pitsidianakis
505adca54d
Add forward mail option
...
Forward email with shortcut 'forward' (default ctrl+f)
This opens a composing tab letting you to select receiver etc.
"composing" config setting "forward_as_attachment" selects the
forwarding behavior:
- "ask" asks you ever time
- true always forwards by attaching the entire email as a single
attachment
- false always forwards by inlining the email, like most email clients
do.
Closes #120
3 years ago
Manos Pitsidianakis
733de5a5fb
Fix some clippy suggestions
3 years ago
Manos Pitsidianakis
bc08bf1d13
Bump version to 0.7.1
3 years ago
Manos Pitsidianakis
7533df86e0
Fix compilation for netbsd-9.2
...
$ rustc -V
rustc 1.52.1
$ cargo -V
cargo 1.52.0
Pre-requisite steps needed for build:
- Needed to install mozilla certs
- Needed to set OPENSSL_DIR=/usr
3 years ago
Manos Pitsidianakis
526a246430
melib/nntp: update total/new counters on new articles
3 years ago
Alex.F
69916f267b
add 'GB18030' charset
3 years ago
Manos Pitsidianakis
07e166e1fb
melib/error: Add kinds: NotImplemented, NotSupported, OSError
3 years ago
Manos Pitsidianakis
c8da6d2049
melib/nntp: implement refresh
3 years ago
Manos Pitsidianakis
90042379a6
melib/{imap,nntp}: throw error on extra unusued conf flags
3 years ago
Manos Pitsidianakis
09dc0a2409
melib/conf: deserialize ToggleFlag from bool & string
3 years ago