mirror of
https://github.com/oxen-io/lokinet.git
synced 2024-11-17 15:25:35 +00:00
ebd2142114
This replaces all use of std::optional's `opt.value()` with `*opt` because macOS is great and the ghost of Steve Jobs says that actually supporting std::optional's value() method is not for chumps before macOS 10.14. So don't use it because Apple is great. Pretty much all of our use of it actually is done better with operator* anyway (since operator* doesn't do a check that the optional has a value). Also replaced *most* of the `has_value()` calls with direct bool context, except for one in the config section which looked really confusing at a glance without a has_value().
429 lines
11 KiB
C++
429 lines
11 KiB
C++
#include <config/definition.hpp>
|
|
|
|
#include <catch2/catch.hpp>
|
|
|
|
TEST_CASE("OptionDefinition int parse test", "[config]")
|
|
{
|
|
llarp::OptionDefinition<int> def("foo", "bar", false, 42);
|
|
|
|
CHECK(def.getValue() == 42);
|
|
CHECK(def.getNumberFound() == 0);
|
|
|
|
CHECK(def.defaultValueAsString() == "42");
|
|
|
|
CHECK_NOTHROW(def.parseValue("43"));
|
|
CHECK(def.getValue() == 43);
|
|
CHECK(def.getNumberFound() == 1);
|
|
|
|
CHECK(def.defaultValueAsString() == "42");
|
|
}
|
|
|
|
TEST_CASE("OptionDefinition string parse test", "[config]")
|
|
{
|
|
llarp::OptionDefinition<std::string> def("foo", "bar", false, "test");
|
|
|
|
CHECK(def.getValue() == "test");
|
|
CHECK(def.defaultValueAsString() == "test");
|
|
|
|
CHECK_NOTHROW(def.parseValue("foo"));
|
|
CHECK(def.getValue() == "foo");
|
|
CHECK(def.getNumberFound() == 1);
|
|
}
|
|
|
|
TEST_CASE("OptionDefinition multiple parses test", "[config]")
|
|
{
|
|
{
|
|
llarp::OptionDefinition<int> def("foo", "bar", false, 8);
|
|
def.multiValued = true;
|
|
|
|
CHECK_NOTHROW(def.parseValue("9"));
|
|
CHECK(def.getValue() == 9);
|
|
CHECK(def.getNumberFound() == 1);
|
|
|
|
// should allow since it is multi-value
|
|
CHECK_NOTHROW(def.parseValue("12"));
|
|
CHECK(def.getValue() == 9); // getValue() should return first value
|
|
REQUIRE(def.getNumberFound() == 2);
|
|
|
|
}
|
|
|
|
{
|
|
llarp::OptionDefinition<int> def("foo", "baz", false, 4);
|
|
|
|
CHECK_NOTHROW(def.parseValue("3"));
|
|
CHECK(def.getValue() == 3);
|
|
CHECK(def.getNumberFound() == 1);
|
|
|
|
// shouldn't allow since not multi-value
|
|
CHECK_THROWS(def.parseValue("2"));
|
|
CHECK(def.getNumberFound() == 1);
|
|
}
|
|
|
|
}
|
|
|
|
TEST_CASE("OptionDefinition acceptor test", "[config]")
|
|
{
|
|
int test = -1;
|
|
llarp::OptionDefinition<int> def("foo", "bar", false, 42, [&](int arg) {
|
|
test = arg;
|
|
});
|
|
|
|
CHECK_NOTHROW(def.tryAccept());
|
|
CHECK(test == 42);
|
|
|
|
def.parseValue("43");
|
|
CHECK_NOTHROW(def.tryAccept());
|
|
CHECK(test == 43);
|
|
}
|
|
|
|
TEST_CASE("OptionDefinition acceptor throws test", "[config]")
|
|
{
|
|
llarp::OptionDefinition<int> def("foo", "bar", false, 42, [&](int arg) {
|
|
(void)arg;
|
|
throw std::runtime_error("FAIL");
|
|
});
|
|
|
|
REQUIRE_THROWS_WITH(def.tryAccept(), "FAIL");
|
|
}
|
|
|
|
TEST_CASE("OptionDefinition tryAccept missing option test", "[config]")
|
|
{
|
|
int unset = -1;
|
|
llarp::OptionDefinition<int> def("foo", "bar", true, 1, [&](int arg) {
|
|
(void)arg;
|
|
unset = 0; // should never be called
|
|
});
|
|
|
|
REQUIRE_THROWS_WITH(def.tryAccept(),
|
|
"cannot call tryAccept() on [foo]:bar when required but no value available");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition basic add/get test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"router",
|
|
"threads",
|
|
false,
|
|
4));
|
|
|
|
CHECK(config.getConfigValue<int>("router", "threads") == 4);
|
|
|
|
CHECK_NOTHROW(config.addConfigValue(
|
|
"router",
|
|
"threads",
|
|
"5"));
|
|
|
|
CHECK(config.getConfigValue<int>("router", "threads") == 5);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition missing def test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
CHECK_THROWS(config.addConfigValue("foo", "bar", "5"));
|
|
CHECK_THROWS(config.getConfigValue<int>("foo", "bar") == 5);
|
|
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"quux",
|
|
"bar",
|
|
false,
|
|
4));
|
|
|
|
CHECK_THROWS(config.addConfigValue("foo", "bar", "5"));
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition required test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"router",
|
|
"threads",
|
|
true,
|
|
1));
|
|
|
|
CHECK_THROWS(config.validateRequiredFields());
|
|
|
|
config.addConfigValue("router", "threads", "12");
|
|
|
|
CHECK_NOTHROW(config.validateRequiredFields());
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition section test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"foo",
|
|
"bar",
|
|
true,
|
|
1));
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"goo",
|
|
"bar",
|
|
true,
|
|
1));
|
|
|
|
CHECK_THROWS(config.validateRequiredFields());
|
|
|
|
config.addConfigValue("foo", "bar", "5");
|
|
CHECK_THROWS(config.validateRequiredFields());
|
|
|
|
CHECK_NOTHROW(config.addConfigValue("goo", "bar", "6"));
|
|
CHECK_NOTHROW(config.validateRequiredFields());
|
|
|
|
CHECK(config.getConfigValue<int>("foo", "bar") == 5);
|
|
CHECK(config.getConfigValue<int>("goo", "bar") == 6);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition acceptAllOptions test", "[config]")
|
|
{
|
|
int fooBar = -1;
|
|
std::string fooBaz = "";
|
|
|
|
llarp::ConfigDefinition config;
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"foo", "bar", false, 1, [&](int arg) {
|
|
fooBar = arg;
|
|
}));
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<std::string>>(
|
|
"foo", "baz", false, "no", [&](std::string arg) {
|
|
fooBaz = arg;
|
|
}));
|
|
|
|
config.addConfigValue("foo", "baz", "yes");
|
|
|
|
REQUIRE_NOTHROW(config.validateRequiredFields());
|
|
REQUIRE_NOTHROW(config.acceptAllOptions());
|
|
CHECK(fooBar == 1);
|
|
CHECK(fooBaz == "yes");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition acceptAllOptions exception propagation test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
config.defineOption(std::make_unique<llarp::OptionDefinition<int>>(
|
|
"foo", "bar", false, 1, [&](int arg) {
|
|
(void)arg;
|
|
throw std::runtime_error("FAIL");
|
|
}));
|
|
|
|
REQUIRE_THROWS_WITH(config.acceptAllOptions(), "FAIL");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition defineOptions passthrough test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
config.defineOption<int>("foo", "bar", false, 1);
|
|
CHECK(config.getConfigValue<int>("foo", "bar") == 1);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition undeclared definition basic test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
bool invoked = false;
|
|
|
|
config.addUndeclaredHandler("foo", [&](std::string_view section, std::string_view name, std::string_view value) {
|
|
CHECK(section == "foo");
|
|
CHECK(name == "bar");
|
|
CHECK(value == "val");
|
|
|
|
invoked = true;
|
|
});
|
|
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "bar", "val"));
|
|
|
|
CHECK(invoked);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition undeclared add more than once test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
std::string calledBy = "";
|
|
|
|
config.addUndeclaredHandler("foo", [&](std::string_view, std::string_view, std::string_view) {
|
|
calledBy = "a";
|
|
});
|
|
REQUIRE_THROWS_WITH(
|
|
config.addUndeclaredHandler("foo", [&](std::string_view, std::string_view, std::string_view) {
|
|
calledBy = "b";
|
|
}),
|
|
"section foo already has a handler");
|
|
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "bar", "val"));
|
|
|
|
CHECK(calledBy == "a");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition undeclared add/remove test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
std::string calledBy = "";
|
|
|
|
// add...
|
|
REQUIRE_NOTHROW(config.addUndeclaredHandler("foo", [&](std::string_view, std::string_view, std::string_view) {
|
|
calledBy = "a";
|
|
}));
|
|
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "bar", "val"));
|
|
|
|
CHECK(calledBy == "a");
|
|
|
|
calledBy = "";
|
|
|
|
// ...then remove...
|
|
REQUIRE_NOTHROW(config.removeUndeclaredHandler("foo"));
|
|
|
|
CHECK_THROWS_WITH(config.addConfigValue("foo", "bar", "val"), "unrecognized section [foo]");
|
|
|
|
// ...then add again
|
|
REQUIRE_NOTHROW(config.addUndeclaredHandler("foo", [&](std::string_view, std::string_view, std::string_view) {
|
|
calledBy = "b";
|
|
}));
|
|
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "bar", "val"));
|
|
|
|
CHECK(calledBy == "b");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition undeclared handler exception propagation test", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
config.addUndeclaredHandler("foo", [](std::string_view, std::string_view, std::string_view) {
|
|
throw std::runtime_error("FAIL");
|
|
});
|
|
|
|
REQUIRE_THROWS_WITH(config.addConfigValue("foo", "bar", "val"), "FAIL");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition undeclared handler wrong section", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
config.addUndeclaredHandler("foo", [](std::string_view, std::string_view, std::string_view) {
|
|
throw std::runtime_error("FAIL");
|
|
});
|
|
|
|
REQUIRE_THROWS_WITH(config.addConfigValue("argle", "bar", "val"), "unrecognized section [argle]");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition undeclared handler duplicate names", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
int count = 0;
|
|
|
|
config.addUndeclaredHandler("foo", [&](std::string_view, std::string_view, std::string_view) {
|
|
count++;
|
|
});
|
|
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "k", "v"));
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "k", "v"));
|
|
REQUIRE_NOTHROW(config.addConfigValue("foo", "k", "v"));
|
|
|
|
REQUIRE(count == 3);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition AssignmentAcceptor", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
int val = -1;
|
|
config.defineOption<int>("foo", "bar", false, 2, llarp::AssignmentAcceptor(val));
|
|
|
|
config.addConfigValue("foo", "bar", "3");
|
|
CHECK_NOTHROW(config.acceptAllOptions());
|
|
|
|
REQUIRE(val == 3);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition multiple values", "[config]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
std::vector<int> values;
|
|
config.defineOption<int>("foo", "bar", false, true, 2, [&](int arg) {
|
|
values.push_back(arg);
|
|
});
|
|
|
|
config.addConfigValue("foo", "bar", "1");
|
|
config.addConfigValue("foo", "bar", "2");
|
|
config.addConfigValue("foo", "bar", "3");
|
|
CHECK_NOTHROW(config.acceptAllOptions());
|
|
|
|
REQUIRE(values.size() == 3);
|
|
CHECK(values[0] == 1);
|
|
CHECK(values[1] == 2);
|
|
CHECK(values[2] == 3);
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition [bind]iface regression", "[config regression]")
|
|
{
|
|
llarp::ConfigDefinition config;
|
|
|
|
std::string val1;
|
|
std::string undeclaredName;
|
|
std::string undeclaredValue;
|
|
|
|
config.defineOption<std::string>(
|
|
"bind", "*", false, false, "1090", [&](std::string arg) { val1 = arg; });
|
|
|
|
config.addUndeclaredHandler("bind", [&](std::string_view, std::string_view name, std::string_view value) {
|
|
undeclaredName = std::string(name);
|
|
undeclaredValue = std::string(value);
|
|
});
|
|
|
|
config.addConfigValue("bind", "enp35s0", "1091");
|
|
CHECK_NOTHROW(config.acceptAllOptions());
|
|
|
|
CHECK(val1 == "1090");
|
|
CHECK(undeclaredName == "enp35s0");
|
|
CHECK(undeclaredValue == "1091");
|
|
}
|
|
|
|
TEST_CASE("ConfigDefinition truthy/falsy bool values", "[config]")
|
|
{
|
|
// truthy values
|
|
for (auto val : {"true", "on", "yes", "1"})
|
|
{
|
|
llarp::OptionDefinition<bool> def("foo", "bar", false, false);
|
|
|
|
// defaults to false
|
|
auto maybe = def.getValue();
|
|
REQUIRE(maybe);
|
|
CHECK(*maybe == false);
|
|
|
|
// val should result in true
|
|
CHECK_NOTHROW(def.parseValue(val));
|
|
maybe = def.getValue();
|
|
REQUIRE(maybe);
|
|
CHECK(*maybe);
|
|
}
|
|
|
|
// falsy values
|
|
for (auto val : {"false", "off", "no", "0"})
|
|
{
|
|
llarp::OptionDefinition<bool> def("foo", "bar", false, true);
|
|
|
|
// defaults to true
|
|
auto maybe = def.getValue();
|
|
REQUIRE(maybe);
|
|
CHECK(maybe == true);
|
|
|
|
// val should result in false
|
|
CHECK_NOTHROW(def.parseValue(val));
|
|
maybe = def.getValue();
|
|
REQUIRE(maybe);
|
|
CHECK(maybe == false);
|
|
}
|
|
|
|
// illegal values
|
|
for (auto val : {"", " ", "TRUE", "argle", " false", "2"})
|
|
{
|
|
llarp::OptionDefinition<bool> def("foo", "bar", false, true);
|
|
CHECK_THROWS(def.parseValue(val));
|
|
}
|
|
}
|