38 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jeff	28bfaf0372	ammend log levels for common spammy log events (#1375)	4 years ago
jeff	574a986d9a	explicitly set frame reset field to zero by default	4 years ago
Jeff Becker	0f21eeccb0	* rework exit codepath to allow multiple exits ... * rework net code for ip ranges to be cleaner * clean up endpoint auth code * refactor config to validate network configs before setting up endpoints * remove buildone from path/pathbuilder.cpp so we don't spam connection attempts	4 years ago
Jeff Becker	f4971a88fd	use lokimq workers instead of llarp:🧵:ThreadPool	4 years ago
Jeff Becker	a45f92dca7	use random good path for outbound traffic so that it uses an even spread accross ... all paths	4 years ago
Jason Rhinelander	ebd2142114	Don't use std::optional::value() because f u macos ... This replaces all use of std::optional's `opt.value()` with `*opt` because macOS is great and the ghost of Steve Jobs says that actually supporting std::optional's value() method is not for chumps before macOS 10.14. So don't use it because Apple is great. Pretty much all of our use of it actually is done better with operator* anyway (since operator* doesn't do a check that the optional has a value). Also replaced *most* of the `has_value()` calls with direct bool context, except for one in the config section which looked really confusing at a glance without a has_value().	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jeff Becker	d2d109e92c	llarp_time_t is now using std::chrono	4 years ago
Jeff Becker	c1ad5f955a	remove mutex	4 years ago
Jeff Becker	28a2d471d6	style nitch	5 years ago
Jeff Becker	44e0e2c034	dont flood the logic queue	5 years ago
Jeff Becker	56dce90de9	add trace log level for tracking logic thread jobs	5 years ago
jeff	32ed821763	Merge remote-tracking branch 'upstream/dev' into multithreaded-cryptography	5 years ago
jeff	f9fb40f590	final touches	5 years ago
jeff	7c691cf334	handover should be fixed now	5 years ago
jeff	6c2ebbb925	try fixing handover and add snapp traffic to multithreaded crypto workers	5 years ago
Michael	edd0ec398f	Move thread stuff to subdirectory	5 years ago
Michael	16cdfbd5f0	clang-tidy modernize pass	5 years ago
Jeff Becker	f48754c45d	make hop count and length configurable	5 years ago
Jeff Becker	d465400840	revert	5 years ago
Michael	08609f9e5a	Rename message files	5 years ago
Michael	8a058fcb34	Move other messages	5 years ago
Jeff Becker	73c1538518	fix	5 years ago
Jeff Becker	f8e2edae28	fix	5 years ago
Jeff Becker	a33dbce680	try switching logic	5 years ago
Michael	491fee206b	Port code to use CryptoManager over passing Crypto pointers	5 years ago
Jeff Becker	64c7ed42fc	make format	5 years ago
Jeff Becker	9c96aecf3f	move llarp::Logic to std::shared_ptr ... add sequence numbers to HSD messages begin work on network isolation code add more docs	5 years ago
Jeff Becker	5f823f8ba3	fix	5 years ago
Jeff Becker	a954f2000e	shift introduction	5 years ago
Jeff Becker	5b49008bca	more	5 years ago
Jeff Becker	0b68d3db5d	move stuff arround so that flushing queues are done in the correct event loops ... TODO: locking	5 years ago
Jeff Becker	0529e45ebe	more	5 years ago
Jeff Becker	5921086391	common codepath for sending protocol frames	5 years ago
Michael	98e691f315	Tidy up more parts of the service/ directory	5 years ago
Michael	e33a33635c	Remove usage of raw new from service classes	5 years ago
Michael	2412ed59ee	Move SendContext to its own component	5 years ago