86 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jeff	3ab7db7723	macos route poking (#1333) ... * fix up macos route poker logic * fix typo * use string_view * add forgotten header * full paths * add debugging * catch exception on adding route * workarround for macos * typofix * typofix * fix for macos * fix command for macos * because we autopoke remove explicit route poking in rpc * probably final fix of macos route poking * split routes instead of deleting them * dynamic route poking * move log statement for introset lookup and dont consider bad sessions as able to send * send convotag reset frame when we have no session * add exit map to rpc * use split_any	4 years ago
Jeff Becker	0f21eeccb0	* rework exit codepath to allow multiple exits ... * rework net code for ip ranges to be cleaner * clean up endpoint auth code * refactor config to validate network configs before setting up endpoints * remove buildone from path/pathbuilder.cpp so we don't spam connection attempts	4 years ago
Jeff Becker	3cdca30a74	more auth shit	4 years ago
Jeff Becker	f4971a88fd	use lokimq workers instead of llarp:🧵:ThreadPool	4 years ago
Jeff Becker	a42d3d51c3	more	4 years ago
Jeff Becker	1e8368b636	make it compile	4 years ago
Jeff Becker	61c5808765	exit authentication (initial)	4 years ago
Jeff Becker	ad882d0d70	initial working code	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jason Rhinelander	089056ca5b	Remove all ABSL_ATTRIBUTE_UNUSED uses	4 years ago
Stephen Shelton	66a058a2af	Make format	4 years ago
Stephen Shelton	93b8832026	Merge branch 'dev' into private-keys-backup-support	5 years ago
Jeff Becker	8849173112	try async decrypt then verify	5 years ago
Jeff Becker	ba0fd223d9	reduce number of jobs we put onto the logic thread	5 years ago
Jeff Becker	56dce90de9	add trace log level for tracking logic thread jobs	5 years ago
Stephen Shelton	db56e17c23	Rename bencode function for clarity	5 years ago
Michael	edd0ec398f	Move thread stuff to subdirectory	5 years ago
Michael	4d8fe2a8a8	Move meta programming to subdirectory	5 years ago
Michael	16cdfbd5f0	clang-tidy modernize pass	5 years ago
Jeff Becker	fdbb2e8dc8	make format	5 years ago
Jeff Becker	847fcdf5f3	move convotag missmatch check to the right place	5 years ago
Michael	84601fa474	Make format	5 years ago
Jeff Becker	e3d13fc2a0	drop missmatched convotags	5 years ago
Michael	f9e9227e19	Fix gcc trunk warnings	5 years ago
Jeff Becker	b9bcc2b775	make threadpool consice	5 years ago
Jeff Becker	64e9622270	start seperating tun and endpoint	5 years ago
Jeff Becker	1061ae4fee	set outbound context to be outbound session	5 years ago
Jeff Becker	0146a967d0	fix convotag inbound state setting	5 years ago
Jeff Becker	0b90acff75	handle reply intro	5 years ago
Jeff Becker	5853e5e3f4	pass in path	5 years ago
Jeff Becker	a323003824	differentiate between inbound and outbound convos	5 years ago
Michael	75430a234c	Convert to use memFn	5 years ago
Michael	491fee206b	Port code to use CryptoManager over passing Crypto pointers	5 years ago
Michael	3f53965b71	Remove all use of IBEncodeMessage	5 years ago
Jeff Becker	64c7ed42fc	make format	5 years ago
Jeff Becker	9c96aecf3f	move llarp::Logic to std::shared_ptr ... add sequence numbers to HSD messages begin work on network isolation code add more docs	5 years ago
Jeff Becker	d423ee02d2	use shared_ptr	5 years ago
Jeff Becker	99c29cf05a	prepare for ios/android jazz ... move to use std::shared_ptr instead of bare pointers so we can multithread everything.	5 years ago
Michael	98e691f315	Tidy up more parts of the service/ directory	5 years ago
Michael	e33a33635c	Remove usage of raw new from service classes	5 years ago
Jeff Becker	cab85b8f85	dont stomp existing convotags	5 years ago
Jeff Becker	28e07903b6	put reply intro	5 years ago
Jeff Becker	280d85d478	handle protocol discard	5 years ago
Jeff Becker	df17866ff7	breaking protocol change, bundle source txid on outside of path transfer message.	5 years ago
Michael	a00d6afc5e	Convert llarp_buffer_t to be a class with methods	5 years ago
Michael	048fa83c39	Finish replacement of Router with AbstractRouter	5 years ago
Michael	f3b0af9d2f	Create CopyableBuffer type	5 years ago
Michael	2de621b0ad	Disable copy constructing llarp_buffer_t	5 years ago
Michael	f24f554a01	Convert llarp::Crypto into an abstract base class	5 years ago