28 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jeff Becker	3eb006f78c	iwp/libuv cleanup: remove llarp_pkt_list and all users of it as it's broke	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jeff Becker	769bafd281	disable accedental fec in iwp outbound messages	4 years ago
Jeff Becker	d2d109e92c	llarp_time_t is now using std::chrono	4 years ago
Jeff Becker	a93e0a735b	fix typo, reduce delivery timeout	4 years ago
Jeff Becker	fcd3750a8b	increase ack window	4 years ago
Jeff Becker	86a4ccd98f	unconditionally bundle first fragment in xmit	5 years ago
Jeff Becker	1f83fdb190	fix previous commit	5 years ago
Jeff Becker	19835ce501	dont use auto	5 years ago
Jeff Becker	c88602ee16	break the world to make it faster	5 years ago
Jeff Becker	1fc36f4832	changes from review	5 years ago
Jeff Becker	8befd6f2db	flush link session encrypt queue immediately after handling plaintext packets	5 years ago
jeff	3c1d5518d8	fix windows port and make it compile	5 years ago
Jeff Becker	327c545530	finish multithread cryptography first pass	5 years ago
jeff	14c9ef15ed	try calling stuff in logic thread from event loop	5 years ago
jeff	ac2a2aed1d	gut libutp and finish making things compile and pass tests	5 years ago
Jeff Becker	d04762ab49	unstaged changed	5 years ago
Jeff Becker	3b1a0b2835	add multi-ack and change protocol handshake to pin identity key	5 years ago
Jeff Becker	deecbbbdef	optimize	5 years ago
Jeff Becker	444d832b7c	correct constructors on llarp_buffer_t and check rc on regen	5 years ago
Jeff Becker	ba2aaa68c6	add short data fragments and rx replay filter	5 years ago
Jeff Becker	88f685b74a	add forgotten bits	5 years ago
Jeff Becker	0241851b72	add likn layer delivery timeout notification for iwp	5 years ago
Jeff Becker	6a48a3b402	code review fixes: ... * use std::unordered_set * use default for ctor/dtor * don't crash on short packet with nack	5 years ago
Jeff Becker	82ea973137	silence clang errors	5 years ago
Jeff Becker	acf5f78949	update iwp , add NACK	5 years ago
Jeff Becker	426ee41c46	initial iwp	5 years ago