47 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jeff Becker	6af498092b	exit traffic via loki addresses	4 years ago
Jason Rhinelander	7f9160bb6e	Untangle some interdependencies ... macOS doing a shared library build is not working without untangling some of the interdependencies. This commit does that, at least enough to get macOS to compile. This isn't the cleanest as currently implemented (we have some net/ things in `liblokinet-platform` and some in `liblokinet`, and likewise ev/vpnio.cpp is in `liblokinet` while the rest of `ev/*` is in `liblokinet-platform`).	4 years ago
Jason Rhinelander	72bf215da4	Move IPPacket header (part 1) ... Rename net/ip.{cpp,hpp} to net/ip_packet.{cpp,hpp}. (Doing this in two commits because I want to repurpose ip.hpp/ip.cpp, and want git to figure out the history properly).	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jeff Becker	d2d109e92c	llarp_time_t is now using std::chrono	4 years ago
Michael	16cdfbd5f0	clang-tidy modernize pass	5 years ago
Jeff Becker	5c61df08b5	Merge remote-tracking branch 'origin/master' into ipv6-tun	5 years ago
Michael	08609f9e5a	Rename message files	5 years ago
Michael	83bd9227a7	Move exit messages	5 years ago
Michael	d6751e3eeb	Move subset of messages to right directory	5 years ago
Jeff Becker	2403ab8f86	ipv6	5 years ago
Jeff	06f8bb2f42	add blacklist-snode option	5 years ago
Jeff Becker	df322e1149	don't include duplicate hops in paths	5 years ago
Jeff Becker	7b03b63d13	more sighup code	5 years ago
Jeff Becker	a53da68700	start work on sighup	5 years ago
Jeff Becker	32363ea622	more vigorus exit path building	5 years ago
Jeff Becker	d423ee02d2	use shared_ptr	5 years ago
Jeff Becker	986e831579	make bundle-rc option configurable on snode tld	5 years ago
Jeff Becker	5e0acc1197	separate upstream/downstream flush	5 years ago
Jeff Becker	af1529fa72	Merge remote-tracking branch 'origin/master'	5 years ago
Michael	4143472a17	Add cmake module to target a library as 'system', and fix a few warnings	5 years ago
Jeff Becker	6711296b26	finish converting to shared_ptr	5 years ago
Jeff Becker	99c29cf05a	prepare for ios/android jazz ... move to use std::shared_ptr instead of bare pointers so we can multithread everything.	5 years ago
Jeff Becker	d5162c2aad	dont kill active exit paths	5 years ago
Michael	c39c931d03	Remove IStateful virtual inheritance	5 years ago
Jeff Becker	57dc6cc965	make bundling rc in path builds configurable on runtime	5 years ago
Jeff Becker	94eb37d490	bundle RC in build record to improve build success rates.	5 years ago
Jeff Becker	88abe28cc1	add dead checking on exit paths	5 years ago
Jeff Becker	b849ff9a94	handle path death better	5 years ago
Jeff Becker	ce126166af	more logging info	5 years ago
Jeff Becker	eceb55623c	more	5 years ago
Jeff Becker	159415c363	delay dns resolution for snode until we have a session with it	5 years ago
Michael	048fa83c39	Finish replacement of Router with AbstractRouter	5 years ago
Jeff Becker	46222df421	refactor	5 years ago
Jeff Becker	e1522faeaa	add introspection rpc endpoint	5 years ago
Michael	2de621b0ad	Disable copy constructing llarp_buffer_t	5 years ago
Michael	da6cdfc0b2	More refactoring to continue to make dependency graph acylic	5 years ago
Michael	081d4dfa32	Reorganise source into more folders	5 years ago
Jeff Becker	21d1998a38	add graceful stop for path builders and friends	5 years ago
Jeff Becker	191dc43207	revert	5 years ago
Jeff Becker	4324aed7ec	fix previous commit	5 years ago
Jeff Becker	8e6046ff1c	order downstream packets	5 years ago
Jeff Becker	be234e4b6e	* make format ... * snode to snode direct traffic * wire up dns on service node tun	6 years ago
Jeff Becker	e787165da9	expire old snode sessions	6 years ago
Michael	85dde7b6b0	Move remaining include/llarp headers to llarp/	6 years ago
Michael	0a08e53bde	Move exit* to llarp/	6 years ago