32 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Rick V	a787db9b35	fix ipv4_hdr	4 years ago
Rick V	76aa0421ff	use a new read buffer every time	4 years ago
Rick V	1e51bfde2c	fix	4 years ago
Rick V	4e87e8dc08	correctly return true/false when writing	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Rick V	9b0ec0935a	bump for next release	4 years ago
Rick V	8e9842f4b2	bindaddr a common field on the machine-independent side	4 years ago
Rick V	db0920d921	use backport fork for release installer only ... move all invariant assets to common repo remove ded code, libuv patches can be swapped in at build time for debug/release builds	4 years ago
Rick V	caa6549cbb	clang-format everything	4 years ago
Rick V	9fa9209114	don't be aggressive ... remove libcurl packaging rules. We still build it, but ship only the curl.exe	4 years ago
Rick V	d1b9b89812	add note ... add libuv build add its dependent libraries to the final link line	4 years ago
Jeff Becker	c4f08e5145	finish remaining changes	4 years ago
jeff	3c1d5518d8	fix windows port and make it compile	5 years ago
Michael	67c36998e6	Fix windows	5 years ago
Michael	488695047f	Remove redundant else blocks	5 years ago
Rick V	81e88ab351	wtf jeff	5 years ago
Jeff	7a83f71713	re-animate paths	5 years ago
Jeff	bcb5933fc9	ooofff	5 years ago
Jeff	784a25634b	exit tun loop in destructor	5 years ago
Rick V	3d62460f42	that didn't even fix the abseil shite ... in fact, the *original* issue was resolved ages ago This reverts commit 2373698ea91feb29158caa1634335858becb038d. yeah this was a solution in search of a problem that no longer exists	5 years ago
Jeff Becker	734a5b5fae	more	5 years ago
Rick V	ea7301fecf	finally unfuck windows bits	5 years ago
Michael	f3b0af9d2f	Create CopyableBuffer type	5 years ago
Rick V	2d375f03b3	finally separate implementation into code module	5 years ago
Jeff Becker	3fd8f27b01	add ticking where there should be ... (cherry picked from commit f9a3605601130e5daf765d121d322a37592409ae)	5 years ago
Rick V	1a56265f69	patch superseded by mike	5 years ago
Rick V	778a45bb37	at last ... full anonymity on computers the world over is nearing completion - see path.cpp for a potential bug (cherry picked from commit 7bd6ddf88a) # Conflicts: # llarp/ev_win32.hpp	5 years ago
Rick V	a5daa7269e	ok fix tick finally	5 years ago
Michael	6e38e85a79	Produce hierarchy of 'libraries' inside libllarp	5 years ago
Michael	a3463120cc	Move net components into a distinct folder	5 years ago
Michael	081d4dfa32	Reorganise source into more folders	5 years ago