85 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jeff	3ab7db7723	macos route poking (#1333) ... * fix up macos route poker logic * fix typo * use string_view * add forgotten header * full paths * add debugging * catch exception on adding route * workarround for macos * typofix * typofix * fix for macos * fix command for macos * because we autopoke remove explicit route poking in rpc * probably final fix of macos route poking * split routes instead of deleting them * dynamic route poking * move log statement for introset lookup and dont consider bad sessions as able to send * send convotag reset frame when we have no session * add exit map to rpc * use split_any	4 years ago
Jeff Becker	2c0c6aa819	log error instead of executing job	4 years ago
Jeff Becker	3cdca30a74	more auth shit	4 years ago
Jeff Becker	0d6e3bcd89	fix crashing tests	4 years ago
Jeff Becker	e13e886df9	fix up event loop crap so that unit tests pass	4 years ago
Jeff Becker	f4971a88fd	use lokimq workers instead of llarp:🧵:ThreadPool	4 years ago
Thomas Winget	221e9ff5de	make format	4 years ago
Thomas Winget	c2a30692cf	Implement upstream DNS using libunbound	4 years ago
Jeff Becker	a73335579a	silence logging in regression test	4 years ago
Jeff Becker	95e55a2544	consistent spelling and use std::max	4 years ago
Jeff Becker	acecb23eb3	make libuv event loop logic queue size configurable. ... remove logic constructor that is no-op. add constant for default logic queue size add constant for transit hop queue size	4 years ago
Jeff Becker	c47a210302	remove a std::move that prevents copy elision	4 years ago
Jeff Becker	9298313066	use std::move	4 years ago
Jeff Becker	1230b81517	make format	4 years ago
Jeff Becker	b8d262573a	use std::vector instead of thrashing heap with allocation	4 years ago
Jeff Becker	3eb006f78c	iwp/libuv cleanup: remove llarp_pkt_list and all users of it as it's broke	4 years ago
Jeff Becker	f04407f183	use only 1 uv_async_t for event loop wakeups ... flush logic calls in there too as this was causing unit tests to hang	4 years ago
Stephen Shelton	0b54087689	Begin implementing SockAddr	4 years ago
Stephen Shelton	aee96e53a3	Refactor Addr -> IpAddress/SockAddr	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jeff	d3091cf9fc	Merge pull request #1167 from tewinget/tooling ... RouterHive initial PR	4 years ago
Jeff Becker	1e434c03f8	cleanup	4 years ago
Jeff Becker	d1f8752b7c	fix memleak in jsonrpc ... llarp_tcp_acceptor ticker wasn't being called so connections where not being cleaned up	4 years ago
Thomas Winget	84a1d7dbcc	clang format.......	4 years ago
Thomas Winget	a58a8c9a61	hive.py now defaults to 1000 relays because f your box. ... also check for error on uv_async_init... may want to `ulimit -Sn $(ulimit -Hn)`...	4 years ago
Jeff Becker	d2d109e92c	llarp_time_t is now using std::chrono	4 years ago
Jeff Becker	7aa1b2c27c	monotonic time and run testnet at 20% realtime	4 years ago
Jeff Becker	c6d77e72f2	fix up tcp connection logic	4 years ago
Jeff Becker	989146f63a	handle write failure	4 years ago
Jeff Becker	c38c055488	return result	4 years ago
Jeff Becker	42f721d691	don't queue on full write queue	4 years ago
Jeff Becker	6d42b5f997	reduce logic calls	4 years ago
Jeff Becker	4126d307b3	dont close timers on closeall	4 years ago
Jeff Becker	8b8d636ded	make format	4 years ago
Thomas Winget	55b44cfc13	fix derp nested function call and derp merge error	4 years ago
Thomas Winget	71bb0dd520	implement timers using libuv ... So far only a bit of the code using timers has been modified to use the new libuv-based timers. Also only the non-Windows case has been implemented. Seems to be working though, so it's a good time to commit.	4 years ago
Jeff Becker	c4f08e5145	finish remaining changes	4 years ago
Jeff Becker	95eee4081a	trypushback	4 years ago
Jeff Becker	cdfdfa1068	use thread queue	4 years ago
Jeff Becker	8455d5d1cf	more cleanup	4 years ago
Jeff Becker	cec36b62b5	make logic and net thread one in the same	4 years ago
Jeff Becker	847ab3a47e	make it compile	4 years ago
Jeff Becker	1f83fdb190	fix previous commit	4 years ago
Jeff Becker	3c85691f81	limit calls to pumpll such that it gets called fast enough but not too much under load	5 years ago
Jason Rhinelander	5d8f547d33	Set tun to non-blocking ... If we can't write to it we want failure, not blocking.	5 years ago
Thomas Winget	6d506302dc	Show number of logic thread jobs in debug builds	5 years ago
Thomas Winget	6acf7bff7e	Track and log UV event loop ticks in debug builds	5 years ago
Jeff Becker	6f95fbfece	work in progress	5 years ago
Jeff Becker	56dce90de9	add trace log level for tracking logic thread jobs	5 years ago