33 Commits (af6caf776a4a7a8580d96d5e72cb9e037708e3c4)

Author	SHA1	Message	Date
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jason Rhinelander	4faaf9082c	Fix broken unbound resolver when including upstream port ... unbound breaks when given "1.2.3.4:53" as it expects only an IP.	4 years ago
Thomas Winget	8f0330c9f2	std::vector instead of std::array	4 years ago
Thomas Winget	b875d40491	restructure how upstream dns replies are handled ... llarp::dns::Message does not fully support DNS packets, so converting the upstream response to one will not work for all query types. Also it is kinda silly to begin with, as the upstream reply is already a network packet, ready to go.	4 years ago
Thomas Winget	221e9ff5de	make format	4 years ago
Thomas Winget	c2a30692cf	Implement upstream DNS using libunbound	4 years ago
Stephen Shelton	aee96e53a3	Refactor Addr -> IpAddress/SockAddr	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jeff Becker	1d5c712adb	monkey patch upstream dns to rewrite .loki cname answers	4 years ago
Jeff Becker	56dce90de9	add trace log level for tracking logic thread jobs	5 years ago
Jeff	9ace1b2398	Merge pull request #870 from majestrate/disable-doh-using-isp-backdoor-provided-by-mozilla-thanks-from-nsa ... disable DoH	5 years ago
Jeff Becker	d2be8ac384	fix issue #894	5 years ago
Jeff Becker	bd07845dd3	make format	5 years ago
jeff	37d7f2b1e7	disable DoH using mozilla's ISP backdoor record.	5 years ago
Michael	edd0ec398f	Move thread stuff to subdirectory	5 years ago
Michael	16cdfbd5f0	clang-tidy modernize pass	5 years ago
Jeff Becker	b679dd7341	fixit	5 years ago
Jeff Becker	c355d37beb	use limited size queue for logic and singled threaded threadpool	5 years ago
Jeff Becker	64c7ed42fc	make format	5 years ago
Jeff Becker	9c96aecf3f	move llarp::Logic to std::shared_ptr ... add sequence numbers to HSD messages begin work on network isolation code add more docs	5 years ago
Jeff Becker	7f25b62ef5	remove adding of defaults to upstream dns resolvers	5 years ago
Jeff Becker	e178a70929	use shared_ptr for event loop	5 years ago
Jeff Becker	1922221c3d	permit no upstream resolvers and send servfail if we have none	5 years ago
Ryan Tharp	fefb012bf8	fix llvm 3.8	5 years ago
Michael	7ca3e13e78	Rename to ManagedBuffer	5 years ago
Michael	f3b0af9d2f	Create CopyableBuffer type	5 years ago
Michael	79157414f3	Split crypto.hpp into 3 different files	5 years ago
Michael	d9ce493a9e	Move dns* to llarp/	5 years ago
Michael	7be452092c	Convert llarp_crypto to be a true C++ class	5 years ago
Jeff Becker	ebb42ca46f	fix previous commit	6 years ago
Jeff Becker	c27b7c2858	separate client/server in dns proxy	6 years ago
Jeff Becker	40678f9019	add dnslib unit test coverage	6 years ago
Jeff Becker	1d1bde2e88	add dnslib	6 years ago