Jason Rhinelander
ebd2142114
Don't use std::optional::value() because f u macos
...
This replaces all use of std::optional's `opt.value()` with `*opt`
because macOS is great and the ghost of Steve Jobs says that actually
supporting std::optional's value() method is not for chumps before macOS
10.14. So don't use it because Apple is great.
Pretty much all of our use of it actually is done better with operator*
anyway (since operator* doesn't do a check that the optional has a
value).
Also replaced *most* of the `has_value()` calls with direct bool
context, except for one in the config section which looked really
confusing at a glance without a has_value().
2020-05-20 19:18:28 -03:00
Stephen Shelton
bcf473757d
Fix broken config-related test cases
2020-05-08 08:43:25 -06:00
Jason Rhinelander
1697bf90fe
C++17
...
Compiles with C++17, replaces ghc::filesystem with std::filesystem,
nonstd::optional with std::optional, and llarp::string_view with
std::string_view.
2020-05-01 17:43:27 -03:00
Stephen Shelton
5c6c7c7020
Expand on ConfigDefinition truthy/falsy unit test
2020-04-29 12:40:29 -06:00
Stephen Shelton
320564d792
Specialize ConfigOption for bool to accept "truthy" / "falsy" values
2020-04-29 12:32:07 -06:00
Stephen Shelton
936fbb2424
Fix config not falling back to undeclared handler for missing option
2020-04-29 09:41:07 -06:00
Stephen Shelton
0a9515a94a
Proper support for multiple values @ ConfigDefinition
2020-04-07 14:25:20 -06:00
Stephen Shelton
a6787657be
Refactor config comments to take list of strings
2020-04-07 14:24:49 -06:00
Stephen Shelton
a8671cf9c7
Rename config classes for clarity
...
ConfigDefinition -> OptionDefiniton
Configuration -> ConfigDefinition
2020-04-07 14:24:49 -06:00
Stephen Shelton
9e850705b4
Add 'AssignmentAcceptor' convenience for simple config acceptors
2020-04-07 14:20:59 -06:00
Stephen Shelton
028e55e997
Remove pre-refactor config test
2020-04-07 14:14:33 -06:00
Stephen Shelton
14e7789847
Add padding to config file generated output
2020-04-07 14:12:31 -06:00
Stephen Shelton
18ee23c2a3
Support for comments in config definition
2020-04-07 14:11:58 -06:00
Stephen Shelton
c5ff672c79
Use 'undeclared handler' for multi-valued 'add-node' config option
2020-04-07 14:10:11 -06:00
Stephen Shelton
9a1b7b20de
Add "undeclared value" handler to Configuration
2020-04-07 14:09:14 -06:00
Stephen Shelton
ffc58fcedb
Remove dead code (serverOptions)
2020-04-07 14:09:13 -06:00
Stephen Shelton
2e47262350
Demystify LinksConfig
2020-04-07 14:08:45 -06:00
Stephen Shelton
a44eb73baa
Add config INI output unit tests
2020-04-07 14:01:46 -06:00
Stephen Shelton
69331f1571
Remove multiValued as an argument to ConfigDefinition
2020-04-07 14:01:45 -06:00
Stephen Shelton
f6d000838f
Clarity and convenience for defining config options
2020-04-07 14:01:45 -06:00
Stephen Shelton
02e31f3867
Introduce acceptor function in ConfigDefinition
2020-04-07 14:01:44 -06:00
Stephen Shelton
60d0bf2a9b
Rename function for clarity
2020-04-07 14:01:44 -06:00
Stephen Shelton
8352de7bd4
Config documentation, clarity
2020-04-07 14:01:43 -06:00
Stephen Shelton
105dd30fd9
More ConfigDefinition unit tests, fixes, support std::string as type
2020-04-07 14:01:42 -06:00
Stephen Shelton
25212b929c
Add ConfigDefinition unit tests, fixes
2020-04-07 14:01:41 -06:00
Stephen Shelton
9d71228e74
Replace config visit pattern with explicit lookups
...
This is an initial pass at doing explicit value checks when handling
config parsing, as opposed to using a visiting pattern. The latter
made it difficult to check for conditions such as missing required
values, multiple values, etc.
It was also generally less readable (think declarative) which further
made it difficult to get a grasp for what our actual configuration file
requirements were.
2020-04-07 14:01:40 -06:00
Jason Rhinelander
3bd400f6fe
Fix string_view C++17 compatibility
...
string_view was implicitly convertible to std::string, but
std::string_view is only explicitly convertible. This makes the
`operator std::string` explicit to be more compatible, and re-adds a
bunch of explicit string casts to the code where needed.
(This also fixes the build if changing the standard to c++17)
2020-02-25 11:52:43 -04:00
Jason Rhinelander
74d4afad51
Remove metric config parsing
2020-02-24 14:27:44 -04:00
Jeff Becker
8f891c57b6
fix unit tests
2019-12-10 08:33:59 -05:00
Jeff Becker
c1f33bb1ac
initial mempipe implementation
2019-08-07 12:33:29 -04:00
Michael
91c1ba87cc
Change ConfigParser too
2019-07-21 16:57:11 +01:00
Michael
8fd4ceb55b
Don't use LoadFromString
2019-07-21 16:57:11 +01:00
Michael
3ce90b678e
Allow override of the rest of the config
2019-07-09 00:29:43 +01:00
Michael
fbb83704a0
Allow override of some config via env variables
2019-07-09 00:29:43 +01:00
Michael
f310160065
Fixup and add tests
2019-07-06 14:46:25 +01:00
Michael
a2326efa37
Revert "Merge pull request #679 from tewinget/revert-config-refactor"
...
This reverts commit 2996a7f29c10df3bd4b3
2019-07-06 14:46:25 +01:00
Thomas Winget
d044d60101
Reverts #678 #677 and #669 with hashes:
...
10df3bd766ece8979f095
2019-07-02 11:02:20 -04:00
Michael
bd78471dae
Move ini parser as well
2019-07-02 01:58:38 +01:00
