Commit Graph

5372 Commits

Author SHA1 Message Date
Jason Rhinelander
e7902d2e45 Move ppc64le/s390x to allow_failures and simplify it 2020-02-06 17:39:23 -04:00
Jason Rhinelander
7ab6220a41 Older cmake workaround 2020-02-06 17:13:57 -04:00
Jeff
e44449b2d5
Merge pull request #1084 from notlesh/reduce-client-log-output-2020-02-06
s/LogInfo/LogDebug/ @ explore message
2020-02-06 16:08:40 -05:00
Jason Rhinelander
74cc73d46b DOWNLOAD_SODIUM=FORCE to always download libsodium
This bypasses the check for a compatible local libsodium.
2020-02-06 16:28:35 -04:00
Jason Rhinelander
5a4700d868 Use ExternalProject to build downloaded libsodium 2020-02-06 16:27:51 -04:00
Jeff Becker
8c698a1cd1
* rename i to foundIntro
* check for zero timestamp
* use > not >=
2020-02-06 14:35:31 -05:00
Jeff Becker
41210a8ae1
check for current introset being zero (initial state) 2020-02-06 14:23:23 -05:00
Stephen Shelton
37e4f26be1
s/LogInfo/LogDebug @ 'signed/verify encrypted introset' 2020-02-06 12:05:43 -07:00
Stephen Shelton
2cade16c0e
s/LogInfo/LogDebug/ @ 'updating SN list' 2020-02-06 12:03:06 -07:00
Stephen Shelton
bc3184a126
s/LogInfo/LogDebug/ @ explore message 2020-02-06 11:57:39 -07:00
Jason Rhinelander
5f642e4f01 Zero-initialize test array 2020-02-06 14:33:53 -04:00
Jeff
4bc5b52762
Merge pull request #1082 from majestrate/log-build-after-send-2020-02-06
only mark path build success if delivered to first hop
2020-02-06 12:38:38 -05:00
Jason Rhinelander
228a3573f7 Remove travis_wait
We don't have anything that takes >10 minutes without producing output,
and travis_wait is really annoying by hiding output until the job
completely finishes.
2020-02-06 13:18:56 -04:00
Jason Rhinelander
0c69cad451 Add arm64/s390x/ppc64le builds, reduce apt deps
The apt deps is installing a pile of stuff that isn't needed (and isn't
available on non-amd64); reduce the set and use a YAML reference to use
it only in the jobs doing a native build (none of the docker builds need
to install anything since everything happens inside docker).
2020-02-06 13:18:56 -04:00
Jason Rhinelander
18705ba9fe Switch primary builds from xenial to bionic 2020-02-06 13:18:56 -04:00
Jeff Becker
499e346da6
notify delivery of path builds 2020-02-06 12:12:39 -05:00
Jeff
8230b1152e
Merge pull request #1072 from majestrate/2020-01-25-router-version
add router version
2020-02-04 17:40:46 -05:00
Jeff
702ab29ce4
Merge pull request #1080 from majestrate/fix-kdf-2020-02-03
don't derive x25519 key from ed25519 key
2020-02-04 12:30:22 -05:00
Jeff Becker
1318846a08
test/service/test_llarp_service_identity.cpp:
* remove failing irrelevent test
* add expect_call in EnsureKeys to match expected bevahior
2020-02-04 06:44:48 -05:00
Jeff Becker
e6174efa21
don't derive x25519 key from ed25519 key 2020-02-03 17:21:31 -05:00
Jeff
c122b460e1
Merge pull request #1075 from jagerman/dht-blinding
Dht blinding
2020-02-03 16:44:25 -05:00
Jeff Becker
80f8363386
don't drop messages with pathid zero which belong to snode to snode dht and path build requests. 2020-02-03 16:24:45 -05:00
Jason Rhinelander
73239f4c39 Use glob to find sodium source files
Manually changing the list every time we want to change the libsodium
version is painful.

I tested this glob against libsodium 1.0.17 and verified it produces the
same set of files (aside from the generated version.h), and that in
1.0.18 it produces the same set modulo upstream files removed/added.
2020-02-02 22:12:29 -04:00
Jason Rhinelander
b72a4296b7 Fix libsodium 1.0.18 URL 2020-02-02 21:37:09 -04:00
Jeff
c8417a7270
Merge pull request #1076 from majestrate/plug-memory-leak-2020-02-01
use std::shared_ptr not a bare pointer to prevent memleak
2020-02-02 18:12:15 -05:00
Jason Rhinelander
2b93ccb393 Bump libsodium required version to 1.0.18
We use crypto_core_ed25519_scalar_mul which is only exported by
libsodium >= 1.0.18.
2020-02-02 16:38:48 -04:00
Jason Rhinelander
8cd95c01b3 Abstract signing hash data location
This makes the interface a little cleaner by not requiring the class
user to know how we laid out the data in the object.
2020-02-02 16:38:48 -04:00
Jeff Becker
ea3323a3ab
correct key 2020-02-02 12:44:56 -05:00
jeff
0c971f4e9d use system packages in venv so system packages override 2020-02-02 11:57:59 -05:00
jeff
88e8b7f98c mock lokid for loopback testnet 2020-02-02 11:32:15 -05:00
Jason Rhinelander
739ce92aeb Remove unused ristretto includes 2020-02-01 12:44:31 -04:00
Jeff Becker
ee752c00e6
make format 2020-02-01 10:28:10 -05:00
Jeff Becker
c014d21f84
use std::shared_ptr not a bare pointer to prevent memleak 2020-02-01 09:31:53 -05:00
Stephen Shelton
5631983716
Make format 2020-01-31 14:52:59 -07:00
Stephen Shelton
8921125924
Fix buffer overflow when version encodes too many integers 2020-01-31 14:48:00 -07:00
Jason Rhinelander
f1171ed7a2 make format 😠 🤮 2020-01-31 17:05:50 -04:00
Jason Rhinelander
46f3459b79 Fixed EncryptedIntroSet signing to use PrivateKey
We can generate both root and derived signatures from a PrivateKey, but
only root from a SecretKey, so just change it to use a PrivateKey.
2020-01-31 16:47:25 -04:00
Jason Rhinelander
cd8f26deff Use hash instead of random for signing hash data
This makes PrivateKey store both the key followed by the hash.  For
PrivateKeys based on SecretKeys this just means the second half of the
SHA-512 of the seed, and makes a PrivateKey constructed from a SecretKey
give an identical signature to signing directly with sodium.

For derived keys we use a ShortHash of the root key's signing hash
concatenated with the publicly known hash value, so that our derived key
signing hash will be different from the root signing hash and also
different for different derivation parameters.

This also changed one of the asserts in crypto_noop, but upon closer
inspection the copying of the secret key into the signature seems really
wrong, so just changed them to fill with 0s.
2020-01-31 16:47:25 -04:00
Jason Rhinelander
fe8a72750a Silence unused parameter warning 2020-01-31 16:47:25 -04:00
Jeff Becker
9153f726c5 const correctness 2020-01-31 16:47:25 -04:00
Stephen Shelton
cfabe72587
Fix RouterVersion::IsEmpty() and RouterVersion::Clear() 2020-01-31 13:31:00 -07:00
Stephen Shelton
f0571a9f2c
Fix IsCompatableWith() logic WRT emptyRouterVersion, add unit tests 2020-01-31 13:23:48 -07:00
Thomas Winget
afd87eedb4 NO CLAMPS YOU IDIOT!!! 2020-01-31 12:05:27 -04:00
Thomas Winget
a487982c49 initial implementation of blinded sign -- not working yet 2020-01-31 12:05:20 -04:00
Jason Rhinelander
f7cd10a82e Fix Recalculate()
Recalculate did what should have been the right thing but wasn't because
of libsodium's mislabelling the "seed" as the secret key.
2020-01-30 12:38:39 -04:00
Jason Rhinelander
860c5efd47 Derived key fixes
The reason things weren't working here is because libsodium does
something completely unintuitive and called the seed the "secret key"
when it isn't, it's the seed.

This adds a new PrivateKey class (alongside the existing SecretKey and
PubKey) that holds just a private key value but no seed -- which we need
to do because there is no way we can get a seed after calculating a
derived keypair.

With these changes, we now generate exactly the same keys and subkeys as
Tor (and a new test case uses values generated in Tor to verify this).

This is incomplete -- the subkey signing code is still not implemented;
it has to be adapted to create a signature from a PrivateKey rather than
a SecretKey which will probably requiring working around/reimplementing
some of what libsodium does for creating a signature since it expects
"secret keys" i.e. the seed.
2020-01-30 12:34:05 -04:00
Jeff Becker
0f13591802
does not work 2020-01-28 16:55:36 -05:00
Jeff Becker
99eb7726ff
initial dht key blinding 2020-01-27 16:30:41 -05:00
Jeff Becker
1543284f6b
make it compile 2020-01-27 11:56:07 -05:00
Jeff Becker
4f81b913ef
make router version member optional on serialization 2020-01-27 11:55:19 -05:00