Jason Rhinelander
74215fc44c
Fix link layer delivery race condition (fix random ping delays)
...
We trigger a pump immediately, but this is racey because we add to our
plaintext data in a worker thread; if the worker thread runs after the
pump then it ends up leaving plaintext to be handled, but there's no
wakeup until the next one.
This was the cause of seeing a random +1s and bunching added to ping
responses sometimes: it wasn't until the *next* ping goes through the
network that the plaintext queue gets processed, at which point it
flushes the old one and often the new one together.
The fix here gets rid of the map of sessions needing wakeups and instead
adds an atomic flag to all of them to let us figure out which ones
need to be flushed.
2021-11-15 13:36:28 -04:00
Jason Rhinelander
aa1dc83459
Simplify
2021-11-15 13:36:13 -04:00
Jason Rhinelander
362fda5a56
Combine empty + pop into single call
2021-11-15 13:36:09 -04:00
Jason Rhinelander
b03f3c2d79
Remove another unwanted unconditional PumpLL
2021-11-15 13:36:03 -04:00
Jason Rhinelander
9113a6b36b
Triggered pumping
...
This redoes how/when we pump so that we should only be calling the
idempotent PumpLL() when we actually have (or may have) something to
pump.
2021-11-15 13:35:57 -04:00
Jason Rhinelander
bfc6d35b33
Simplifications & C++17
...
- Modernize some iterator loops
- Simplify a couple places by using `if (init; ...)`
- Replace various std::binds with lambdas
2021-11-14 10:11:00 -04:00
Jason Rhinelander
41807f1763
transit hop: drop instead of flushing when full
...
If full happens we are going to trigger a bunch of flushes which
probably isn't very useful, so drop instead.
2021-11-14 10:10:58 -04:00
Jason Rhinelander
cf5c4e7284
outbound_message_handler: skip instead of aborting on removed paths
2021-11-14 10:10:19 -04:00
Jason Rhinelander
633431be66
Make outbound message queue PumpLL again if it doesn't send all
2021-11-14 10:10:19 -04:00
Jason Rhinelander
faf95cbd0a
Allow a nullptr callback for event loop PumpLL
2021-11-14 10:07:31 -04:00
Jeff Becker
8a9025e234
only pump path context in idempotent pumpll
2021-11-14 10:07:31 -04:00
Jeff Becker
bb86996acf
make event loop pump function non idempotent
2021-11-14 10:07:31 -04:00
Jeff Becker
8744c93944
prevent 100% cpu usage on service nodes
...
call_soon wakes up the mainloop and is often reentrant, we dont want to
ever way up the event loop but we also want to always defer the call so
we always use the workers
2021-11-14 10:07:11 -04:00
Jeff Becker
22d4b88edc
make PumpLL idempotent to reduce cpu use a bit
2021-11-09 11:59:57 -05:00
Jason Rhinelander
1ddfb7420a
Merge pull request #1791 from majestrate/exclude-failing-from-queue-2021-10-29
...
exclude fully failed nodes from service node testing list
2021-10-29 14:44:16 -03:00
Jason Rhinelander
0ec50e6624
Fix comment typo
2021-10-29 11:52:54 -03:00
Jeff Becker
fcba709fcb
do not requeue nodes for testing from failing queue if we do not have them marked as failing anymore
2021-10-29 10:46:50 -04:00
Jeff Becker
6c70022dcc
check for intersecting ip ranges correctly, add unit test
2021-10-22 15:53:19 -04:00
Jason Rhinelander
52492c6253
make format
2021-10-16 15:16:55 -03:00
Jason Rhinelander
1e22417ade
Add missing deprecated copy assignment operator
...
Clang-13 warns (and -Werror dies) without it.
2021-10-16 15:16:55 -03:00
Jason Rhinelander
50449038b4
Another gcc-11 fix
...
GCC is wrongly warning that `h` is uninitialized here, but it clearly
isn't. Work around it.
2021-10-16 15:02:06 -03:00
Sean
e11a94c95c
RPC call for summary get_status ( #1742 )
...
* RPC call for summary get_status
* lint
* update with review notes
* further review points
* uint64_t
2021-10-13 07:20:36 -04:00
Jason Rhinelander
0768593fa5
Merge pull request #1762 from majestrate/v6-base-address-configuration-fix-2021-10-06
...
catch ipv6 ioctl throwing when someone runs lokinet with no ipv6
2021-10-12 20:21:04 -03:00
Jeff
1846c3e3d8
prevent bizare half open state. ( #1754 )
...
* attempt path timeout bullshittery fix
* make sure ServiceInfo always has its address set up
* do not copy intros in constuctor, ammend logging and
add assert
2021-10-12 17:37:01 -04:00
Jeff Becker
937d07b6ce
catch ipv6 ioctl throwing when someone runs lokinet with no ipv6
2021-10-06 18:08:08 -04:00
Jeff Becker
5e9f9686e7
set base v6 address to nullopt when explicit empty string is provided
2021-10-06 16:22:49 -04:00
Jeff
24681fd35d
Merge pull request #1759 from majestrate/iterate-dir-in-order-2021-10-06
...
iterate through directory entries in lexigraphical order
2021-10-06 15:15:26 -04:00
Jeff
1d955cf28d
Update fs.hpp
...
style nit
2021-10-06 14:37:09 -04:00
Jeff Becker
00f81b1dac
iterate through directory entries in lexigraphical order
2021-10-06 14:04:11 -04:00
Jeff Becker
d882f1a302
some compilers hated [[maybe_unused]] so use (void) when they are unused
2021-10-06 11:10:49 -04:00
Jeff Becker
cf187ddffc
fix up logging, put _log into anonynous namespace, make only log trace nop in release builds
2021-10-06 11:10:48 -04:00
Jeff Becker
20814a4adc
use llarp:: prefix for LogError
2021-10-06 11:10:48 -04:00
Jeff Becker
1b06e263fb
update log statement for win32
2021-10-06 11:10:48 -04:00
Jeff Becker
2d5faccb9f
refactor for apple
2021-10-06 11:10:48 -04:00
Jeff Becker
7d07dea235
fix up gripes in source_location
...
* get rid of columns we dont need those
2021-10-06 11:10:48 -04:00
Jeff Becker
acdb8a19a6
for some reason [[maybe_unused]] is hated by buster 32 bit x86 so we do something else
...
to appease that compiler.
2021-10-06 11:10:48 -04:00
Jeff Becker
18c5b43e63
use inline source_location implementation for android too
2021-10-06 11:10:48 -04:00
jeff
0546dab2e3
make source location happy on macos
...
* because of course apple doesn't provide any implementation (lmao) we provide one ourself
2021-10-06 11:10:48 -04:00
Jeff Becker
5c457ff486
refactor logging to use std::source_location
...
* use std::source_location instead of godawful macros in logging
* remove unused/absolutely haram af json logstream
* fix bug in android logger where it doesn't respect eLogNone
2021-10-06 11:10:48 -04:00
Jeff Becker
9c37e0146e
make it compile again
2021-09-24 17:15:50 -04:00
Jeff Becker
45b5fec314
make it compile again (squashme)
2021-09-24 16:51:03 -04:00
Jeff
ed271de715
make lokinet-util library static
...
every other lokinet internal lib is static, but liblokinet-util was not, this fixes that.
2021-09-18 19:54:06 -04:00
Jeff Becker
d1246947f7
SystemD DNS fix:
...
when dns is port 53 call SetLinKDNS otherwise call SetLinkDNSEx as on older versions of systemd-resolved SetLinkDNSEx is not available.
2021-09-16 17:52:30 -04:00
Jeff Becker
9ad63140f2
use std::sample to grab MaxGossipPeers when populating std::unordered_set
2021-09-03 17:45:08 -04:00
Jeff Becker
a739e7b532
try not to prefer outbound vs inbound link sessions
...
before when we get the list of router ids for gossip it was highly bias towards outbound sessions.
instead now we get a full list of link session router ids in random order, truncate them to be at most MaxGossipPeers number of keys, and then put them into an unordered set
2021-09-03 17:45:08 -04:00
Jeff Becker
d91ce53da1
limit RC gossip to 20 peers max
2021-09-03 17:45:08 -04:00
Jeff Becker
344d0a2f2d
format
2021-09-03 15:21:08 -04:00
Jeff Becker
2ee43c2162
set ipv6 address on apple to hardcoded value
2021-09-03 15:17:46 -04:00
Jason Rhinelander
c52782ab32
Add IPv6 addr/routing for macos
2021-09-03 15:35:33 -03:00
Jeff Becker
b52cf97e11
override ShouldHandlePacket on android to bypass non .snode/.loki dns hooking.
2021-09-03 14:03:55 -04:00
