Commit Graph

461 Commits (5a2141bae833337aa20e4f506d34600f8ea61f9e)

Author SHA1 Message Date
Jason Rhinelander 0839c16f19 Final abseil purge
Bye-bye Google Boost.
5 years ago
Jason Rhinelander 46242ba69b TrimWhiteSpace -> TrimWhitespace
Fix my dumb initial capitalization choice.
5 years ago
Jason Rhinelander 74d4afad51 Remove metric config parsing 5 years ago
Jason Rhinelander 54186c4a89 Replace absl string_view with string_view from lokimq
When we add loki-mq has a dependency we can just alias it, but for now
it's easier to copy the header than add the whole submodule library.
5 years ago
Jason Rhinelander 561bfe24c0 Add cmake "check" target to run all tests
Renames the cmake Catch2 test target to "catch" (instead of "check") and
adds a "rungtest" for gtest (because the "gtest" target is already taken
by the gtest library itself), and then repurposes the "check" target to
run both test suite binaries.

Also updates the top-level Makefile to do the same thing, except that
there the gtest target is just "gtest" instead of "rungtest".
5 years ago
Jason Rhinelander 98c34d995b De-abseil: Add our own llarp::TrimWhiteSpace
Adds a TrimWhiteSpace instead of using abseil's.

Adds Catch2 tests for it, and also converts the existing str tests to
catch (which look much, much nicer than the gtest ones).
5 years ago
Jason Rhinelander fe61367a87 Vastly simplified llarp::util::memFn
There is a huge pile of unnecessary machinery here that can be solved
with a few lambdas and some member function pointer type deduction.
5 years ago
Jason Rhinelander b4440094b0 De-abseil, part 2: mutex, locks, (most) time
- util::Mutex is now a std::shared_timed_mutex, which is capable of
  exclusive and shared locks.

- util::Lock is still present as a std::lock_guard<util::Mutex>.

- the locking annotations are preserved, but updated to the latest
  supported by clang rather than using abseil's older/deprecated ones.

- ACQUIRE_LOCK macro is gone since we don't pass mutexes by pointer into
  locks anymore (WTF abseil).

- ReleasableLock is gone.  Instead there are now some llarp::util helper
  methods to obtain unique and/or shared locks:
    - `auto lock = util::unique_lock(mutex);` gets an RAII-but-also
      unlockable object (std::unique_lock<T>, with T inferred from
      `mutex`).
    - `auto lock = util::shared_lock(mutex);` gets an RAII shared (i.e.
      "reader") lock of the mutex.
    - `auto lock = util::unique_locks(mutex1, mutex2, mutex3);` can be
      used to atomically lock multiple mutexes at once (returning a
      tuple of the locks).
  This are templated on the mutex which makes them a bit more flexible
  than using a concrete type: they can be used for any type of lockable
  mutex, not only util::Mutex.  (Some of the code here uses them for
  getting locks around a std::mutex).  Until C++17, using the RAII types
  is painfully verbose:

  ```C++
  // pre-C++17 - needing to figure out the mutex type here is annoying:
  std::unique_lock<util::Mutex> lock(mutex);
  // pre-C++17 and even more verbose (but at least the type isn't needed):
  std::unique_lock<decltype(mutex)> lock(mutex);
  // our compromise:
  auto lock = util::unique_lock(mutex);
  // C++17:
  std::unique_lock lock(mutex);
  ```

  All of these functions will also warn (under gcc or clang) if you
  discard the return value.  You can also do fancy things like
  `auto l = util::unique_lock(mutex, std::adopt_lock)` (which lets a
  lock take over an already-locked mutex).

- metrics code is gone, which also removes a big pile of code that was
  only used by metrics:
  - llarp::util::Scheduler
  - llarp:🧵:TimerQueue
  - llarp::util::Stopwatch
5 years ago
Stephen Shelton 16be86a5c3
Merge pull request #1116 from tewinget/short-path-names
path builder prints hops, rest print short name
5 years ago
Thomas Winget fc56a018e5 path builder prints hops, rest print short name 5 years ago
Jeff 7c5a721457
Merge pull request #1114 from notlesh/redundant-introset-lookup-improvements-2020-02-20
Redundant introset lookup improvements
5 years ago
Stephen Shelton 0429bafbb3
Merge pull request #1111 from notlesh/redundant-introset-propagation-2020-02-19
Redundant introset propagation
5 years ago
Stephen Shelton 66cb30fa58
Refactor: remove recursionDepth from DHT lookups 5 years ago
Stephen Shelton dff9aeb250
Propagate Introset publishing redundantly 5 years ago
Jason Rhinelander ac1486d0be Replace absl::optional with optional-lite
Step 1 of removing abseil from lokinet.

For the most part this is a drop-in replacement, but there are also a
few changes here to the JSONRPC layer that were needed to work around
current gcc 10 dev snapshot:

- JSONRPC returns a json now instead of an optional<json>.  It doesn't
  make any sense to have a json rpc call that just closes the connection
  with returning anything.  Invoked functions can return a null (default
  constructed) result now if they don't have anything to return (such a
  null value won't be added as "result").
5 years ago
Jeff Becker 827ca0bda7
make catch2 a submodule 5 years ago
Stephen Shelton 7842889fef Add NodeDB tests around FindClosestTo() 5 years ago
Stephen Shelton 9dfcfbc3ac Bencode/decode relayOrder in lexigraphical order, make it uint64_t 5 years ago
Stephen Shelton 906803e387 Refactor DHT introset lookups to use redundant lookup strategy 5 years ago
Jeff Becker e35d17764a * add path::Path::UniqueEndpointSet_t
* start using check2 for new unit tests
* unit test for path::Path::UniqueEndpointSet_t
5 years ago
Jason Rhinelander 8aacc2d317 Update deprecated gtest macros
gtest ~renamed INSTANTIATE_TEST_CASE_P to INSTANTIATE_TEST_SUITE_P and
added a "backwards compatibility" shim, but the shim fails at compile
time if you pass in an empty fourth argument.
5 years ago
Jeff 186dba45cb
Merge pull request #956 from notlesh/km-testing
Implement KeyManager tests
5 years ago
Jason Rhinelander 0497fb9ccb Another big-endian fix 5 years ago
Jason Rhinelander 5f642e4f01 Zero-initialize test array 5 years ago
Jeff 8230b1152e
Merge pull request #1072 from majestrate/2020-01-25-router-version
add router version
5 years ago
Jeff Becker 1318846a08
test/service/test_llarp_service_identity.cpp:
* remove failing irrelevent test
* add expect_call in EnsureKeys to match expected bevahior
5 years ago
Stephen Shelton 8921125924
Fix buffer overflow when version encodes too many integers 5 years ago
Jason Rhinelander 46f3459b79 Fixed EncryptedIntroSet signing to use PrivateKey
We can generate both root and derived signatures from a PrivateKey, but
only root from a SecretKey, so just change it to use a PrivateKey.
5 years ago
Jason Rhinelander cd8f26deff Use hash instead of random for signing hash data
This makes PrivateKey store both the key followed by the hash.  For
PrivateKeys based on SecretKeys this just means the second half of the
SHA-512 of the seed, and makes a PrivateKey constructed from a SecretKey
give an identical signature to signing directly with sodium.

For derived keys we use a ShortHash of the root key's signing hash
concatenated with the publicly known hash value, so that our derived key
signing hash will be different from the root signing hash and also
different for different derivation parameters.

This also changed one of the asserts in crypto_noop, but upon closer
inspection the copying of the secret key into the signature seems really
wrong, so just changed them to fill with 0s.
5 years ago
Jeff Becker 9153f726c5 const correctness 5 years ago
Stephen Shelton cfabe72587
Fix RouterVersion::IsEmpty() and RouterVersion::Clear() 5 years ago
Stephen Shelton f0571a9f2c
Fix IsCompatableWith() logic WRT emptyRouterVersion, add unit tests 5 years ago
Thomas Winget a487982c49 initial implementation of blinded sign -- not working yet 5 years ago
Jason Rhinelander 860c5efd47 Derived key fixes
The reason things weren't working here is because libsodium does
something completely unintuitive and called the seed the "secret key"
when it isn't, it's the seed.

This adds a new PrivateKey class (alongside the existing SecretKey and
PubKey) that holds just a private key value but no seed -- which we need
to do because there is no way we can get a seed after calculating a
derived keypair.

With these changes, we now generate exactly the same keys and subkeys as
Tor (and a new test case uses values generated in Tor to verify this).

This is incomplete -- the subkey signing code is still not implemented;
it has to be adapted to create a signature from a PrivateKey rather than
a SecretKey which will probably requiring working around/reimplementing
some of what libsodium does for creating a signature since it expects
"secret keys" i.e. the seed.
5 years ago
Jeff Becker 0f13591802
does not work 5 years ago
Jeff Becker 99eb7726ff
initial dht key blinding 5 years ago
Jeff Becker 9efd796145
initial wack at 0.7.0 dht fixes 5 years ago
Jeff Becker 2c0dc12f39
refactor single char variables in DHT (mostly) 5 years ago
Jeff Becker 3b66cf6e75
dht fixes, disable iterative lookups on clients, revert "fixes" from 0.6.3, pass in recursion depth from introset lookup 5 years ago
Stephen Shelton 9a65f19bb0
Add test to ensure config loading impacts runtime log level 5 years ago
Stephen Shelton 43998f97c8
Add unit tests for LogLevelToName and LogLevelToString 5 years ago
Jeff Becker 28752f85b7
improve test cases 5 years ago
Jeff Becker 8d11519eb2
unit tests for logging levels 5 years ago
Rick V 636957f3f9
happy new year 5 years ago
Jeff Becker 562f3f07ab
add unit test for decaying hash set 5 years ago
Jason Rhinelander 1b710455a7 Disallow AlignedBuffer < 8 bytes; add oddball buffer sizes 5 years ago
Jeff Becker 16c7e7dd33 fix unit tests 5 years ago
Thomas Winget f4c9e09d44 remove obsolete timer-related code 5 years ago
Rick V ccd936feb1
the internal windows toolchain _already_ provides a default manifest 5 years ago
Rick V fd6602bf05
fix versiontag 5 years ago
Rick V e144d9e762
fix test suite 5 years ago
Rick V 6d49ffd60b
include all platform dependencies transitively 5 years ago
Rick V e15c57c114
get ready for v0.6
bump version

don't ship the shared object
5 years ago
Jeff Becker 9fa2b5c92a
remove undeeded test case 5 years ago
Jeff Becker fcf0ae2b9e
prune unused files. 5 years ago
Stephen Shelton 332f33b049 Remove FS_LIB conditionals 5 years ago
Stephen Shelton e3c752f4ab Another attempt to make travis-ci's xenial happy 5 years ago
Stephen Shelton 0dbbf30de5 Fix for travis-ci xenial build 5 years ago
Stephen Shelton c303d438aa Prefer ASSERT_EQ over ASSERT_TRUE when appropriate 5 years ago
Jeff Becker 8455d5d1cf more cleanup 5 years ago
Jeff Becker 8f891c57b6
fix unit tests 5 years ago
Stephen Shelton c99ab0c9b7 Fix build 5 years ago
Stephen Shelton ef075a53dd Implement KeyManager tests 5 years ago
Jeff Becker 593f1e657a
make format and make tests compile 5 years ago
Stephen Shelton 2c6226f54a Backup SNApp keys when migrating to new ed25519 crypto 5 years ago
Stephen Shelton 11410a2748 Avoid trivial getters/setters in KeyManager 5 years ago
Stephen Shelton eb5184ee09 Reinstate link test / update to use KeyManager 5 years ago
Stephen Shelton 93b8832026
Merge branch 'dev' into private-keys-backup-support 5 years ago
Stephen Shelton 521ef9b5bb Handle link transport key in KeyManager 5 years ago
Jeff Becker 098915bb8e
add check for identity key validity 5 years ago
Stephen Shelton e8e2e21fa2 Reorganize priv key file loading a bit and hook KeyManager into Router 5 years ago
Jeff Becker ac686a9329
remove valgrind access errors 5 years ago
Jeff Becker 56dce90de9
add trace log level for tracking logic thread jobs 5 years ago
Stephen Shelton 1666498405 Replace bencode_write_version_entry with a more general-purpose function for writing bencoded dictionary entries 5 years ago
Jeff Becker b34caa3e26
make unit tests pass for iwp 5 years ago
Jeff Becker f16c9f9b5d
iot seems that logic thread didn't work the way i remember it should
make logic work the way it should
5 years ago
Jeff Becker c9f26c4911
call Router::PumpLL after every batch of packets from a link session 5 years ago
Jeff Becker 2cb15e7e0b
enable see2 when used 5 years ago
Jeff Becker f38240f945
devendor libsodium by default except for android 5 years ago
Jeff Becker 01c4a9c287
revert a few things 5 years ago
jeff 1cdd9ba13a add unit test for identity_keygen 5 years ago
jeff c3451fc77a remove log level change 5 years ago
jeff 32ed821763 Merge remote-tracking branch 'upstream/dev' into multithreaded-cryptography 5 years ago
Rick V 00d34709eb
bump to 0.5.2 5 years ago
Rick V bf2ecaa74a
bump to 0.5.1 5 years ago
jeff 1853b28590 remove libutp and all such code related to utp 5 years ago
jeff ac2a2aed1d gut libutp and finish making things compile and pass tests 5 years ago
Jeff Becker 4bf6882c8a
more async cryptography 5 years ago
Jeff 325b697e90
Merge pull request #787 from despair86/master
make build internally consistent, bump windows version to 0.5.0
5 years ago
Michael edd0ec398f
Move thread stuff to subdirectory 5 years ago
Michael 0950571313
Move metrics to subdirectory 5 years ago
Michael 4d8fe2a8a8
Move meta programming to subdirectory 5 years ago
Rick V 6205e96c36
move non-string version info to common header 5 years ago
Rick V 51279075d8
iconv 🅱roke 5 years ago
Rick V df430650ef
undo utf8 conversion 5 years ago
Rick V fb70d7afc9
bump version for release 5 years ago
Jeff 146d977945 make osx unit tests compile on old gcc 5 years ago
Jeff b42605d1ba
Merge pull request #783 from majestrate/iwp-redux
Add "new" (old) link protocol: IWP
5 years ago
Jeff Becker b5402dc6c3
Merge remote-tracking branch 'origin/master' into iwp-redux 5 years ago
Rick V b3a975ff8e
sun fix
fix testing on sun
5 years ago