106 Commits (028e55e997d72d0677ad02d0fc149df82f4cf2da)

Author	SHA1	Message	Date
Stephen Shelton	028e55e997	Remove pre-refactor config test	4 years ago
Stephen Shelton	6301fefd43	Add router-specific config comments	4 years ago
Stephen Shelton	5b520a4dff	Simplify connection limit constants	4 years ago
Stephen Shelton	14e7789847	Add padding to config file generated output	4 years ago
Stephen Shelton	1273f11ce8	First pass at updating comments to lokinet config	4 years ago
Stephen Shelton	18ee23c2a3	Support for comments in config definition	4 years ago
Stephen Shelton	1653b73ee5	Clean up the logic around generating default confs	4 years ago
Stephen Shelton	c5ff672c79	Use 'undeclared handler' for multi-valued 'add-node' config option	4 years ago
Stephen Shelton	feacde7864	Hook up 'undeclared handlers' to mop up loosely-structured INI values	4 years ago
Stephen Shelton	9a1b7b20de	Add "undeclared value" handler to Configuration	4 years ago
Stephen Shelton	ffc58fcedb	Remove dead code (serverOptions)	4 years ago
Stephen Shelton	2e47262350	Demystify LinksConfig	4 years ago
Stephen Shelton	cd1e7713de	Clean up / consolidate config logging logic	4 years ago
Stephen Shelton	4c00c6238e	Join config definition and config parser	4 years ago
Stephen Shelton	653a650cf9	Fix typo	4 years ago
Stephen Shelton	9f0ae43149	Remove dead code	4 years ago
Stephen Shelton	d82f5e6b93	First pass at replacing config value logic	4 years ago
Stephen Shelton	69331f1571	Remove multiValued as an argument to ConfigDefinition	4 years ago
Stephen Shelton	f6d000838f	Clarity and convenience for defining config options	4 years ago
Stephen Shelton	02e31f3867	Introduce acceptor function in ConfigDefinition	4 years ago
Stephen Shelton	60d0bf2a9b	Rename function for clarity	4 years ago
Stephen Shelton	8160c13458	More documentation around Configuration/ConfigDefinition	4 years ago
Stephen Shelton	8352de7bd4	Config documentation, clarity	4 years ago
Stephen Shelton	d9340a873e	Consolidate Configuration generate INI functions	4 years ago
Stephen Shelton	1b19314278	Implement Configuration::generateDefaultConfig(), maintain insertion order	4 years ago
Stephen Shelton	7dacc30862	Conveience and clarity around config definiton maps	4 years ago
Stephen Shelton	105dd30fd9	More ConfigDefinition unit tests, fixes, support std::string as type	4 years ago
Stephen Shelton	25212b929c	Add ConfigDefinition unit tests, fixes	4 years ago
Stephen Shelton	a856e772c8	Stylistic clean up	4 years ago
Stephen Shelton	0fb888890f	First pass at Configuration definition classes	4 years ago
Stephen Shelton	9d71228e74	Replace config visit pattern with explicit lookups ... This is an initial pass at doing explicit value checks when handling config parsing, as opposed to using a visiting pattern. The latter made it difficult to check for conditions such as missing required values, multiple values, etc. It was also generally less readable (think declarative) which further made it difficult to get a grasp for what our actual configuration file requirements were.	4 years ago
Stephen Shelton	ca67c12928	Why template when we only use one type??	4 years ago
Stephen Shelton	273270916e	The Great Wall of Blame ... This commit reflects changes to clang-format rules. Unfortunately, these rule changes create a massive change to the codebase, which causes an apparent rewrite of git history. Git blame's --ignore-rev flag can be used to ignore this commit when attempting to `git blame` some code.	4 years ago
Jeff	d3091cf9fc	Merge pull request #1167 from tewinget/tooling ... RouterHive initial PR	4 years ago
Jeff	bf82740c08	only try fetching identity key once so we can interrupt lokinet (#1178)	4 years ago
Thomas Winget	84a1d7dbcc	clang format.......	4 years ago
Thomas Winget	0f34a950a9	pybind config object, working	4 years ago
Jeff Becker	a5dc41b049	OMG IT DOES STUFF :DDDDDD	4 years ago
Jason Rhinelander	04c618ddae	gcc 5 compatibility workaround	4 years ago
Jason Rhinelander	3bd400f6fe	Fix string_view C++17 compatibility ... string_view was implicitly convertible to std::string, but std::string_view is only explicitly convertible. This makes the `operator std::string` explicit to be more compatible, and re-adds a bunch of explicit string casts to the code where needed. (This also fixes the build if changing the standard to c++17)	4 years ago
Jason Rhinelander	46242ba69b	TrimWhiteSpace -> TrimWhitespace ... Fix my dumb initial capitalization choice.	4 years ago
Jason Rhinelander	74d4afad51	Remove metric config parsing	4 years ago
Jason Rhinelander	54186c4a89	Replace absl string_view with string_view from lokimq ... When we add loki-mq has a dependency we can just alias it, but for now it's easier to copy the header than add the whole submodule library.	4 years ago
Jason Rhinelander	089056ca5b	Remove all ABSL_ATTRIBUTE_UNUSED uses	4 years ago
Jason Rhinelander	5efcd49a3b	Deabseil: remove absl::StrCat, de-templatize fromEnv ... fromEnv here wasn't usefully templatized (the base template basically couldn't be used for anything except a string anyway), so just replaced it with the overloads we need and moved the implementations out of the header.	4 years ago
Jason Rhinelander	98c34d995b	De-abseil: Add our own llarp::TrimWhiteSpace ... Adds a TrimWhiteSpace instead of using abseil's. Adds Catch2 tests for it, and also converts the existing str tests to catch (which look much, much nicer than the gtest ones).	4 years ago
Jason Rhinelander	b4440094b0	De-abseil, part 2: mutex, locks, (most) time ... - util::Mutex is now a std::shared_timed_mutex, which is capable of exclusive and shared locks. - util::Lock is still present as a std::lock_guard<util::Mutex>. - the locking annotations are preserved, but updated to the latest supported by clang rather than using abseil's older/deprecated ones. - ACQUIRE_LOCK macro is gone since we don't pass mutexes by pointer into locks anymore (WTF abseil). - ReleasableLock is gone. Instead there are now some llarp::util helper methods to obtain unique and/or shared locks: - `auto lock = util::unique_lock(mutex);` gets an RAII-but-also unlockable object (std::unique_lock<T>, with T inferred from `mutex`). - `auto lock = util::shared_lock(mutex);` gets an RAII shared (i.e. "reader") lock of the mutex. - `auto lock = util::unique_locks(mutex1, mutex2, mutex3);` can be used to atomically lock multiple mutexes at once (returning a tuple of the locks). This are templated on the mutex which makes them a bit more flexible than using a concrete type: they can be used for any type of lockable mutex, not only util::Mutex. (Some of the code here uses them for getting locks around a std::mutex). Until C++17, using the RAII types is painfully verbose: ```C++ // pre-C++17 - needing to figure out the mutex type here is annoying: std::unique_lock<util::Mutex> lock(mutex); // pre-C++17 and even more verbose (but at least the type isn't needed): std::unique_lock<decltype(mutex)> lock(mutex); // our compromise: auto lock = util::unique_lock(mutex); // C++17: std::unique_lock lock(mutex); ``` All of these functions will also warn (under gcc or clang) if you discard the return value. You can also do fancy things like `auto l = util::unique_lock(mutex, std::adopt_lock)` (which lets a lock take over an already-locked mutex). - metrics code is gone, which also removes a big pile of code that was only used by metrics: - llarp::util::Scheduler - llarp:🧵:TimerQueue - llarp::util::Stopwatch	4 years ago
Jason Rhinelander	ac1486d0be	Replace absl::optional with optional-lite ... Step 1 of removing abseil from lokinet. For the most part this is a drop-in replacement, but there are also a few changes here to the JSONRPC layer that were needed to work around current gcc 10 dev snapshot: - JSONRPC returns a json now instead of an optional<json>. It doesn't make any sense to have a json rpc call that just closes the connection with returning anything. Invoked functions can return a null (default constructed) result now if they don't have anything to return (such a null value won't be added as "result").	4 years ago
Jeff Becker	40876a6e3f	configurable log level	4 years ago
Stephen Shelton	1300de2387	Enable the JSON RPC API by default	5 years ago