Merge pull request #1236 from jagerman/macos-deployment-target-dev

Set -mmacosx-version-min the cmake way
4 years ago · ffae1a7f11
parent e685d1fcf9 3048ccf3f8
commit ffae1a7f11
2 changed files with 2 additions and 5 deletions
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@ -1,5 +1,7 @@
 cmake_minimum_required(VERSION 3.10)  # bionic's cmake version

+set(CMAKE_OSX_DEPLOYMENT_TARGET 10.13)  # Has to be set before `project()`, and ignored on non-macos
+
 find_program(CCACHE_PROGRAM ccache)
 if(CCACHE_PROGRAM)
  set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CCACHE_PROGRAM}")
--- a/cmake/unix.cmake
+++ b/cmake/unix.cmake
@ -2,11 +2,6 @@ if(NOT UNIX)
  return()
 endif()

-# because apple means embracing bitrot
-if(APPLE)
-  add_compile_options(-mmacosx-version-min=10.13)
-endif()
-
 include(CheckCXXSourceCompiles)
 include(CheckLibraryExists)