clean up calls to NodeDB::GetIf to be cleaner and more concise

llarp/path/pathbuilder.cpp

@@ -228,10 +228,10 @@ namespace llarp
     std::optional<std::vector<RouterContact>>
     Builder::GetHopsForBuild()
     {
-      if (const auto maybe = m_router->nodedb()->GetIf([r = m_router](const auto& rc) -> bool {
-            return not r->routerProfiling().IsBadForPath(rc.pubkey);
-          });
-          maybe.has_value())
+      auto filter = [r = m_router](const auto& rc) -> bool {
+        return not r->routerProfiling().IsBadForPath(rc.pubkey);
+      };
+      if (const auto maybe = m_router->nodedb()->GetIf(filter))
       {
         return GetHopsAlignedToForBuild(maybe->pubkey);
       }

llarp/router/router.cpp

@@ -150,8 +150,7 @@ namespace llarp
       return _rcLookupHandler.GetRandomWhitelistRouter(router);
     }
 
-    if (const auto maybe = nodedb()->GetIf([](const auto&) -> bool { return true; }, true);
-        maybe.has_value())
+    if (const auto maybe = nodedb()->GetIf([](const auto&) -> bool { return true; }))
     {
       router = maybe->pubkey;
       return true;