Merge pull request #1028 from majestrate/remove-assert-with-sideffect-2020-01-08

remove side effect from address detection assert

llarp/net/net.cpp

@@ -230,7 +230,7 @@ _llarp_nt_getadaptersinfo(struct llarp_nt_ifaddrs_t** ifap)
   struct _llarp_nt_ifaddrs_t* ifa =
       llarp_nt_new0(struct _llarp_nt_ifaddrs_t, n);
   struct _llarp_nt_ifaddrs_t* ift = ifa;
-
+  int val                         = 0;
   /* now populate list */
   for(pAdapter = pAdapterInfo; pAdapter; pAdapter = pAdapter->Next)
   {
@@ -243,9 +243,9 @@ _llarp_nt_getadaptersinfo(struct llarp_nt_ifaddrs_t** ifap)
 
       /* address */
       ift->_ifa.ifa_addr = (struct sockaddr*)&ift->_addr;
-      assert(1
-             == llarp_nt_sockaddr_pton(pIPAddr->IpAddress.String,
-                                       ift->_ifa.ifa_addr));
+      val =
+          llarp_nt_sockaddr_pton(pIPAddr->IpAddress.String, ift->_ifa.ifa_addr);
+      assert(1 == val);
 
       /* name */
 #ifdef DEBUG
@@ -262,9 +262,9 @@ _llarp_nt_getadaptersinfo(struct llarp_nt_ifaddrs_t** ifap)
 
       /* netmask */
       ift->_ifa.ifa_netmask = (sockaddr*)&ift->_netmask;
-      assert(1
-             == llarp_nt_sockaddr_pton(pIPAddr->IpMask.String,
-                                       ift->_ifa.ifa_netmask));
+      val =
+          llarp_nt_sockaddr_pton(pIPAddr->IpMask.String, ift->_ifa.ifa_netmask);
+      assert(1 == val);
 
       /* next */
       if(k++ < (n - 1))